0f0b6ff6a322c1b6f3d8ee698afeb2ab90ad6e59
Files Diff
- Added: 284
- Removed: 177
- Renamed: 0
- Modified: 6
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move Source Folder | 1 | ||
| Move Source Folder src/community/taskmanager to src/community/taskmanager/core | From | To | |
| Extract Attribute | 1 | ||
| Extract Attribute public NAME : String in class org.geoserver.taskmanager.beans.DummyAction | From | To | |
| Move Class | 12 | ||
| Move Class org.geoserver.taskmanager.external.LookupGSServiceImpl moved to org.geoserver.taskmanager.external.impl.LookupGSServiceImpl | From | To | |
| Move Class org.geoserver.taskmanager.external.H2DbSourceImpl moved to org.geoserver.taskmanager.external.impl.H2DbSourceImpl | From | To | |
| Move Class org.geoserver.taskmanager.external.PostgisDbSourceImpl moved to org.geoserver.taskmanager.external.impl.PostgisDbSourceImpl | From | To | |
| Move Class org.geoserver.taskmanager.external.DefaultDialectImpl moved to org.geoserver.taskmanager.external.impl.DefaultDialectImpl | From | To | |
| Move Class org.geoserver.taskmanager.external.DbTableImpl moved to org.geoserver.taskmanager.external.impl.DbTableImpl | From | To | |
| Move Class org.geoserver.taskmanager.external.InformixDialectImpl moved to org.geoserver.taskmanager.external.impl.InformixDialectImpl | From | To | |
| Move Class org.geoserver.taskmanager.external.ExternalGSImpl moved to org.geoserver.taskmanager.external.impl.ExternalGSImpl | From | To | |
| Move Class org.geoserver.taskmanager.external.PostgisDialectImpl moved to org.geoserver.taskmanager.external.impl.PostgisDialectImpl | From | To | |
| Move Class org.geoserver.taskmanager.external.LookupDbSourceServiceImpl moved to org.geoserver.taskmanager.external.impl.LookupDbSourceServiceImpl | From | To | |
| Move Class org.geoserver.taskmanager.external.GenericDbSourceImpl moved to org.geoserver.taskmanager.external.impl.GenericDbSourceImpl | From | To | |
| Move Class org.geoserver.taskmanager.external.H2DialectImpl moved to org.geoserver.taskmanager.external.impl.H2DialectImpl | From | To | |
| Move Class org.geoserver.taskmanager.external.InformixDbSourceImpl moved to org.geoserver.taskmanager.external.impl.InformixDbSourceImpl | From | To | |
| Extract Variable | 6 | ||
| Extract Variable triggerKey : TriggerKey in method public interrupt(batchRun BatchRun) : void from class org.geoserver.taskmanager.schedule.impl.BatchJobServiceImpl | From | To | |
| Extract Variable source : DbSource in method public setupBatch() : void from class org.geoserver.taskmanager.tasks.DbLocalPublicationTaskTest | From | To | |
| Extract Variable dbName : String in method public cleanup(ctx TaskContext) : void from class org.geoserver.taskmanager.tasks.DbLocalPublicationTaskTypeImpl | From | To | |
| Extract Variable tempSchema : String in method public run(ctx TaskContext) : TaskResult from class org.geoserver.taskmanager.tasks.CopyTableTaskTypeImpl | From | To | |
| Extract Variable value : String in method public validate(configuration Configuration) : List<ValidationError> from class org.geoserver.taskmanager.util.TaskManagerTaskUtil | From | To | |
| Extract Variable fileService : ParameterInfo in method public initParamInfo() : void from class org.geoserver.taskmanager.tasks.FileLocalPublicationTaskTypeImpl | From | To | |
| Change Variable Type | 6 | ||
| Change Variable Type editLayer : LayerInfo to editResource : ResourceInfo in method public commit() : void in class org.geoserver.taskmanager.tasks.DbLocalPublicationTaskTypeImpl.run | From | To | |
| Change Variable Type batchName : String to batchId : Integer in method public execute(context JobExecutionContext) : void in class org.geoserver.taskmanager.schedule.impl.BatchJobImpl | From | To | |
| Change Variable Type result : Set<Action> to result : Set<String> in method public getActionsForAttribute(attribute Attribute, config Configuration) : List<String> in class org.geoserver.taskmanager.util.TaskManagerTaskUtil | From | To | |
| Change Variable Type editLayer : LayerInfo to editResource : ResourceInfo in method public commit() : void in class org.geoserver.taskmanager.tasks.FileLocalPublicationTaskTypeImpl.run | From | To | |
| Change Variable Type actions : List<Action> to actions : List<String> in method public testGetActionsForAttribute() : void in class org.geoserver.taskmanager.util.TaskManagerTaskUtilTest | From | To | |
| Change Variable Type actions : List<Action> to actions : List<String> in method protected getComponentForProperty(id String, itemModel IModel<Attribute>, property Property<Attribute>) : Component in class org.geoserver.taskmanager.web.ConfigurationPage.attributesPanel | From | To | |
| Extract Method | 7 | ||
| Extract Method private viewOrTableExists(dbName String, schema String, pattern String) : boolean extracted from private viewOrTableExists(schema String, pattern String) : boolean in class org.geoserver.taskmanager.tasks.ConsecutiveTest | From | To | |
| Extract Method package coverageInfo(name QName, coverageFile Object, gridFormat String, styleName String) : void extracted from package coverageInfo(name QName, coverageFile File, styleName String) : void in class org.geoserver.data.test.MockData | From | To | |
| Extract Method protected syncMetadata(resource ResourceInfo) : GSResourceEncoder extracted from public run(ctx TaskContext) : TaskResult in class org.geoserver.taskmanager.tasks.MetadataSyncTaskTypeImpl | From | To | |
| Extract Method protected getStoreName(store StoreInfo, ctx TaskContext) : String extracted from public cleanup(ctx TaskContext) : void in class org.geoserver.taskmanager.tasks.AbstractRemotePublicationTaskTypeImpl | From | To | |
| Extract Method private getNumberOfRecords(dbName String, tableName String) : int extracted from private getNumberOfRecords(tableName String) : int in class org.geoserver.taskmanager.tasks.ConsecutiveTest | From | To | |
| Extract Method protected getStoreName(store StoreInfo, ctx TaskContext) : String extracted from public run(ctx TaskContext) : TaskResult in class org.geoserver.taskmanager.tasks.AbstractRemotePublicationTaskTypeImpl | From | To | |
| Extract Method private getNumberOfColumns(dbName String, tableName String) : int extracted from private getNumberOfColumns(tableName String) : int in class org.geoserver.taskmanager.tasks.ConsecutiveTest | From | To | |
| Rename Method | 2 | ||
| Rename Method protected mustCleanUpStore() : boolean renamed to protected neverReuseStore() : boolean in class org.geoserver.taskmanager.tasks.DbRemotePublicationTaskTypeImpl | From | To | |
| Rename Method protected abstract mustCleanUpStore() : boolean renamed to protected abstract neverReuseStore() : boolean in class org.geoserver.taskmanager.tasks.AbstractRemotePublicationTaskTypeImpl | From | To | |
| Rename Variable | 3 | ||
| Rename Variable editLayer : LayerInfo to editResource : ResourceInfo in method public commit() : void in class org.geoserver.taskmanager.tasks.DbLocalPublicationTaskTypeImpl.run | From | To | |
| Rename Variable batchName : String to batchId : Integer in method public execute(context JobExecutionContext) : void in class org.geoserver.taskmanager.schedule.impl.BatchJobImpl | From | To | |
| Rename Variable editLayer : LayerInfo to editResource : ResourceInfo in method public commit() : void in class org.geoserver.taskmanager.tasks.FileLocalPublicationTaskTypeImpl.run | From | To | |
| Change Return Type | 6 | ||
| Change Return Type void to String in method public scheduleNow(batch Batch) : String in class org.geoserver.taskmanager.schedule.BatchJobService | From | To | |
| Change Return Type List<Action> to List<String> in method public getActionsForAttribute(attribute Attribute, config Configuration) : List<String> in class org.geoserver.taskmanager.util.TaskManagerTaskUtil | From | To | |
| Change Return Type String to void in method public execute(onPage ConfigurationPage, target AjaxRequestTarget, valueModel IModel<String>, dependsOnRawValues List<String>) : void in class org.geoserver.taskmanager.web.action.Action | From | To | |
| Change Return Type void to String in method public scheduleNow(batch Batch) : String in class org.geoserver.taskmanager.schedule.impl.BatchJobServiceImpl | From | To | |
| Change Return Type Set<String> to SortedSet<String> in method public names() : SortedSet<String> in class org.geoserver.taskmanager.util.LookupServiceImpl | From | To | |
| Change Return Type String to void in method public execute(onPage ConfigurationPage, target AjaxRequestTarget, valueModel IModel<String>, dependentValues List<String>) : void in class org.geoserver.taskmanager.web.action.LayerEditAction | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute FILE_NAME : String to FILE_LOCATION : String in class org.geoserver.taskmanager.tasks.FileLocalPublicationTaskTest | From | To | |
| Extract Interface | 1 | ||
| Extract Interface org.geoserver.taskmanager.util.LookupService from classes [org.geoserver.taskmanager.util.LookupServiceImpl] | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type map : Map<String,T> to map : NavigableMap<String,T> in class org.geoserver.taskmanager.util.LookupServiceImpl | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method protected syncMetadata(resource ResourceInfo, name String) : GSResourceEncoder extracted from public run(ctx TaskContext) : TaskResult in class org.geoserver.taskmanager.tasks.AbstractRemotePublicationTaskTypeImpl & moved to class org.geoserver.taskmanager.tasks.MetadataSyncTaskTypeImpl | From | To | |
| Extract And Move Method protected saveOrApplyButton(id String, doReturn boolean) : AjaxSubmitLink extracted from public onInitialize() : void in class org.geoserver.taskmanager.web.ConfigurationPage & moved to class org.geoserver.taskmanager.web.BatchPage | From | To |