14d7d4069fdc94edc25f925906f3741aebb0db63
Files Diff
- Added: 10
- Removed: 0
- Renamed: 0
- Modified: 78
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method public init(b Batch) : Batch from class org.geoserver.taskmanager.util.TaskManagerDataUtil to public initHistory(b Batch) : Batch from class org.geoserver.taskmanager.data.impl.TaskManagerDaoImpl | From | To | |
| Move Method | 7 | ||
| Move Method private wsName(ws WorkspaceInfo) : String from class org.geoserver.taskmanager.tasks.AbstractRemotePublicationTaskTypeImpl to public wsName(ws WorkspaceInfo) : String from class org.geoserver.taskmanager.util.CatalogUtil | From | To | |
| Move Method private taskInUseByExternalBatch(config Configuration) : BatchElement from class org.geoserver.taskmanager.web.AbstractConfigurationsPage to public taskInUseByExternalBatch(config Configuration) : BatchElement from class org.geoserver.taskmanager.util.TaskManagerDataUtil | From | To | |
| Move Method private uriToResource(uri URI) : Resource from class org.geoserver.taskmanager.tasks.AbstractRemotePublicationTaskTypeImpl to private uriToResource(uri URI) : Resource from class org.geoserver.taskmanager.util.CatalogUtil | From | To | |
| Move Method protected syncMetadata(resource ResourceInfo, name String) : GSResourceEncoder from class org.geoserver.taskmanager.tasks.MetadataSyncTaskTypeImpl to public syncMetadata(resource ResourceInfo, name String) : GSResourceEncoder from class org.geoserver.taskmanager.util.CatalogUtil | From | To | |
| Move Method protected syncMetadata(resource ResourceInfo) : GSResourceEncoder from class org.geoserver.taskmanager.tasks.MetadataSyncTaskTypeImpl to public syncMetadata(resource ResourceInfo) : GSResourceEncoder from class org.geoserver.taskmanager.util.CatalogUtil | From | To | |
| Move Method private createStyleZipFile(style StyleInfo) : File from class org.geoserver.taskmanager.tasks.AbstractRemotePublicationTaskTypeImpl to public createStyleZipFile(style StyleInfo) : File from class org.geoserver.taskmanager.util.CatalogUtil | From | To | |
| Move Method private taskInUse(task Task) : BatchElement from class org.geoserver.taskmanager.web.ConfigurationPage to public taskInUse(task Task, config Configuration) : BatchElement from class org.geoserver.taskmanager.util.TaskManagerDataUtil | From | To | |
| Move Attribute | 2 | ||
| Move Attribute protected geoServerDataDirectory : GeoServerDataDirectory from class org.geoserver.taskmanager.tasks.MetadataSyncTaskTypeImpl to protected geoServerDataDirectory : GeoServerDataDirectory from class org.geoserver.taskmanager.util.CatalogUtil | From | To | |
| Move Attribute protected geoServerDataDirectory : GeoServerDataDirectory from class org.geoserver.taskmanager.tasks.AbstractRemotePublicationTaskTypeImpl to protected geoServerDataDirectory : GeoServerDataDirectory from class org.geoserver.taskmanager.util.CatalogUtil | From | To | |
| Extract Class | 2 | ||
| Extract Class org.geoserver.taskmanager.util.CatalogUtil from class org.geoserver.taskmanager.tasks.AbstractRemotePublicationTaskTypeImpl | From | To | |
| Extract Class org.geoserver.taskmanager.util.CatalogUtil from class org.geoserver.taskmanager.tasks.MetadataSyncTaskTypeImpl | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type workspaces : List<String> to workspaces : SortedSet<String> in method public onInitialize() : void in class org.geoserver.taskmanager.web.ConfigurationPage | From | To | |
| Change Variable Type workspaces : List<String> to workspaces : SortedSet<String> in method public onInitialize() : void in class org.geoserver.taskmanager.web.BatchPage | From | To | |
| Extract Variable | 2 | ||
| Extract Variable batch : Batch in method protected orderTasksForCleanup(config Configuration) : List<Task> from class org.geoserver.taskmanager.util.TaskManagerTaskUtil | From | To | |
| Extract Variable object : S3Object in method public read(filePath String) : InputStream from class org.geoserver.taskmanager.external.impl.S3FileServiceImpl | From | To | |
| Inline Variable | 1 | ||
| Inline Variable task : Task in method public execute(context JobExecutionContext) : void from class org.geoserver.taskmanager.schedule.impl.BatchJobImpl | From | To | |
| Extract Method | 2 | ||
| Extract Method protected orderTasksForCleanup(config Configuration) : List<Task> extracted from public cleanup(config Configuration) : boolean in class org.geoserver.taskmanager.util.TaskManagerTaskUtil | From | To | |
| Extract Method protected reorder(batch Batch) : void extracted from public save(batch Batch) : Batch in class org.geoserver.taskmanager.data.impl.TaskManagerDaoImpl | From | To | |
| Rename Method | 2 | ||
| Rename Method public setName(name String) : void renamed to public setPrepareScript(prepareScript String) : void in class org.geoserver.taskmanager.external.impl.FileServiceImpl | From | To | |
| Rename Method public getName() : String renamed to public getPrepareScript() : String in class org.geoserver.taskmanager.external.impl.FileServiceImpl | From | To | |
| Change Return Type | 1 | ||
| Change Return Type List<? extends BatchElement> to List<BatchElement> in method public getBatchElements() : List<BatchElement> in class org.geoserver.taskmanager.data.Task | From | To | |
| Extract Superclass | 2 | ||
| Extract Superclass org.geoserver.taskmanager.util.SecuredImpl from classes [org.geoserver.taskmanager.external.impl.FileServiceImpl, org.geoserver.taskmanager.external.impl.GenericDbSourceImpl, org.geoserver.taskmanager.external.impl.H2DbSourceImpl, org.geoserver.taskmanager.external.impl.InformixDbSourceImpl, org.geoserver.taskmanager.external.impl.PostgisDbSourceImpl, org.geoserver.taskmanager.external.impl.PostgisJndiDbSourceImpl] | From | To | |
| Extract Superclass org.geoserver.taskmanager.util.SecuredLookupServiceImpl from classes [org.geoserver.taskmanager.external.impl.LookupDbSourceServiceImpl, org.geoserver.taskmanager.external.impl.LookupFileServiceImpl] | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute name : String to prepareScript : String in class org.geoserver.taskmanager.external.impl.FileServiceImpl | From | To | |
| Rename Attribute config : Configuration to configModel : IModel<Configuration> in class org.geoserver.taskmanager.web.ConfigurationPageTest | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type config : Configuration to configModel : IModel<Configuration> in class org.geoserver.taskmanager.web.ConfigurationPageTest | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter name : String to prepareScript : String in method public setPrepareScript(prepareScript String) : void in class org.geoserver.taskmanager.external.impl.FileServiceImpl | From | To |