1b7154a4f0126f84e4d0cbb71b6d85e85d084908
Files Diff
- Added: 4
- Removed: 0
- Renamed: 0
- Modified: 14
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 6 | ||
| Rename Method public putCollectionLayer(collection String, layer CollectionLayer) : ResponseEntity<Object> renamed to private createReplaceLayer(collection String, layer CollectionLayer, previousLayerPredicate Predicate<CollectionLayer>) : ResponseEntity<Object> in class org.geoserver.opensearch.rest.CollectionsController | From | To | |
| Rename Method public buildCollectionLayerFromFeature(feature Feature) : CollectionLayer renamed to public buildCollectionLayersFromFeature(feature Feature) : List<CollectionLayer> in class org.geoserver.opensearch.eo.store.CollectionLayer | From | To | |
| Rename Method private beanToLayerCollectionFeature(layer CollectionLayer) : SimpleFeature renamed to private beansToLayerCollectionFeature(layers List<CollectionLayer>) : ListFeatureCollection in class org.geoserver.opensearch.rest.CollectionsController | From | To | |
| Rename Method private getCollectionLayer(collection String) : CollectionLayer renamed to private getCollectionLayers(collection String) : List<CollectionLayer> in class org.geoserver.opensearch.rest.CollectionsController | From | To | |
| Rename Method private buildCollectionLayerFromFeature(feature Feature, notFoundOnEmpty boolean) : CollectionLayer renamed to private buildCollectionLayersFromFeature(feature Feature, notFoundOnEmpty boolean) : List<CollectionLayer> in class org.geoserver.opensearch.rest.CollectionsController | From | To | |
| Rename Method private setupLayer(granuleLocations String, layerDefinition String, workspace String, expectSeparateBands Boolean) : void renamed to public testAddSecondLayerByPut() : void in class org.geoserver.opensearch.rest.CollectionLayerTest | From | To | |
| Move And Rename Method | 1 | ||
| Move And Rename Method public testGetCollectionLayer() : void from class org.geoserver.opensearch.rest.CollectionsControllerTest to public testGetCollectionDefaultLayer() : void from class org.geoserver.opensearch.rest.CollectionLayerTest | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type layer : CollectionLayer to layers : List<CollectionLayer> in method private beansToLayerCollectionFeature(layers List<CollectionLayer>) : ListFeatureCollection in class org.geoserver.opensearch.rest.CollectionsController | From | To | |
| Move Method | 2 | ||
| Move Method public testDeleteCollectionLayer() : void from class org.geoserver.opensearch.rest.CollectionsControllerTest to public testDeleteCollectionLayer() : void from class org.geoserver.opensearch.rest.CollectionLayerTest | From | To | |
| Move Method protected buildCollectionLayerFeatureType(name Name) : SimpleFeatureType from class org.geoserver.opensearch.eo.store.JDBCOpenSearchAccess to protected buildCollectionLayerFeatureType() : SimpleFeatureType from class org.geoserver.opensearch.eo.store.AbstractMappingStore | From | To | |
| Inline Method | 1 | ||
| Inline Method private getCollectionLayerPropertyName() : Name inlined to private beansToLayerCollectionFeature(layers List<CollectionLayer>) : ListFeatureCollection in class org.geoserver.opensearch.rest.CollectionsController | From | To | |
| Rename Variable | 3 | ||
| Rename Variable namespaceURI : String to schema : SimpleFeatureType in method private beansToLayerCollectionFeature(layers List<CollectionLayer>) : ListFeatureCollection in class org.geoserver.opensearch.rest.CollectionsController | From | To | |
| Rename Variable p : Property to layers : Collection<Property> in method public buildCollectionLayersFromFeature(feature Feature) : List<CollectionLayer> in class org.geoserver.opensearch.eo.store.CollectionLayer | From | To | |
| Rename Variable layer : CollectionLayer to layers : List<CollectionLayer> in method private buildCollectionLayersFromFeature(feature Feature, notFoundOnEmpty boolean) : List<CollectionLayer> in class org.geoserver.opensearch.rest.CollectionsController | From | To | |
| Change Return Type | 6 | ||
| Change Return Type SimpleFeature to ListFeatureCollection in method private beansToLayerCollectionFeature(layers List<CollectionLayer>) : ListFeatureCollection in class org.geoserver.opensearch.rest.CollectionsController | From | To | |
| Change Return Type Map<String,CollectionLayer> to Map<String,List<CollectionLayer>> in method private getCollectionPublishingConfigurations() : Map<String,List<CollectionLayer>> in class org.geoserver.opensearch.eo.store.JDBCOpenSearchAccess | From | To | |
| Change Return Type Feature to SimpleFeature in method private getLayerPropertyFromCollection(features FeatureCollection<FeatureType,Feature>) : SimpleFeature in class org.geoserver.opensearch.eo.JDBCOpenSearchAccessTest | From | To | |
| Change Return Type CollectionLayer to List<CollectionLayer> in method private buildCollectionLayersFromFeature(feature Feature, notFoundOnEmpty boolean) : List<CollectionLayer> in class org.geoserver.opensearch.rest.CollectionsController | From | To | |
| Change Return Type CollectionLayer to List<CollectionLayer> in method public buildCollectionLayersFromFeature(feature Feature) : List<CollectionLayer> in class org.geoserver.opensearch.eo.store.CollectionLayer | From | To | |
| Change Return Type CollectionLayer to List<CollectionLayer> in method private getCollectionLayers(collection String) : List<CollectionLayer> in class org.geoserver.opensearch.rest.CollectionsController | From | To | |
| Move And Rename Attribute | 1 | ||
| Move And Rename Attribute private LAYER_PROPERTY_NAME : Name renamed to public LAYERS_PROPERTY_NAME : Name and moved from class org.geoserver.opensearch.eo.store.AbstractMappingStore to class org.geoserver.opensearch.eo.store.OpenSearchAccess | From | To | |
| Rename Attribute | 4 | ||
| Rename Attribute LAYER_NAME : Name to LAYERS_NAME : Name in class org.geoserver.opensearch.eo.JDBCOpenSearchAccessTest | From | To | |
| Rename Attribute collectionLayerFeatureType : SimpleFeatureType to collectionLayerSchema : SimpleFeatureType in class org.geoserver.opensearch.eo.store.AbstractMappingStore | From | To | |
| Rename Attribute h2 : JDBCDataStore to store : JDBCDataStore in class org.geoserver.opensearch.eo.JDBCOpenSearchAccessTest | From | To | |
| Rename Attribute LAYER : String to LAYERS : String in class org.geoserver.opensearch.eo.store.OpenSearchAccess | From | To | |
| Change Variable Type | 7 | ||
| Change Variable Type result : Map<String,CollectionLayer> to result : Map<String,List<CollectionLayer>> in method private getCollectionPublishingConfigurations() : Map<String,List<CollectionLayer>> in class org.geoserver.opensearch.eo.store.JDBCOpenSearchAccess | From | To | |
| Change Variable Type namespaceURI : String to schema : SimpleFeatureType in method private beansToLayerCollectionFeature(layers List<CollectionLayer>) : ListFeatureCollection in class org.geoserver.opensearch.rest.CollectionsController | From | To | |
| Change Variable Type layerProperty : Property to layerProperty : Collection<Property> in method private getLayerPropertiesFromCollection(features FeatureCollection<FeatureType,Feature>) : Map<String,SimpleFeature> in class org.geoserver.opensearch.eo.JDBCOpenSearchAccessTest | From | To | |
| Change Variable Type p : Property to layers : Collection<Property> in method public buildCollectionLayersFromFeature(feature Feature) : List<CollectionLayer> in class org.geoserver.opensearch.eo.store.CollectionLayer | From | To | |
| Change Variable Type layerValue : Feature to layerValue : SimpleFeature in method public testCollectionLayerUpdate() : void in class org.geoserver.opensearch.eo.JDBCOpenSearchAccessTest | From | To | |
| Change Variable Type layer : CollectionLayer to layers : List<CollectionLayer> in method private buildCollectionLayersFromFeature(feature Feature, notFoundOnEmpty boolean) : List<CollectionLayer> in class org.geoserver.opensearch.rest.CollectionsController | From | To | |
| Change Variable Type lf : Feature to lf : SimpleFeature in method public buildCollectionLayersFromFeature(feature Feature) : List<CollectionLayer> in class org.geoserver.opensearch.eo.store.CollectionLayer | From | To | |
| Extract Method | 5 | ||
| Extract Method private getLayerPropertiesFromCollection(features FeatureCollection<FeatureType,Feature>) : Map<String,SimpleFeature> extracted from private getLayerPropertyFromCollection(features FeatureCollection<FeatureType,Feature>) : Feature in class org.geoserver.opensearch.eo.JDBCOpenSearchAccessTest | From | To | |
| Extract Method private setupDefaultLayer(granuleLocations String, layerDefinition String, workspace String, expectSeparateBands Boolean) : void extracted from private setupLayer(granuleLocations String, layerDefinition String, workspace String, expectSeparateBands Boolean) : void in class org.geoserver.opensearch.rest.CollectionLayerTest | From | To | |
| Extract Method private setupLayerFeatureTypes(names LinkedHashSet<Name>, name String, layer CollectionLayer) : void extracted from public getNames() : List<Name> in class org.geoserver.opensearch.eo.store.JDBCOpenSearchAccess | From | To | |
| Extract Method private getCollectionWithLayers(collection String) : Feature extracted from private getCollectionLayer(collection String) : CollectionLayer in class org.geoserver.opensearch.rest.CollectionsController | From | To | |
| Extract Method private removePublishing(catalog Catalog, visitor CascadeDeleteVisitor, workspace String, resourceName String) : void extracted from public cleanupTestCollectionPublishing() : void in class org.geoserver.opensearch.rest.OSEORestTestSupport | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter layer : CollectionLayer to layers : List<CollectionLayer> in method private beansToLayerCollectionFeature(layers List<CollectionLayer>) : ListFeatureCollection in class org.geoserver.opensearch.rest.CollectionsController | From | To |