3fa1601abfac4b670b1d8a7800e97a46c4e39288
Files Diff
- Added: 37
- Removed: 2
- Renamed: 0
- Modified: 79
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 6 | ||
| Rename Method public saveAndRemove(config Configuration, tasks Collection<Task>, batches Collection<Batch>) : Configuration renamed to public saveScheduleAndRemove(config Configuration, tasks Collection<Task>, batches Collection<Batch>) : Configuration in class org.geoserver.taskmanager.util.TaskManagerDataUtil | From | To | |
| Rename Method public transactionManager() : PlatformTransactionManager renamed to public jdbcConfigTransactionManager() : PlatformTransactionManager in class org.geoserver.jdbcconfig.JDBCConfigTestSupport.Config | From | To | |
| Rename Method public init() : void renamed to public before() : void in class org.geoserver.taskmanager.web.ConfigurationsPageTest | From | To | |
| Rename Method public init() : void renamed to public before() : void in class org.geoserver.taskmanager.web.BatchesPageTest | From | To | |
| Rename Method public isWritable(user Authentication, config Configuration) : boolean renamed to public isAdminable(user Authentication, config Configuration) : boolean in class org.geoserver.taskmanager.util.TaskManagerSecurityUtil | From | To | |
| Rename Method protected onSetUp(testData SystemTestData) : void renamed to public before() : void in class org.geoserver.taskmanager.web.ConfigurationPageTest | From | To | |
| Change Return Type | 7 | ||
| Change Return Type void to String in method public execute(onPage ConfigurationPage, value String) : String in class org.geoserver.taskmanager.web.action.LayerEditAction | From | To | |
| Change Return Type void to String in method public execute(onPage ConfigurationPage, value String) : String in class org.geoserver.taskmanager.web.action.Action | From | To | |
| Change Return Type Map<String,Object> to Map<String,Serializable> in method public getParameters() : Map<String,Serializable> in class org.geoserver.taskmanager.external.InformixDbSourceImpl | From | To | |
| Change Return Type Map<String,Object> to Map<String,Serializable> in method public getParameters() : Map<String,Serializable> in class org.geoserver.taskmanager.external.GenericDbSourceImpl | From | To | |
| Change Return Type Map<String,Object> to Map<String,Serializable> in method public getParameters() : Map<String,Serializable> in class org.geoserver.taskmanager.external.DbSource | From | To | |
| Change Return Type Map<String,Object> to Map<String,Serializable> in method public getParameters() : Map<String,Serializable> in class org.geoserver.taskmanager.external.H2DbSourceImpl | From | To | |
| Change Return Type Map<String,Object> to Map<String,Serializable> in method public getParameters() : Map<String,Serializable> in class org.geoserver.taskmanager.external.PostgisDbSourceImpl | From | To | |
| Move Class | 2 | ||
| Move Class org.geoserver.taskmanager.schedule.TestReportServiceImpl moved to org.geoserver.taskmanager.beans.TestReportServiceImpl | From | To | |
| Move Class org.geoserver.taskmanager.schedule.TestTaskTypeImpl moved to org.geoserver.taskmanager.beans.TestTaskTypeImpl | From | To | |
| Merge Parameter | 3 | ||
| Merge Parameter [parameterValues : Map<String,Object>, tempValues : Map<Object,Object>] to ctx : TaskContext in method public run(ctx TaskContext) : TaskResult in class org.geoserver.taskmanager.tasks.AbstractCreateViewTaskTypeImpl | From | To | |
| Merge Parameter [task : Task, parameterValues : Map<String,Object>] to ctx : TaskContext in method public run(ctx TaskContext) : TaskResult in class org.geoserver.taskmanager.beans.TestTaskTypeImpl | From | To | |
| Merge Parameter [parameterValues : Map<String,Object>, tempValues : Map<Object,Object>] to ctx : TaskContext in method public run(ctx TaskContext) : TaskResult in class org.geoserver.taskmanager.tasks.CopyTableTaskTypeImpl | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.geoserver.taskmanager.AbstractWicketTaskManagerTest from classes [org.geoserver.taskmanager.web.BatchesPageTest, org.geoserver.taskmanager.web.ConfigurationPageTest, org.geoserver.taskmanager.web.ConfigurationsPageTest] | From | To | |
| Extract Variable | 3 | ||
| Extract Variable viewNameQuoted : String in method public commit() : void from class org.geoserver.taskmanager.tasks.AbstractCreateViewTaskTypeImpl.run | From | To | |
| Extract Variable value : String in method public buildQueryDefinition(ctx TaskContext, dependency BatchContext.Dependency) : String from class org.geoserver.taskmanager.tasks.CreateComplexViewTaskTypeImpl | From | To | |
| Extract Variable dbInfo : ParameterInfo in method public initParamInfo() : void from class org.geoserver.taskmanager.tasks.DbLocalPublicationTaskTypeImpl | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type params : Map<String,Object> to params : Map<String,Serializable> in method public getParameters() : Map<String,Serializable> in class org.geoserver.taskmanager.external.PostgisDbSourceImpl | From | To | |
| Extract Method | 1 | ||
| Extract Method public cleanup(task Task) : boolean extracted from public cleanup(config Configuration) : boolean in class org.geoserver.taskmanager.util.TaskManagerTaskUtil | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type value : String to value : byte[] in class org.geoserver.taskmanager.data.impl.AttributeImpl | From | To | |
| Change Attribute Type message : String to message : byte[] in class org.geoserver.taskmanager.data.impl.RunImpl | From | To |