49dbc2ee13bfc4a3cb46510bb77ede3dafbcff27
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 7
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Pull Up Method | 1 | ||
| Pull Up Method private parseCollectionPartsFromZip(body InputStream) : Map<CollectionPart,byte[]> from class org.geoserver.opensearch.rest.CollectionsController to protected parsePartsFromZip(body InputStream, parts T[]) : Map<T,byte[]> from class org.geoserver.opensearch.rest.AbstractOpenSearchController | From | To | |
| Change Return Type | 1 | ||
| Change Return Type Map<CollectionPart,byte[]> to Map<T,byte[]> in method protected parsePartsFromZip(body InputStream, parts T[]) : Map<T,byte[]> in class org.geoserver.opensearch.rest.AbstractOpenSearchController | From | To | |
| Pull Up Attribute | 2 | ||
| Pull Up Attribute package LOGGER : Logger from class org.geoserver.opensearch.rest.CollectionsController to package LOGGER : Logger from class org.geoserver.opensearch.rest.AbstractOpenSearchController | From | To | |
| Pull Up Attribute package jsonConverter : OseoJSONConverter from class org.geoserver.opensearch.rest.CollectionsController to protected jsonConverter : OseoJSONConverter from class org.geoserver.opensearch.rest.AbstractOpenSearchController | From | To | |
| Extract Method | 9 | ||
| Extract Method private assertProductCreated() : void extracted from public testCreateProduct() : void in class org.geoserver.opensearch.rest.ProductsControllerTest | From | To | |
| Extract Method private assertProductGranules() : void extracted from public testPutProductGranules() : void in class org.geoserver.opensearch.rest.ProductsControllerTest | From | To | |
| Extract Method private returnCreatedCollectionReference(request HttpServletRequest, eoId String) : ResponseEntity<String> extracted from public postCollectionJson(request HttpServletRequest, feature SimpleFeature) : ResponseEntity<String> in class org.geoserver.opensearch.rest.CollectionsController | From | To | |
| Extract Method private returnCreatedCollectionReference(request HttpServletRequest, eoId String) : ResponseEntity<String> extracted from public postCollectionZip(request HttpServletRequest, body InputStream) : ResponseEntity<String> in class org.geoserver.opensearch.rest.CollectionsController | From | To | |
| Extract Method private returnCreatedProductReference(collection String, request HttpServletRequest, productId String) : ResponseEntity<String> extracted from public postProductJson(collection String, request HttpServletRequest, feature SimpleFeature) : ResponseEntity<String> in class org.geoserver.opensearch.rest.ProductsController | From | To | |
| Extract Method private assertProductLinks() : void extracted from public testPutProductLinks() : void in class org.geoserver.opensearch.rest.ProductsControllerTest | From | To | |
| Extract Method private assertProductDescription() : void extracted from public testPutProductDescription() : void in class org.geoserver.opensearch.rest.ProductsControllerTest | From | To | |
| Extract Method private assertProductThumbnail() : void extracted from public testPutProductThumbnail() : void in class org.geoserver.opensearch.rest.ProductsControllerTest | From | To | |
| Extract Method private assertProductMetadata() : void extracted from public testPutProductMetadata() : void in class org.geoserver.opensearch.rest.ProductsControllerTest | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method protected parseGeoJSONFeature(fileReference String, payload byte[]) : SimpleFeature extracted from public postCollectionZip(request HttpServletRequest, body InputStream) : ResponseEntity<String> in class org.geoserver.opensearch.rest.CollectionsController & moved to class org.geoserver.opensearch.rest.AbstractOpenSearchController | From | To | |
| Extract And Move Method protected parseJSON(clazz Class<T>, rawData byte[]) : T extracted from public postCollectionZip(request HttpServletRequest, body InputStream) : ResponseEntity<String> in class org.geoserver.opensearch.rest.CollectionsController & moved to class org.geoserver.opensearch.rest.AbstractOpenSearchController | From | To |