6084b5469c2a808f427af9d2c6444b82e86b63b3
Files Diff
- Added: 22
- Removed: 0
- Renamed: 0
- Modified: 18
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Change Parameter Type | 6 | ||
Change Parameter Type form : Form to form : Form<?> in method protected baseURL(form Form<?>) : String in class org.geoserver.wms.web.data.ExternalGraphicPanel | From | To | |
Change Parameter Type model : IModel to model : IModel<StyleInfo> in method package styleLink(id String, model IModel<StyleInfo>) : Component in class org.geoserver.wms.web.data.StylePage | From | To | |
Change Parameter Type object : Object to object : StyleType in method public getIdValue(object StyleType, index int) : String in class org.geoserver.wms.web.publish.StyleTypeChoiceRenderer | From | To | |
Change Parameter Type styleForm : Form to styleForm : Form<?> in method public ExternalGraphicPanel(id String, styleModel CompoundPropertyModel<StyleInfo>, styleForm Form<?>) in class org.geoserver.wms.web.data.ExternalGraphicPanel | From | To | |
Change Parameter Type model : IModel to model : IModel<StyleInfo> in method package workspaceLink(id String, model IModel<StyleInfo>) : Component in class org.geoserver.wms.web.data.StylePage | From | To | |
Change Parameter Type object : Object to object : StyleType in method public getDisplayValue(object StyleType) : Object in class org.geoserver.wms.web.publish.StyleTypeChoiceRenderer | From | To | |
Move Method | 2 | ||
Move Method package copyLink() : AjaxSubmitLink from class org.geoserver.wms.web.data.AbstractStylePage to protected copyLink() : AjaxSubmitLink from class org.geoserver.wms.web.data.StyleAdminPanel | From | To | |
Move Method package generateLink() : AjaxSubmitLink from class org.geoserver.wms.web.data.AbstractStylePage to protected generateLink() : AjaxSubmitLink from class org.geoserver.wms.web.data.StyleAdminPanel | From | To | |
Rename Variable | 2 | ||
Rename Variable modelObject : String to format : String in method package styleHandler() : StyleHandler in class org.geoserver.wms.web.data.AbstractStylePage | From | To | |
Rename Variable url : String to legend : LegendInfo in method public ExternalGraphicPanel(id String, styleModel CompoundPropertyModel<StyleInfo>, styleForm Form<?>) in class org.geoserver.wms.web.data.ExternalGraphicPanel | From | To | |
Inline Method | 2 | ||
Inline Method package previewLink() : Component inlined to protected initUI(style StyleInfo) : void in class org.geoserver.wms.web.data.AbstractStylePage | From | To | |
Change Return Type | 4 | ||
Change Return Type Object to List<String> in method protected load() : List<String> in class org.geoserver.wms.web.data.StyleFormatsModel | From | To | |
Change Return Type Object to List<StyleType> in method protected load() : List<StyleType> in class org.geoserver.wms.web.publish.StyleTypeModel | From | To | |
Change Return Type Object to List<StyleInfo> in method protected load() : List<StyleInfo> in class org.geoserver.wms.web.publish.StylesModel | From | To | |
Change Return Type IModel to IModel<StyleInfo> in method public newModel(object StyleInfo) : IModel<StyleInfo> in class org.geoserver.wms.web.data.StyleProvider | From | To | |
Move Attribute | 8 | ||
Move Attribute protected fileUploadField : FileUploadField from class org.geoserver.wms.web.data.AbstractStylePage to protected fileUploadField : FileUploadField from class org.geoserver.wms.web.data.StyleAdminPanel | From | To | |
Move Attribute package formatChoice : DropDownChoice<String> from class org.geoserver.wms.web.data.AbstractStylePage to protected formatChoice : DropDownChoice<String> from class org.geoserver.wms.web.data.StyleAdminPanel | From | To | |
Move Attribute private wsChoice : DropDownChoice<WorkspaceInfo> from class org.geoserver.wms.web.data.AbstractStylePage to protected wsChoice : DropDownChoice<WorkspaceInfo> from class org.geoserver.wms.web.data.StyleAdminPanel | From | To | |
Move Attribute protected copyLink : AjaxSubmitLink from class org.geoserver.wms.web.data.AbstractStylePage to protected copyLink : AjaxSubmitLink from class org.geoserver.wms.web.data.StyleAdminPanel | From | To | |
Move Attribute protected generateLink : AjaxSubmitLink from class org.geoserver.wms.web.data.AbstractStylePage to protected generateLink : AjaxSubmitLink from class org.geoserver.wms.web.data.StyleAdminPanel | From | To | |
Move Attribute private legendContainer : WebMarkupContainer from class org.geoserver.wms.web.data.AbstractStylePage to protected legendContainer : WebMarkupContainer from class org.geoserver.wms.web.data.StyleAdminPanel | From | To | |
Move Attribute private legendImg : Image from class org.geoserver.wms.web.data.AbstractStylePage to protected legendImg : Image from class org.geoserver.wms.web.data.StyleAdminPanel | From | To | |
Move Attribute protected formatReadOnlyMessage : MarkupContainer from class org.geoserver.wms.web.data.AbstractStylePage to protected formatReadOnlyMessage : MarkupContainer from class org.geoserver.wms.web.data.StyleAdminPanel | From | To | |
Extract Class | 1 | ||
Extract Class org.geoserver.wms.web.data.StyleAdminPanel from class org.geoserver.wms.web.data.AbstractStylePage | From | To | |
Rename Attribute | 1 | ||
Rename Attribute copyLink : AjaxSubmitLink to popup : ModalWindow in class org.geoserver.wms.web.data.AbstractStylePage | From | To | |
Change Variable Type | 5 | ||
Change Variable Type url : String to legend : LegendInfo in method public ExternalGraphicPanel(id String, styleModel CompoundPropertyModel<StyleInfo>, styleForm Form<?>) in class org.geoserver.wms.web.data.ExternalGraphicPanel | From | To | |
Change Variable Type wsNameModel : IModel to wsNameModel : IModel<?> in method package workspaceLink(id String, model IModel<StyleInfo>) : Component in class org.geoserver.wms.web.data.StylePage | From | To | |
Change Variable Type nameModel : IModel to nameModel : IModel<?> in method package styleLink(id String, model IModel<StyleInfo>) : Component in class org.geoserver.wms.web.data.StylePage | From | To | |
Change Variable Type wsModel : IModel to wsModel : IModel<?> in method package styleLink(id String, model IModel<StyleInfo>) : Component in class org.geoserver.wms.web.data.StylePage | From | To | |
Change Variable Type cancelLink : Link to cancelLink : Link<StylePage> in method protected initUI(style StyleInfo) : void in class org.geoserver.wms.web.data.AbstractStylePage | From | To | |
Extract Method | 4 | ||
Extract Method protected getExternalGraphic(target AjaxRequestTarget, form Form<?>) : URLConnection extracted from public ExternalGraphicPanel(id String, styleModel CompoundPropertyModel<StyleInfo>, styleForm Form) in class org.geoserver.wms.web.data.ExternalGraphicPanel | From | To | |
Extract Method protected getOnlineResource() : String extracted from public ExternalGraphicPanel(id String, styleModel CompoundPropertyModel<StyleInfo>, styleForm Form) in class org.geoserver.wms.web.data.ExternalGraphicPanel | From | To | |
Extract Method protected getCatalog() : Catalog extracted from protected initUI(style StyleInfo) : void in class org.geoserver.wms.web.data.AbstractStylePage | From | To | |
Extract Method protected getGeoServerApplication() : GeoServerApplication extracted from protected initUI(style StyleInfo) : void in class org.geoserver.wms.web.data.AbstractStylePage | From | To | |
Change Attribute Type | 6 | ||
Change Attribute Type copyLink : AjaxSubmitLink to popup : ModalWindow in class org.geoserver.wms.web.data.AbstractStylePage | From | To | |
Change Attribute Type PROPERTIES : List to PROPERTIES : List<Property<StyleInfo>> in class org.geoserver.wms.web.data.StyleProvider | From | To | |
Change Attribute Type showhideForm : Form to showhideForm : Form<StyleInfo> in class org.geoserver.wms.web.data.ExternalGraphicPanel | From | To | |
Change Attribute Type height : TextField<String> to height : TextField<Integer> in class org.geoserver.wms.web.data.ExternalGraphicPanel | From | To | |
Change Attribute Type styleForm : Form to styleForm : Form<StyleInfo> in class org.geoserver.wms.web.data.AbstractStylePage | From | To | |
Change Attribute Type width : TextField<String> to width : TextField<Integer> in class org.geoserver.wms.web.data.ExternalGraphicPanel | From | To |