74f5e89bbba0a092d2c3d151830d2d682a7e1c12
Files Diff
- Added: 5
- Removed: 2
- Renamed: 0
- Modified: 38
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 3 | ||
| Change Parameter Type outputDirectory : File to outputDirectory : Resource in method private copyFile(inputDirectory Resource, inputFileName String, outputDirectory Resource, outputFileName String) : void in class org.geoserver.backuprestore.ExtraFileHandler | From | To | |
| Change Parameter Type filter : Filter to wsFilter : String in method public setWsFilter(wsFilter String) : void in class org.geoserver.backuprestore.AbstractExecutionAdapter | From | To | |
| Change Parameter Type inputDirectory : File to inputDirectory : Resource in method private copyFile(inputDirectory Resource, inputFileName String, outputDirectory Resource, outputFileName String) : void in class org.geoserver.backuprestore.ExtraFileHandler | From | To | |
| Change Variable Type | 4 | ||
| Change Variable Type outputFile : File to outputFile : Resource in method private copyFile(inputDirectory Resource, inputFileName String, outputDirectory Resource, outputFileName String) : void in class org.geoserver.backuprestore.ExtraFileHandler | From | To | |
| Change Variable Type inputDirectory : File to inputDirectory : Resource in method public handle(contribution StepContribution, chunkContext ChunkContext, jobExecution JobExecution, context BackupRestoreItem) : RepeatStatus in class org.geoserver.backuprestore.ExtraFileHandler | From | To | |
| Change Variable Type inputFile : File to inputFile : Resource in method private copyFile(inputDirectory Resource, inputFileName String, outputDirectory Resource, outputFileName String) : void in class org.geoserver.backuprestore.ExtraFileHandler | From | To | |
| Change Variable Type outputDirectory : File to outputDirectory : Resource in method public handle(contribution StepContribution, chunkContext ChunkContext, jobExecution JobExecution, context BackupRestoreItem) : RepeatStatus in class org.geoserver.backuprestore.ExtraFileHandler | From | To | |
| Extract Variable | 5 | ||
| Extract Variable wsInfo : WorkspaceInfo in method public write(items List<? extends T>) : void from class org.geoserver.backuprestore.writer.CatalogItemWriter | From | To | |
| Extract Variable geoserver : GeoServer in method package doExecute(contribution StepContribution, chunkContext ChunkContext, jobExecution JobExecution) : RepeatStatus from class org.geoserver.backuprestore.tasklet.FinalizeRestoreTasklet | From | To | |
| Extract Variable dsInfo : DataStoreInfo in method public write(items List<? extends T>) : void from class org.geoserver.backuprestore.writer.CatalogItemWriter | From | To | |
| Extract Variable resourceInfo : ResourceInfo in method public write(items List<? extends T>) : void from class org.geoserver.backuprestore.writer.CatalogItemWriter | From | To | |
| Extract Variable layerGroupInfo : LayerGroupInfo in method public write(items List<? extends T>) : void from class org.geoserver.backuprestore.writer.CatalogItemWriter | From | To | |
| Rename Method | 2 | ||
| Rename Method public setFilter(filter Filter) : void renamed to public setWsFilter(wsFilter String) : void in class org.geoserver.backuprestore.AbstractExecutionAdapter | From | To | |
| Rename Method public getFilter() : Filter renamed to public getFilters() : Filter[] in class org.geoserver.backuprestore.BackupRestoreItem | From | To | |
| Push Down Method | 4 | ||
| Push Down Method public setupBackupField() : void from class org.geoserver.backuprestore.BackupRestoreTestSupport to public beforeTest() : void from class org.geoserver.backuprestore.BackupWithoutSettingsTest | From | To | |
| Push Down Method public setupBackupField() : void from class org.geoserver.backuprestore.BackupRestoreTestSupport to public beforeTest() : void from class org.geoserver.backuprestore.RestoreWithoutSettingsTest | From | To | |
| Push Down Method public setupBackupField() : void from class org.geoserver.backuprestore.BackupRestoreTestSupport to public beforeTest() : void from class org.geoserver.backuprestore.ParameterizedBackupTest | From | To | |
| Push Down Method public setupBackupField() : void from class org.geoserver.backuprestore.BackupRestoreTestSupport to public beforeTest() : void from class org.geoserver.backuprestore.ResourceWriterTest | From | To | |
| Pull Up Method | 1 | ||
| Pull Up Method private filteredWorkspace(ws WorkspaceInfo) : boolean from class org.geoserver.backuprestore.tasklet.CatalogBackupRestoreTasklet to public filterIsValid() : boolean from class org.geoserver.backuprestore.BackupRestoreItem | From | To | |
| Rename Variable | 2 | ||
| Rename Variable filter : Filter to wsFilter : Filter in method private launchRestoreExecution(form Form<?>) : Long in class org.geoserver.backuprestore.web.BackupRestoreDataPage.populateRestoreForm.add | From | To | |
| Rename Variable filter : Filter to wsFilter : Filter in method private launchBackupExecution(form Form<?>) : Long in class org.geoserver.backuprestore.web.BackupRestoreDataPage.populateBackupForm.add | From | To | |
| Change Return Type | 3 | ||
| Change Return Type File to Resource in method public getInputDirectory(jobExecution JobExecution) : Resource in class org.geoserver.backuprestore.tasklet.GenericTaskletUtils | From | To | |
| Change Return Type Filter to Filter[] in method public getFilters() : Filter[] in class org.geoserver.backuprestore.BackupRestoreItem | From | To | |
| Change Return Type File to Resource in method public getOutputDirectory(jobExecution JobExecution) : Resource in class org.geoserver.backuprestore.tasklet.GenericTaskletUtils | From | To | |
| Replace Variable With Attribute | 2 | ||
| Replace Variable With Attribute cat : Catalog to catalog : Catalog in method public testStyleInfoAdditionalResourceWriter() : void in class org.geoserver.backuprestore.ResourceWriterTest | From | To | |
| Replace Variable With Attribute cat : Catalog to catalog : Catalog in method protected setUpInternal(data SystemTestData) : void in class org.geoserver.backuprestore.BackupRestoreTestSupport | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute filter : Filter to filters : Filter[] in class org.geoserver.backuprestore.BackupRestoreItem | From | To | |
| Rename Attribute filter : Filter to wsFilter : String in class org.geoserver.backuprestore.AbstractExecutionAdapter | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type filter : Filter to wsFilter : String in class org.geoserver.backuprestore.AbstractExecutionAdapter | From | To | |
| Change Attribute Type filter : Filter to filters : Filter[] in class org.geoserver.backuprestore.BackupRestoreItem | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method protected filteredResource(ws WorkspaceInfo, strict boolean) : boolean extracted from public process(resource T) : T in class org.geoserver.backuprestore.processor.CatalogItemProcessor & moved to class org.geoserver.backuprestore.BackupRestoreItem | From | To | |
| Extract And Move Method protected filteredResource(ws WorkspaceInfo, strict boolean) : boolean extracted from private backupGWCSettings(targetBackupFolder Resource) : void in class org.geoserver.backuprestore.tasklet.CatalogBackupRestoreTasklet & moved to class org.geoserver.backuprestore.BackupRestoreItem | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter filter : Filter to wsFilter : Filter in method private runRestoreAsync(archiveFile Resource, wsFilter Filter, siFilter Filter, liFilter Filter, paramsBuilder JobParametersBuilder) : RestoreExecutionAdapter in class org.geoserver.backuprestore.Backup | From | To | |
| Rename Parameter filter : Filter to wsFilter : String in method public setWsFilter(wsFilter String) : void in class org.geoserver.backuprestore.AbstractExecutionAdapter | From | To | |
| Rename Parameter filter : Filter to wsFilter : Filter in method private runBackupAsync(archiveFile Resource, overwrite boolean, wsFilter Filter, siFilter Filter, liFilter Filter, paramsBuilder JobParametersBuilder) : BackupExecutionAdapter in class org.geoserver.backuprestore.Backup | From | To |