86c1eeb308836b9ced72d5f0a9a46a84f8f77ff4
Files Diff
- Added: 7
- Removed: 0
- Renamed: 0
- Modified: 17
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 3 | ||
| Rename Method public getCollectionDatabaseIdentifiers(filter Filter) : List<String> renamed to public getMainTypeDatabaseIdentifiers(filter Filter) : List<String> in class org.geoserver.opensearch.eo.store.AbstractMappingStore | From | To | |
| Rename Method public getCollectionMetadata(collection String, product String, response HttpServletResponse) : void renamed to public getProductMetadata(collection String, product String, response HttpServletResponse) : void in class org.geoserver.opensearch.rest.ProductsController | From | To | |
| Rename Method public testGetCollectionDescription() : void renamed to public testGetProductDescription() : void in class org.geoserver.opensearch.rest.ProductsControllerTest | From | To | |
| Pull Up Method | 5 | ||
| Pull Up Method private simpleToComplex(feature SimpleFeature) : Feature from class org.geoserver.opensearch.rest.CollectionsController to protected simpleToComplex(feature SimpleFeature, targetSch FeatureType, ignoredAttributes Collection<String>) : Feature from class org.geoserver.opensearch.rest.AbstractOpenSearchController | From | To | |
| Pull Up Method private toName(sourceName String, defaultNamespace String) : Name from class org.geoserver.opensearch.rest.CollectionsController to protected toName(sourceName String, defaultNamespace String) : Name from class org.geoserver.opensearch.rest.AbstractOpenSearchController | From | To | |
| Pull Up Method private buildOgcLinksType() : SimpleFeatureType from class org.geoserver.opensearch.rest.CollectionsController to protected buildOgcLinksType() : SimpleFeatureType from class org.geoserver.opensearch.rest.AbstractOpenSearchController | From | To | |
| Pull Up Method private singleton(f Feature) : FeatureCollection from class org.geoserver.opensearch.rest.CollectionsController to protected singleton(f Feature) : FeatureCollection from class org.geoserver.opensearch.rest.AbstractOpenSearchController | From | To | |
| Pull Up Method package getTestData(location String) : byte[] from class org.geoserver.opensearch.rest.CollectionsControllerTest to protected getTestData(location String) : byte[] from class org.geoserver.opensearch.rest.OSEORestTestSupport | From | To | |
| Rename Variable | 1 | ||
| Rename Variable mappedLinks : ListFeatureCollection to collection : SimpleFeatureCollection in method private modifySecondaryTable(mainTypeFilter Filter, value Object, tableName String, secondaryTableFilterSupplier Function<String,Filter>, featureBuilder IOBiFunction<String,SimpleFeatureStore,SimpleFeatureCollection>) : void in class org.geoserver.opensearch.eo.store.AbstractMappingStore | From | To | |
| Pull Up Attribute | 2 | ||
| Pull Up Attribute package FF : FilterFactory2 from class org.geoserver.opensearch.rest.CollectionsControllerTest to protected FF : FilterFactory2 from class org.geoserver.opensearch.rest.OSEORestTestSupport | From | To | |
| Pull Up Attribute package FEATURE_FACTORY : FeatureFactory from class org.geoserver.opensearch.rest.CollectionsController to package FEATURE_FACTORY : FeatureFactory from class org.geoserver.opensearch.rest.AbstractOpenSearchController | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable mappedFilter : Filter to mainTypeFilter : Filter in method private modifySecondaryTable(mainTypeFilter Filter, value Object, tableName String, secondaryTableFilterSupplier Function<String,Filter>, featureBuilder IOBiFunction<String,SimpleFeatureStore,SimpleFeatureCollection>) : void in class org.geoserver.opensearch.eo.store.AbstractMappingStore | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type mappedLinks : ListFeatureCollection to collection : SimpleFeatureCollection in method private modifySecondaryTable(mainTypeFilter Filter, value Object, tableName String, secondaryTableFilterSupplier Function<String,Filter>, featureBuilder IOBiFunction<String,SimpleFeatureStore,SimpleFeatureCollection>) : void in class org.geoserver.opensearch.eo.store.AbstractMappingStore | From | To | |
| Extract Method | 3 | ||
| Extract Method protected removeChildFeatures(collectionIdentifiers List<String>) : void extracted from public removeFeatures(filter Filter) : void in class org.geoserver.opensearch.eo.store.AbstractMappingStore | From | To | |
| Extract Method private getProductFilter(collection String, product String) : And extracted from private queryProduct(collection String, product String, queryDecorator Consumer<Query>) : Feature in class org.geoserver.opensearch.rest.ProductsController | From | To | |
| Extract Method private modifySecondaryTable(mainTypeFilter Filter, value Object, tableName String, secondaryTableFilterSupplier Function<String,Filter>, featureBuilder IOBiFunction<String,SimpleFeatureStore,SimpleFeatureCollection>) : void extracted from public modifyFeatures(attributeNames Name[], attributeValues Object[], filter Filter) : void in class org.geoserver.opensearch.eo.store.AbstractMappingStore | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method protected beansToLinksCollection(links OgcLinks) : ListFeatureCollection extracted from public putCollectionOgcLinks(request HttpServletRequest, collection String, links OgcLinks) : void in class org.geoserver.opensearch.rest.CollectionsController & moved to class org.geoserver.opensearch.rest.AbstractOpenSearchController | From | To | |
| Extract And Move Method protected runTransactionOnStore(store FeatureStore, featureStoreConsumer IOConsumer<FeatureStore>) : void extracted from private runTransactionOnCollectionStore(featureStoreConsumer IOConsumer<FeatureStore>) : void in class org.geoserver.opensearch.rest.CollectionsController & moved to class org.geoserver.opensearch.rest.AbstractOpenSearchController | From | To |