8c857b51a28d69540538469e8c81ecbf0063efe5
Files Diff
- Added: 4
- Removed: 0
- Renamed: 0
- Modified: 28
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method protected buildLayerGroup(name String, type LayerGroupInfo.Mode, rootLayer LayerInfo, style StyleInfo, ws WorkspaceInfo, contents PublishedInfo...) : LayerGroupInfo renamed to protected buildEOLayerGroup(name String, rootLayer LayerInfo, style StyleInfo, ws WorkspaceInfo, contents PublishedInfo...) : LayerGroupInfo in class org.geoserver.security.impl.AbstractAuthorizationTest | From | To | |
| Move Method | 2 | ||
| Move Method private clearGroupInfo(lg LayerGroupInfo) : void from class org.geoserver.security.impl.DefaultResourceAccessManager.CatalogChangeListener to private clearGroupInfo(lg LayerGroupInfo) : void from class org.geoserver.security.impl.LayerGroupContainmentCache | From | To | |
| Move Method private addGroupInfo(lg LayerGroupInfo) : void from class org.geoserver.security.impl.DefaultResourceAccessManager.CatalogChangeListener to private addGroupInfo(lg LayerGroupInfo) : void from class org.geoserver.security.impl.LayerGroupContainmentCache | From | To | |
| Rename Variable | 3 | ||
| Rename Variable catalogNodeAllowsAccess : boolean to rulesAllowAccess : boolean in method public canAccess(user Authentication, resource ResourceInfo, mode AccessMode, directAccess boolean) : boolean in class org.geoserver.security.impl.DefaultResourceAccessManager | From | To | |
| Rename Variable catalogNode : SecureTreeNode to securityNode : SecureTreeNode in method public canAccess(user Authentication, resource ResourceInfo, mode AccessMode, directAccess boolean) : boolean in class org.geoserver.security.impl.DefaultResourceAccessManager | From | To | |
| Rename Variable nodes : List<SecureTreeNode> to containers : Collection<LayerGroupSummary> in method public canAccess(user Authentication, resource ResourceInfo, mode AccessMode, directAccess boolean) : boolean in class org.geoserver.security.impl.DefaultResourceAccessManager | From | To | |
| Pull Up Attribute | 2 | ||
| Pull Up Attribute package CONTAINER_GROUP : String from class org.geoserver.wms.wms_1_3.CapabilitiesIntegrationTest to protected CONTAINER_GROUP : String from class org.geoserver.wms.WMSTestSupport | From | To | |
| Pull Up Attribute package CONTAINER_GROUP : String from class org.geoserver.wms.wms_1_1_1.CapabilitiesTest to protected CONTAINER_GROUP : String from class org.geoserver.wms.WMSTestSupport | From | To | |
| Extract Class | 1 | ||
| Extract Class org.geoserver.security.impl.LayerGroupContainmentCache from class org.geoserver.security.impl.DefaultResourceAccessManager.CatalogChangeListener | From | To | |
| Move Class | 1 | ||
| Move Class org.geoserver.security.impl.DefaultResourceAccessManager.CatalogChangeListener moved to org.geoserver.security.impl.LayerGroupContainmentCache.CatalogChangeListener | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type nodes : List<SecureTreeNode> to containers : Collection<LayerGroupSummary> in method public canAccess(user Authentication, resource ResourceInfo, mode AccessMode, directAccess boolean) : boolean in class org.geoserver.security.impl.DefaultResourceAccessManager | From | To | |
| Extract Method | 6 | ||
| Extract Method public canAccess(user Authentication, layer LayerInfo, mode AccessMode, directAccess boolean) : boolean extracted from public canAccess(user Authentication, resource ResourceInfo, mode AccessMode) : boolean in class org.geoserver.security.impl.DefaultResourceAccessManager | From | To | |
| Extract Method package buildWrapperPolicy(accessManager ResourceAccessManager, user Authentication, info CatalogInfo, resourceName String, mixedModeBehavior MixedModeBehavior, containers List<LayerGroupInfo>) : WrapperPolicy extracted from package buildWrapperPolicy(accessManager ResourceAccessManager, user Authentication, info CatalogInfo, resourceName String, mixedModeBehavior MixedModeBehavior) : WrapperPolicy in class org.geoserver.security.SecureCatalogImpl | From | To | |
| Extract Method public canAccess(user Authentication, layer LayerInfo, mode AccessMode, directAccess boolean) : boolean extracted from public canAccess(user Authentication, layer LayerInfo, mode AccessMode) : boolean in class org.geoserver.security.impl.DefaultResourceAccessManager | From | To | |
| Extract Method private testSerializationWithMode(mode Mode) : void extracted from public testLayerGroupInfo() : void in class org.geoserver.config.util.XStreamPersisterTest | From | To | |
| Extract Method public canAccess(user Authentication, resource ResourceInfo, mode AccessMode, directAccess boolean) : boolean extracted from public canAccess(user Authentication, resource ResourceInfo, mode AccessMode) : boolean in class org.geoserver.security.impl.DefaultResourceAccessManager | From | To | |
| Extract Method public getAccessLimits(user Authentication, layer LayerInfo, context List<LayerGroupInfo>) : DataAccessLimits extracted from public getAccessLimits(user Authentication, layer LayerInfo) : DataAccessLimits in class org.geoserver.security.impl.DefaultResourceAccessManager | From | To | |
| Extract And Move Method | 5 | ||
| Extract And Move Method protected getRawTopLayerCount() : int extracted from public testLayerCount() : void in class org.geoserver.wms.wms_1_1_1.CapabilitiesTest & moved to class org.geoserver.wms.WMSTestSupport | From | To | |
| Extract And Move Method protected setupOpaqueGroup(catalog Catalog) : void extracted from protected onSetUp(testData SystemTestData) : void in class org.geoserver.wms.wms_1_3.CapabilitiesIntegrationTest & moved to class org.geoserver.wms.WMSTestSupport | From | To | |
| Extract And Move Method protected getRawTopLayerCount() : int extracted from public testLayerCount() : void in class org.geoserver.wms.wms_1_3.CapabilitiesIntegrationTest & moved to class org.geoserver.wms.WMSTestSupport | From | To | |
| Extract And Move Method public getAccessLimits(user Authentication, layerGroup LayerGroupInfo, containers List<LayerGroupInfo>) : LayerGroupAccessLimits extracted from public getAccessLimits(user Authentication, layerGroup LayerGroupInfo) : LayerGroupAccessLimits in class org.geoserver.security.impl.DefaultResourceAccessManager & moved to class org.geoserver.security.CatalogFilterAccessManager | From | To | |
| Extract And Move Method protected setupOpaqueGroup(catalog Catalog) : void extracted from protected onSetUp(testData SystemTestData) : void in class org.geoserver.wms.wms_1_1_1.CapabilitiesTest & moved to class org.geoserver.wms.WMSTestSupport | From | To |