c6ec068909cb552333d2a5ae0ea314ca37218b7b
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 22
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 2 | ||
| Change Parameter Type ctx : DirContext to ctxConsumer : Consumer<Consumer<DirContext>> in method public getGroupMembershipRoles(ctxConsumer Consumer<Consumer<DirContext>>, userDn String, username String) : Set<GrantedAuthority> in class org.geoserver.security.ldap.BindingLdapAuthoritiesPopulator | From | To | |
| Change Parameter Type ctx : DirContext to ctxConsumer : Consumer<Consumer<DirContext>> in method private getAllRoles(user DirContextOperations, userDn String, result List<GrantedAuthority>, userName String, ctxConsumer Consumer<Consumer<DirContext>>) : void in class org.geoserver.security.ldap.BindingLdapAuthoritiesPopulator | From | To | |
| Rename Variable | 1 | ||
| Rename Variable userRoles : Set<String> to userRolesNameDn : List<Pair<String,String>> in method public getGroupMembershipRoles(ctxConsumer Consumer<Consumer<DirContext>>, userDn String, username String) : Set<GrantedAuthority> in class org.geoserver.security.ldap.BindingLdapAuthoritiesPopulator | From | To | |
| Extract Variable | 3 | ||
| Extract Variable userByUsername : GeoServerUser in method public executeWithContext(ctx DirContext, ldapEntryIdentification LdapEntryIdentification) : void from class org.geoserver.security.ldap.LDAPUserGroupService.addUsersFromGroup.authenticateIfNeeded | From | To | |
| Extract Variable userDn : String in method public getRolesForUser(username String) : SortedSet<GeoServerRole> from class org.geoserver.security.ldap.LDAPRoleService | From | To | |
| Extract Variable attribute : Object in method public executeWithContext(ctx DirContext, ldapEntryIdentification LdapEntryIdentification) : void from class org.geoserver.security.ldap.LDAPBaseSecurityService.getUserNameFromMembership.authenticateIfNeeded | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type userRoles : Set<String> to userRolesNameDn : List<Pair<String,String>> in method public getGroupMembershipRoles(ctxConsumer Consumer<Consumer<DirContext>>, userDn String, username String) : Set<GrantedAuthority> in class org.geoserver.security.ldap.BindingLdapAuthoritiesPopulator | From | To | |
| Extract Method | 2 | ||
| Extract Method private addUsersFromGroup(group GeoServerUserGroup, users Set<GeoServerUser>) : void extracted from public getUsersForGroup(group GeoServerUserGroup) : SortedSet<GeoServerUser> in class org.geoserver.security.ldap.LDAPUserGroupService | From | To | |
| Extract Method private normalizeGroupName(role String) : String extracted from private fillUsersForRole(ctx DirContext, users SortedSet<String>, role GeoServerRole) : void in class org.geoserver.security.ldap.LDAPRoleService | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter ctx : DirContext to ctxConsumer : Consumer<Consumer<DirContext>> in method public getGroupMembershipRoles(ctxConsumer Consumer<Consumer<DirContext>>, userDn String, username String) : Set<GrantedAuthority> in class org.geoserver.security.ldap.BindingLdapAuthoritiesPopulator | From | To | |
| Rename Parameter ctx : DirContext to ctxConsumer : Consumer<Consumer<DirContext>> in method private getAllRoles(user DirContextOperations, userDn String, result List<GrantedAuthority>, userName String, ctxConsumer Consumer<Consumer<DirContext>>) : void in class org.geoserver.security.ldap.BindingLdapAuthoritiesPopulator | From | To |