03ade425dd5a65d3a713d5e7d85aa7605956fbd2
Files Diff
- Added: 9
- Removed: 1
- Renamed: 0
- Modified: 23
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Change Parameter Type | 7 | ||
Change Parameter Type partitionId : int to partitionId : Integer in method public getPartitionVertexCount(partitionId Integer) : long in class org.apache.giraph.partition.SimplePartitionStore | From | To | |
Change Parameter Type partitionId : int to partitionId : Integer in method public abstract getPartitionEdgeCount(partitionId Integer) : long in class org.apache.giraph.partition.PartitionStore | From | To | |
Change Parameter Type partitionId : int to partitionId : Integer in method public abstract getPartitionVertexCount(partitionId Integer) : long in class org.apache.giraph.partition.PartitionStore | From | To | |
Change Parameter Type partitionId : int to partitionId : Integer in method public getPartitionEdgeCount(partitionId Integer) : long in class org.apache.giraph.ooc.DiskBackedPartitionStore | From | To | |
Change Parameter Type partitionId : int to partitionIds : List<Integer> in method public Worker(vertexCounter AtomicInteger, partitionStore PartitionStore<IntWritable,IntWritable,NullWritable>, partitionIds List<Integer>, conf ImmutableClassesGiraphConfiguration<IntWritable,IntWritable,NullWritable>) in class org.apache.giraph.partition.TestPartitionStores.Worker | From | To | |
Change Parameter Type partitionId : int to partitionId : Integer in method public getPartitionVertexCount(partitionId Integer) : long in class org.apache.giraph.ooc.DiskBackedPartitionStore | From | To | |
Change Parameter Type partitionId : int to partitionId : Integer in method public getPartitionEdgeCount(partitionId Integer) : long in class org.apache.giraph.partition.SimplePartitionStore | From | To | |
Inline Method | 1 | ||
Inline Method private putPartition(meta MetaPartition) : void inlined to public putPartition(partition Partition<I,V,E>) : void in class org.apache.giraph.ooc.DiskBackedPartitionStore | From | To | |
Rename Variable | 4 | ||
Rename Variable e : MetaPartition to meta : MetaPartition in method public shutdown() : void in class org.apache.giraph.ooc.DiskBackedPartitionStore | From | To | |
Rename Variable partitionId : int to partitionIds : List<Integer> in method private testMultiThreaded() : void in class org.apache.giraph.partition.TestPartitionStores | From | To | |
Rename Variable numVertices : long to partitionId : int in method private getPartition(meta MetaPartition) : void in class org.apache.giraph.ooc.DiskBackedPartitionStore | From | To | |
Rename Variable numInputThreads : int to userMaxNumPartitions : int in method public DiskBackedPartitionStore(conf ImmutableClassesGiraphConfiguration<I,V,E>, context Mapper<?,?,?,?>, serviceWorker CentralizedServiceWorker<I,V,E>) in class org.apache.giraph.ooc.DiskBackedPartitionStore | From | To | |
Change Return Type | 3 | ||
Change Return Type void to boolean in method public addPartition(partition Partition<I,V,E>) : boolean in class org.apache.giraph.ooc.DiskBackedPartitionStore | From | To | |
Change Return Type void to boolean in method public addPartition(partition Partition<I,V,E>) : boolean in class org.apache.giraph.partition.SimplePartitionStore | From | To | |
Change Return Type void to boolean in method public abstract addPartition(partition Partition<I,V,E>) : boolean in class org.apache.giraph.partition.PartitionStore | From | To | |
Move Attribute | 1 | ||
Move Attribute private edgeStore : EdgeStore<I,V,E> from class org.apache.giraph.comm.ServerData to private edgeStore : EdgeStore<I,V,E> from class org.apache.giraph.partition.SimplePartitionStore | From | To | |
Move Class | 1 | ||
Move Class org.apache.giraph.partition.DiskBackedPartitionStore moved to org.apache.giraph.ooc.DiskBackedPartitionStore | From | To | |
Rename Attribute | 3 | ||
Rename Attribute isSticky : boolean to isProcessed : boolean in class org.apache.giraph.ooc.DiskBackedPartitionStore.MetaPartition | From | To | |
Rename Attribute NUM_OF_VERTEXES_PER_THREAD : int to NUM_OF_VERTEXES_PER_PARTITION : int in class org.apache.giraph.partition.TestPartitionStores | From | To | |
Rename Attribute partitionId : int to partitionIds : List<Integer> in class org.apache.giraph.partition.TestPartitionStores.Worker | From | To | |
Change Variable Type | 3 | ||
Change Variable Type partition : Partition<LongWritable,?,?> to partition : Partition in method private populateMap() : void in class org.apache.giraph.comm.messages.primitives.long_id.LongAbstractListMessageStore | From | To | |
Change Variable Type partitionId : int to partitionIds : List<Integer> in method private testMultiThreaded() : void in class org.apache.giraph.partition.TestPartitionStores | From | To | |
Change Variable Type numVertices : long to partitionId : int in method private getPartition(meta MetaPartition) : void in class org.apache.giraph.ooc.DiskBackedPartitionStore | From | To | |
Extract Variable | 2 | ||
Extract Variable partitionId : int in method private offloadPartition(meta MetaPartition) : void from class org.apache.giraph.ooc.DiskBackedPartitionStore | From | To | |
Extract Variable vertexId : LongWritable in method private populateMap() : void from class org.apache.giraph.comm.messages.primitives.long_id.LongAbstractListMessageStore | From | To | |
Change Attribute Type | 2 | ||
Change Attribute Type partitionId : int to partitionIds : List<Integer> in class org.apache.giraph.partition.TestPartitionStores.Worker | From | To | |
Change Attribute Type maxPartitionsInMem : int to maxPartitionsInMem : AtomicInteger in class org.apache.giraph.ooc.DiskBackedPartitionStore | From | To | |
Extract And Move Method | 2 | ||
Extract And Move Method public addPartitionVertices(partitionId Integer, extendedDataOutput ExtendedDataOutput) : void extracted from public doRequest(serverData ServerData<I,V,E>) : void in class org.apache.giraph.comm.requests.SendWorkerVerticesRequest & moved to class org.apache.giraph.partition.SimplePartitionStore | From | To | |
Extract And Move Method public moveEdgesToVertices() : void extracted from public setup() : FinishedSuperstepStats in class org.apache.giraph.worker.BspServiceWorker & moved to class org.apache.giraph.partition.SimplePartitionStore | From | To | |
Rename Parameter | 2 | ||
Rename Parameter partitionId : int to partitionIds : List<Integer> in method public Worker(vertexCounter AtomicInteger, partitionStore PartitionStore<IntWritable,IntWritable,NullWritable>, partitionIds List<Integer>, conf ImmutableClassesGiraphConfiguration<IntWritable,IntWritable,NullWritable>) in class org.apache.giraph.partition.TestPartitionStores.Worker | From | To | |
Rename Parameter id : Integer to partitionId : Integer in method public removePartition(partitionId Integer) : Partition<I,V,E> in class org.apache.giraph.ooc.DiskBackedPartitionStore | From | To |