giraph 5d0b81ac42ab0de80bb68b87c7d1c1dd710f1108

5d0b81ac42ab0de80bb68b87c7d1c1dd710f1108

Files Diff

Added: 4
Removed: 4
Renamed: 0
Modified: 55

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	5
Rename Method public initialize(conf ImmutableClassesGiraphConfiguration) : void renamed to public setConf(conf ImmutableClassesGiraphConfiguration) : void in class org.apache.giraph.jython.factories.JythonFactoryBase	From	To
Rename Method public initialize(conf ImmutableClassesGiraphConfiguration) : void renamed to public setConf(conf ImmutableClassesGiraphConfiguration) : void in class org.apache.giraph.factories.DefaultEdgeValueFactory	From	To
Rename Method public initialize(conf ImmutableClassesGiraphConfiguration) : void renamed to public setConf(conf ImmutableClassesGiraphConfiguration) : void in class org.apache.giraph.factories.DefaultVertexIdFactory	From	To
Rename Method public getOutgoingMessageValueClass() : Class<? extends Writable> renamed to package getInitialOutgoingMessageValueClass() : Class<? extends Writable> in class org.apache.giraph.conf.GiraphTypes	From	To
Rename Method public initialize(conf ImmutableClassesGiraphConfiguration) : void renamed to public setConf(conf ImmutableClassesGiraphConfiguration) : void in class org.apache.giraph.factories.DefaultVertexValueFactory	From	To
Move And Rename Method	1
Move And Rename Method public hasMessageCombinerClass() : boolean from class org.apache.giraph.conf.GiraphClasses to public useMessageCombiner() : boolean from class org.apache.giraph.conf.DefaultMessageClasses	From	To
Change Parameter Type	10
Change Parameter Type messageCombiner : MessageCombiner<I,M> to messageCombiner : MessageCombiner<? super I,M> in method public IdOneMessagePerVertexStore(messageValueFactory MessageValueFactory<M>, service CentralizedServiceWorker<I,?,?>, messageCombiner MessageCombiner<? super I,M>, config ImmutableClassesGiraphConfiguration<I,?,?>) in class org.apache.giraph.comm.messages.primitives.IdOneMessagePerVertexStore	From	To
Change Parameter Type messageValueFactory : MessageValueFactory<M> to messageClasses : MessageClasses<I,M> in method public newStore(messageClasses MessageClasses<I,M>) : MessageStore<I,M> in class org.apache.giraph.comm.messages.ByteArrayMessagesPerVertexStore.Factory	From	To
Change Parameter Type messageValueFactory : MessageValueFactory<M> to messageClasses : MessageClasses<I,M> in method public newStore(messageClasses MessageClasses<I,M>) : MessageStore<I,M> in class org.apache.giraph.comm.messages.OneMessagePerVertexStore.Factory	From	To
Change Parameter Type messageValueFactory : MessageValueFactory<M> to messageClasses : MessageClasses<I,M> in method public newStore(messageClasses MessageClasses<I,M>) : SequentialFileMessageStore<I,M> in class org.apache.giraph.comm.messages.out_of_core.SequentialFileMessageStore.Factory	From	To
Change Parameter Type messageValueFactory : MessageValueFactory<M> to messageClasses : MessageClasses<I,M> in method public newStore(messageClasses MessageClasses<I,M>) : PartitionDiskBackedMessageStore<I,M> in class org.apache.giraph.comm.messages.out_of_core.PartitionDiskBackedMessageStore.Factory	From	To
Change Parameter Type messageValueFactory : MessageValueFactory<M> to messageClasses : MessageClasses<I,M> in method public DiskBackedMessageStore(messageClasses MessageClasses<I,M>, service CentralizedServiceWorker<I,V,E>, maxNumberOfMessagesInMemory int, partitionStoreFactory MessageStoreFactory<I,M,PartitionDiskBackedMessageStore<I,M>>) in class org.apache.giraph.comm.messages.out_of_core.DiskBackedMessageStore	From	To
Change Parameter Type messageValueFactory : MessageValueFactory<M> to messageClasses : MessageClasses<I,M> in method public PartitionDiskBackedMessageStore(messageClasses MessageClasses<I,M>, config ImmutableClassesGiraphConfiguration<I,?,?>, fileStoreFactory MessageStoreFactory<I,M,SequentialFileMessageStore<I,M>>) in class org.apache.giraph.comm.messages.out_of_core.PartitionDiskBackedMessageStore	From	To
Change Parameter Type messageValueFactory : MessageValueFactory<M> to messageClasses : MessageClasses<I,M> in method public newStore(messageClasses MessageClasses<I,M>) : MessageStore<I,M> in class org.apache.giraph.comm.messages.out_of_core.DiskBackedMessageStoreFactory	From	To
Change Parameter Type messageCombiner : MessageCombiner<I,M> to messageCombiner : MessageCombiner<? super I,M> in method public OneMessagePerVertexStore(messageValueFactory MessageValueFactory<M>, service CentralizedServiceWorker<I,?,?>, messageCombiner MessageCombiner<? super I,M>, config ImmutableClassesGiraphConfiguration<I,?,?>) in class org.apache.giraph.comm.messages.OneMessagePerVertexStore	From	To
Change Parameter Type messageValueFactory : MessageValueFactory<M> to messageClasses : MessageClasses<I,M> in method public newStore(messageClasses MessageClasses<I,M>) : MessageStore<I,M> in class org.apache.giraph.comm.messages.InMemoryMessageStoreFactory	From	To
Rename Variable	1
Rename Variable messageCombinerClass : Class<? extends MessageCombiner<I,M2>> to messageCombiner : MessageCombiner<I,M2> in method private verifyMessageCombinerGenericTypes() : void in class org.apache.giraph.job.GiraphConfigurationValidator	From	To
Rename Attribute	2
Rename Attribute messageValueFactory : MessageValueFactory<M> to messageClasses : MessageClasses<I,M> in class org.apache.giraph.comm.messages.out_of_core.DiskBackedMessageStore	From	To
Rename Attribute outgoingMessageClass : Class<? extends Writable> to outgoingMessageClasses : MessageClasses<? extends WritableComparable,? extends Writable> in class org.apache.giraph.master.SuperstepClasses	From	To
Change Variable Type	1
Change Variable Type messageCombinerClass : Class<? extends MessageCombiner<I,M2>> to messageCombiner : MessageCombiner<I,M2> in method private verifyMessageCombinerGenericTypes() : void in class org.apache.giraph.job.GiraphConfigurationValidator	From	To
Extract Method	2
Extract Method public getOutgoingMessageClasses() : MessageClasses<I,M> extracted from public getOutgoingMessageValueClass() : Class<M> in class org.apache.giraph.conf.ImmutableClassesGiraphConfiguration	From	To
Extract Method public getIncomingMessageClasses() : MessageClasses<I,M> extracted from public getIncomingMessageValueClass() : Class<M> in class org.apache.giraph.conf.ImmutableClassesGiraphConfiguration	From	To
Change Attribute Type	4
Change Attribute Type outgoingMessageClass : Class<? extends Writable> to outgoingMessageClasses : MessageClasses<? extends WritableComparable,? extends Writable> in class org.apache.giraph.master.SuperstepClasses	From	To
Change Attribute Type messageValueFactory : MessageValueFactory<M> to messageClasses : MessageClasses<I,M> in class org.apache.giraph.comm.messages.out_of_core.DiskBackedMessageStore	From	To
Change Attribute Type messageCombiner : MessageCombiner<I,M> to messageCombiner : MessageCombiner<? super I,M> in class org.apache.giraph.comm.messages.OneMessagePerVertexStore	From	To
Change Attribute Type messageCombiner : MessageCombiner<I,M> to messageCombiner : MessageCombiner<? super I,M> in class org.apache.giraph.comm.messages.primitives.IdOneMessagePerVertexStore	From	To
Extract And Move Method	5
Extract And Move Method public createToRead(conf ImmutableClassesGiraphConfiguration) : SuperstepClasses extracted from private prepareCheckpointRestart(superstep long) : Collection<PartitionOwner> in class org.apache.giraph.master.BspServiceMaster & moved to class org.apache.giraph.master.SuperstepClasses	From	To
Extract And Move Method public createAndExtractTypes(conf ImmutableClassesGiraphConfiguration) : SuperstepClasses extracted from private prepareMasterCompute(superstep long) : SuperstepClasses in class org.apache.giraph.master.BspServiceMaster & moved to class org.apache.giraph.master.SuperstepClasses	From	To
Extract And Move Method public createToRead(conf ImmutableClassesGiraphConfiguration) : SuperstepClasses extracted from public finishSuperstep(partitionStatsList List<PartitionStats>, superstepTimerContext GiraphTimerContext) : FinishedSuperstepStats in class org.apache.giraph.worker.BspServiceWorker & moved to class org.apache.giraph.master.SuperstepClasses	From	To
Extract And Move Method public updateGiraphClasses(classes GiraphClasses) : void extracted from public updateSuperstepClasses(superstepClasses SuperstepClasses) : void in class org.apache.giraph.conf.ImmutableClassesGiraphConfiguration & moved to class org.apache.giraph.master.SuperstepClasses	From	To
Extract And Move Method public createToRead(conf ImmutableClassesGiraphConfiguration) : SuperstepClasses extracted from public loadCheckpoint(superstep long) : VertexEdgeCount in class org.apache.giraph.worker.BspServiceWorker & moved to class org.apache.giraph.master.SuperstepClasses	From	To
Rename Parameter	8
Rename Parameter messageValueFactory : MessageValueFactory<M> to messageClasses : MessageClasses<I,M> in method public newStore(messageClasses MessageClasses<I,M>) : PartitionDiskBackedMessageStore<I,M> in class org.apache.giraph.comm.messages.out_of_core.PartitionDiskBackedMessageStore.Factory	From	To
Rename Parameter messageValueFactory : MessageValueFactory<M> to messageClasses : MessageClasses<I,M> in method public DiskBackedMessageStore(messageClasses MessageClasses<I,M>, service CentralizedServiceWorker<I,V,E>, maxNumberOfMessagesInMemory int, partitionStoreFactory MessageStoreFactory<I,M,PartitionDiskBackedMessageStore<I,M>>) in class org.apache.giraph.comm.messages.out_of_core.DiskBackedMessageStore	From	To
Rename Parameter messageValueFactory : MessageValueFactory<M> to messageClasses : MessageClasses<I,M> in method public newStore(messageClasses MessageClasses<I,M>) : MessageStore<I,M> in class org.apache.giraph.comm.messages.out_of_core.DiskBackedMessageStoreFactory	From	To
Rename Parameter messageValueFactory : MessageValueFactory<M> to messageClasses : MessageClasses<I,M> in method public PartitionDiskBackedMessageStore(messageClasses MessageClasses<I,M>, config ImmutableClassesGiraphConfiguration<I,?,?>, fileStoreFactory MessageStoreFactory<I,M,SequentialFileMessageStore<I,M>>) in class org.apache.giraph.comm.messages.out_of_core.PartitionDiskBackedMessageStore	From	To
Rename Parameter messageValueFactory : MessageValueFactory<M> to messageClasses : MessageClasses<I,M> in method public newStore(messageClasses MessageClasses<I,M>) : MessageStore<I,M> in class org.apache.giraph.comm.messages.InMemoryMessageStoreFactory	From	To
Rename Parameter messageValueFactory : MessageValueFactory<M> to messageClasses : MessageClasses<I,M> in method public newStore(messageClasses MessageClasses<I,M>) : MessageStore<I,M> in class org.apache.giraph.comm.messages.ByteArrayMessagesPerVertexStore.Factory	From	To
Rename Parameter messageValueFactory : MessageValueFactory<M> to messageClasses : MessageClasses<I,M> in method public newStore(messageClasses MessageClasses<I,M>) : MessageStore<I,M> in class org.apache.giraph.comm.messages.OneMessagePerVertexStore.Factory	From	To
Rename Parameter messageValueFactory : MessageValueFactory<M> to messageClasses : MessageClasses<I,M> in method public newStore(messageClasses MessageClasses<I,M>) : SequentialFileMessageStore<I,M> in class org.apache.giraph.comm.messages.out_of_core.SequentialFileMessageStore.Factory	From	To

5d0b81ac42ab0de80bb68b87c7d1c1dd710f1108

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: