97e26e65f0ca669926c9c8ddc05f19da76180ab5
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 7
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 1 | ||
| Change Parameter Type workerIdOutstandingRequestMap : ConcurrentMap<ClientRequestId,RequestInfo> to nettyClient : NettyClient in method public ResponseClientHandler(nettyClient NettyClient, conf Configuration) in class org.apache.giraph.comm.netty.handler.ResponseClientHandler | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute workerIdOutstandingRequestMap : ConcurrentMap<ClientRequestId,RequestInfo> to nettyClient : NettyClient in class org.apache.giraph.comm.netty.handler.ResponseClientHandler | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type response : int to response : short in method public channelRead(ctx ChannelHandlerContext, msg Object) : void in class org.apache.giraph.comm.netty.handler.ResponseClientHandler | From | To | |
| Extract Variable | 3 | ||
| Extract Variable numOpenRequests : int in method private logInfoAboutOpenRequests(maxOpenRequests int) : void from class org.apache.giraph.comm.netty.NettyClient | From | To | |
| Extract Variable requestMap : ConcurrentMap<ClientRequestId,RequestInfo> in method public sendWritableRequest(destTaskId int, request WritableRequest) : void from class org.apache.giraph.comm.netty.NettyClient | From | To | |
| Extract Variable taskId : int in method public connectAllAddresses(tasks Collection<? extends TaskInfo>) : void from class org.apache.giraph.comm.netty.NettyClient | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type workerIdOutstandingRequestMap : ConcurrentMap<ClientRequestId,RequestInfo> to nettyClient : NettyClient in class org.apache.giraph.comm.netty.handler.ResponseClientHandler | From | To | |
| Extract Method | 2 | ||
| Extract Method private doSend(destTaskId int, request WritableRequest, requestMap ConcurrentMap<ClientRequestId,RequestInfo>) : void extracted from public sendWritableRequest(destTaskId int, request WritableRequest) : void in class org.apache.giraph.comm.netty.NettyClient | From | To | |
| Extract Method private checkRequestsForProblemsInMap(requestMap ConcurrentMap<ClientRequestId,RequestInfo>) : void extracted from private checkRequestsForProblems() : void in class org.apache.giraph.comm.netty.NettyClient | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method public messageReceived(senderId int, requestId long, response short, shouldDrop boolean) : void extracted from public channelRead(ctx ChannelHandlerContext, msg Object) : void in class org.apache.giraph.comm.netty.handler.ResponseClientHandler & moved to class org.apache.giraph.comm.netty.NettyClient | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter workerIdOutstandingRequestMap : ConcurrentMap<ClientRequestId,RequestInfo> to nettyClient : NettyClient in method public ResponseClientHandler(nettyClient NettyClient, conf Configuration) in class org.apache.giraph.comm.netty.handler.ResponseClientHandler | From | To |