giraph b90b59d2b5064782c501dfca5a1497f1ef513a6a

b90b59d2b5064782c501dfca5a1497f1ef513a6a

Files Diff

Added: 6
Removed: 0
Renamed: 0
Modified: 24

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move And Rename Method	3
Move And Rename Method private processResponse(senderId int, requestId long, ignoreCredit boolean, credit short) : RequestInfo from class org.apache.giraph.comm.netty.NettyClient to public messageAckReceived(taskId int, response short) : void from class org.apache.giraph.comm.flow_control.CreditBasedFlowControl	From	To
Move And Rename Method private waitSomeRequests(aggregateRequests AtomicInteger) : void from class org.apache.giraph.comm.netty.NettyClient to public waitAllRequests() : void from class org.apache.giraph.comm.flow_control.CreditBasedFlowControl	From	To
Move And Rename Method private reserveSpotForRequest(destTaskId int, request WritableRequest) : ConcurrentMap<ClientRequestId,RequestInfo> from class org.apache.giraph.comm.netty.NettyClient to public sendRequest(destTaskId int, request WritableRequest) : void from class org.apache.giraph.comm.flow_control.CreditBasedFlowControl	From	To
Move Method	5
Move Method public getAckSignalFlag(response short) : AckSignalFlag from class org.apache.giraph.comm.netty.NettyClient to public getAckSignalFlag(response short) : AckSignalFlag from class org.apache.giraph.comm.flow_control.CreditBasedFlowControl	From	To
Move Method private waitSomeRequests(maxOpenRequests int) : void from class org.apache.giraph.comm.netty.NettyClient to private waitSomeRequests() : void from class org.apache.giraph.comm.flow_control.StaticFlowControl	From	To
Move Method public getCredit(response short) : short from class org.apache.giraph.comm.netty.NettyClient to private getCredit(response short) : short from class org.apache.giraph.comm.flow_control.CreditBasedFlowControl	From	To
Move Method public shouldIgnoreCredit(response short) : boolean from class org.apache.giraph.comm.netty.NettyClient to private shouldIgnoreCredit(response short) : boolean from class org.apache.giraph.comm.flow_control.CreditBasedFlowControl	From	To
Move Method public newSuperstep(metrics SuperstepMetricsRegistry) : void from class org.apache.giraph.comm.netty.NettyClient to public newSuperstep(metrics SuperstepMetricsRegistry) : void from class org.apache.giraph.comm.flow_control.StaticFlowControl	From	To
Move Attribute	13
Move Attribute private unsentWaitMsecs : int from class org.apache.giraph.comm.netty.NettyClient to private unsentWaitMsecs : int from class org.apache.giraph.comm.flow_control.CreditBasedFlowControl	From	To
Move Attribute private perWorkerUnsentRequestMap : ConcurrentMap<Integer,Deque<WritableRequest>> from class org.apache.giraph.comm.netty.NettyClient to private perWorkerUnsentRequestMap : ConcurrentMap<Integer,Deque<WritableRequest>> from class org.apache.giraph.comm.flow_control.CreditBasedFlowControl	From	To
Move Attribute private unsentRequestPermit : Semaphore from class org.apache.giraph.comm.netty.NettyClient to private unsentRequestPermit : Semaphore from class org.apache.giraph.comm.flow_control.CreditBasedFlowControl	From	To
Move Attribute private aggregateUnsentRequests : AtomicInteger from class org.apache.giraph.comm.netty.NettyClient to private aggregateUnsentRequests : AtomicInteger from class org.apache.giraph.comm.flow_control.CreditBasedFlowControl	From	To
Move Attribute public MAX_NUMBER_OF_OPEN_REQUESTS : IntConfOption from class org.apache.giraph.comm.netty.NettyClient to public MAX_NUMBER_OF_OPEN_REQUESTS : IntConfOption from class org.apache.giraph.comm.flow_control.StaticFlowControl	From	To
Move Attribute public MAX_NUM_OF_OPEN_REQUESTS_PER_WORKER : IntConfOption from class org.apache.giraph.comm.netty.NettyClient to public MAX_NUM_OF_OPEN_REQUESTS_PER_WORKER : IntConfOption from class org.apache.giraph.comm.flow_control.CreditBasedFlowControl	From	To
Move Attribute public UNSENT_CACHE_WAIT_INTERVAL : IntConfOption from class org.apache.giraph.comm.netty.NettyClient to public UNSENT_CACHE_WAIT_INTERVAL : IntConfOption from class org.apache.giraph.comm.flow_control.CreditBasedFlowControl	From	To
Move Attribute public FRACTION_OF_REQUESTS_TO_CLOSE_BEFORE_PROCEEDING : FloatConfOption from class org.apache.giraph.comm.netty.NettyClient to public FRACTION_OF_REQUESTS_TO_CLOSE_BEFORE_PROCEEDING : FloatConfOption from class org.apache.giraph.comm.flow_control.StaticFlowControl	From	To
Move Attribute private maxNumberOfOpenRequests : int from class org.apache.giraph.comm.netty.NettyClient to private maxNumberOfOpenRequests : int from class org.apache.giraph.comm.flow_control.StaticFlowControl	From	To
Move Attribute public MAX_NUM_OF_UNSENT_REQUESTS : IntConfOption from class org.apache.giraph.comm.netty.NettyClient to public MAX_NUM_OF_UNSENT_REQUESTS : IntConfOption from class org.apache.giraph.comm.flow_control.CreditBasedFlowControl	From	To
Move Attribute private numberOfRequestsToProceed : int from class org.apache.giraph.comm.netty.NettyClient to private numberOfRequestsToProceed : int from class org.apache.giraph.comm.flow_control.StaticFlowControl	From	To
Move Attribute private timeWaitingOnOpenRequests : Counter from class org.apache.giraph.comm.netty.NettyClient to private timeWaitingOnOpenRequests : Counter from class org.apache.giraph.comm.flow_control.StaticFlowControl	From	To
Move Attribute private maxOpenRequestsPerWorker : int from class org.apache.giraph.comm.netty.NettyClient to private maxOpenRequestsPerWorker : int from class org.apache.giraph.comm.flow_control.CreditBasedFlowControl	From	To
Extract Class	2
Extract Class org.apache.giraph.comm.flow_control.StaticFlowControl from class org.apache.giraph.comm.netty.NettyClient	From	To
Extract Class org.apache.giraph.comm.flow_control.CreditBasedFlowControl from class org.apache.giraph.comm.netty.NettyClient	From	To
Extract Attribute	1
Extract Attribute public MASTER_TASK_ID : int in class org.apache.giraph.master.MasterInfo	From	To
Move Class	1
Move Class org.apache.giraph.comm.netty.NettyClient.AdjustableSemaphore moved to org.apache.giraph.utils.AdjustableSemaphore	From	To
Change Variable Type	1
Change Variable Type pair : Pair<AdjustableSemaphore,ConcurrentMap<ClientRequestId,RequestInfo>> to entry : Map.Entry<ClientRequestId,RequestInfo> in method private checkRequestsForProblems() : void in class org.apache.giraph.comm.netty.NettyClient	From	To
Inline Variable	2
Inline Variable numOpenRequests : int in method private logInfoAboutOpenRequests(maxOpenRequests int) : void from class org.apache.giraph.comm.netty.NettyClient	From	To
Inline Variable numOpenRequests : int in method public messageReceived(senderId int, requestId long, response short, shouldDrop boolean) : void from class org.apache.giraph.comm.netty.NettyClient	From	To
Rename Method	1
Rename Method public getMaxOpenRequestsPerWorker() : short renamed to public getFlowControl() : FlowControl in class org.apache.giraph.comm.netty.NettyWorkerClient	From	To
Rename Variable	1
Rename Variable pair : Pair<AdjustableSemaphore,ConcurrentMap<ClientRequestId,RequestInfo>> to entry : Map.Entry<ClientRequestId,RequestInfo> in method private checkRequestsForProblems() : void in class org.apache.giraph.comm.netty.NettyClient	From	To
Inline Method	1
Inline Method private checkRequestsForProblemsInMap(requestMap ConcurrentMap<ClientRequestId,RequestInfo>) : void inlined to private checkRequestsForProblems() : void in class org.apache.giraph.comm.netty.NettyClient	From	To
Change Return Type	3
Change Return Type short to FlowControl in method public getFlowControl() : FlowControl in class org.apache.giraph.comm.netty.NettyWorkerClient	From	To
Change Return Type RequestInfo to void in method public messageAckReceived(taskId int, response short) : void in class org.apache.giraph.comm.flow_control.CreditBasedFlowControl	From	To
Change Return Type ConcurrentMap<ClientRequestId,RequestInfo> to void in method public sendRequest(destTaskId int, request WritableRequest) : void in class org.apache.giraph.comm.flow_control.CreditBasedFlowControl	From	To
Rename Parameter	2
Rename Parameter senderId : int to taskId : int in method public messageAckReceived(taskId int, response short) : void in class org.apache.giraph.comm.flow_control.CreditBasedFlowControl	From	To
Rename Parameter credit : short to response : short in method public messageAckReceived(taskId int, response short) : void in class org.apache.giraph.comm.flow_control.CreditBasedFlowControl	From	To

b90b59d2b5064782c501dfca5a1497f1ef513a6a

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: