fafecee712bc9b2ce8ef081d8170cdf99c48288b
Files Diff
- Added: 18
- Removed: 8
- Renamed: 0
- Modified: 26
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method public addPartitionEdges(partitionId Integer, edges VertexIdEdges<I,E>) : void from class org.apache.giraph.partition.SimplePartitionStore to protected addEntryToImMemoryPartitionData(partitionId int, edges VertexIdEdges<I,E>) : void from class org.apache.giraph.ooc.data.DiskBackedEdgeStore | From | To | |
| Move And Inline Method | 2 | ||
| Move And Inline Method public resetMessageStores() : void moved from class org.apache.giraph.partition.PartitionStore to class org.apache.giraph.comm.ServerData & inlined to public resetMessageStores() : void | From | To | |
| Move And Inline Method public prepareSuperstep() : void moved from class org.apache.giraph.partition.PartitionStore to class org.apache.giraph.comm.ServerData & inlined to public prepareSuperstep() : void | From | To | |
| Extract Subclass | 1 | ||
| Extract Subclass org.apache.giraph.ooc.data.DiskBackedPartitionStore from class org.apache.giraph.partition.PartitionStore | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type partitionId : Integer to partitionId : int in method protected addEntryToImMemoryPartitionData(partitionId int, edges VertexIdEdges<I,E>) : void in class org.apache.giraph.ooc.data.DiskBackedEdgeStore | From | To | |
| Move Method | 6 | ||
| Move Method public abstract moveEdgesToVertices() : void from class org.apache.giraph.partition.PartitionStore to public moveEdgesToVertices() : void from class org.apache.giraph.ooc.data.DiskBackedEdgeStore | From | To | |
| Move Method public getCurrentMessageStore() : MessageStore<I,M> from class org.apache.giraph.partition.PartitionStore to public getCurrentMessageStore() : MessageStore<I,M> from class org.apache.giraph.comm.ServerData | From | To | |
| Move Method public waitForComplete() : void from class org.apache.giraph.partition.PartitionStore to public waitForComplete() : void from class org.apache.giraph.comm.ServerData | From | To | |
| Move Method public moveEdgesToVertices() : void from class org.apache.giraph.partition.SimplePartitionStore to public moveEdgesToVertices() : void from class org.apache.giraph.ooc.data.DiskBackedEdgeStore | From | To | |
| Move Method private createMessageStoreFactory() : MessageStoreFactory<I,Writable,MessageStore<I,Writable>> from class org.apache.giraph.partition.PartitionStore to private createMessageStoreFactory() : MessageStoreFactory<I,Writable,MessageStore<I,Writable>> from class org.apache.giraph.comm.ServerData | From | To | |
| Move Method public getIncomingMessageStore() : MessageStore<I,M> from class org.apache.giraph.partition.PartitionStore to public getIncomingMessageStore() : MessageStore<I,M> from class org.apache.giraph.comm.ServerData | From | To | |
| Pull Up Attribute | 1 | ||
| Pull Up Attribute private LOG : Logger from class org.apache.giraph.ooc.AdaptiveOutOfCoreEngine to private LOG : Logger from class org.apache.giraph.ooc.OutOfCoreEngine | From | To | |
| Push Down Attribute | 2 | ||
| Push Down Attribute protected context : Mapper<?,?,?,?> from class org.apache.giraph.partition.PartitionStore to private context : Mapper<?,?,?,?> from class org.apache.giraph.ooc.data.DiskBackedPartitionStore | From | To | |
| Push Down Attribute protected serviceWorker : CentralizedServiceWorker<I,V,E> from class org.apache.giraph.partition.PartitionStore to private serviceWorker : CentralizedServiceWorker<I,V,E> from class org.apache.giraph.ooc.data.DiskBackedPartitionStore | From | To | |
| Move Attribute | 7 | ||
| Move Attribute protected edgeStore : EdgeStore<I,V,E> from class org.apache.giraph.partition.PartitionStore to private edgeStore : EdgeStore<I,V,E> from class org.apache.giraph.ooc.data.DiskBackedEdgeStore | From | To | |
| Move Attribute protected messageStoreFactory : MessageStoreFactory<I,Writable,MessageStore<I,Writable>> from class org.apache.giraph.partition.PartitionStore to private messageStoreFactory : MessageStoreFactory<I,Writable,MessageStore<I,Writable>> from class org.apache.giraph.comm.ServerData | From | To | |
| Move Attribute protected currentMessageStore : MessageStore<I,Writable> from class org.apache.giraph.partition.PartitionStore to private currentMessageStore : MessageStore<I,Writable> from class org.apache.giraph.comm.ServerData | From | To | |
| Move Attribute protected conf : ImmutableClassesGiraphConfiguration<I,V,E> from class org.apache.giraph.partition.PartitionStore to private conf : ImmutableClassesGiraphConfiguration<I,V,E> from class org.apache.giraph.ooc.data.DiskBackedEdgeStore | From | To | |
| Move Attribute private oocEngine : OutOfCoreEngine from class org.apache.giraph.ooc.DiskBackedPartitionStore to private oocEngine : OutOfCoreEngine from class org.apache.giraph.comm.ServerData | From | To | |
| Move Attribute private isInitialized : AtomicBoolean from class org.apache.giraph.ooc.DiskBackedPartitionStore to private isInitialized : AtomicBoolean from class org.apache.giraph.ooc.OutOfCoreEngine | From | To | |
| Move Attribute protected incomingMessageStore : MessageStore<I,Writable> from class org.apache.giraph.partition.PartitionStore to private incomingMessageStore : MessageStore<I,Writable> from class org.apache.giraph.comm.ServerData | From | To | |
| Extract Class | 2 | ||
| Extract Class org.apache.giraph.ooc.data.DiskBackedEdgeStore from class org.apache.giraph.partition.PartitionStore | From | To | |
| Extract Class org.apache.giraph.ooc.data.DiskBackedEdgeStore from class org.apache.giraph.partition.SimplePartitionStore | From | To | |
| Move Class | 1 | ||
| Move Class org.apache.giraph.ooc.DiskBackedPartitionStore.SerializedMessageClass moved to org.apache.giraph.ooc.data.DiskBackedMessageStore.SerializedMessageClass | From | To | |
| Extract Variable | 9 | ||
| Extract Variable messageStore : MessageStore<I,M> in method public doRequest(serverData ServerData) : void from class org.apache.giraph.comm.requests.SendWorkerOneMessageToManyRequest | From | To | |
| Extract Variable partitionMessages : PartitionDiskBackedMessageStore<I,M> in method public hasMessagesForPartition(partitionId int) : boolean from class org.apache.giraph.comm.messages.out_of_core.DiskBackedMessageStore | From | To | |
| Extract Variable partitionMessages : Int2ObjectOpenHashMap<DataInputOutput> in method public hasMessagesForPartition(partitionId int) : boolean from class org.apache.giraph.comm.messages.primitives.IntByteArrayMessageStore | From | To | |
| Extract Variable partitionMessages : Long2DoubleOpenHashMap in method public hasMessagesForPartition(partitionId int) : boolean from class org.apache.giraph.comm.messages.primitives.LongDoubleMessageStore | From | To | |
| Extract Variable partitionMessages : Int2FloatOpenHashMap in method public hasMessagesForPartition(partitionId int) : boolean from class org.apache.giraph.comm.messages.primitives.IntFloatMessageStore | From | To | |
| Extract Variable partitionMessages : Long2ObjectOpenHashMap<T> in method public hasMessagesForPartition(partitionId int) : boolean from class org.apache.giraph.comm.messages.primitives.long_id.LongAbstractMessageStore | From | To | |
| Extract Variable partitionMessages : Basic2ObjectMap<I,DataInputOutput> in method public hasMessagesForPartition(partitionId int) : boolean from class org.apache.giraph.comm.messages.primitives.IdByteArrayMessageStore | From | To | |
| Extract Variable partitionMessages : ConcurrentMap<I,T> in method public hasMessagesForPartition(partitionId int) : boolean from class org.apache.giraph.comm.messages.SimpleMessageStore | From | To | |
| Extract Variable partitionMessages : Basic2ObjectMap<I,M> in method public hasMessagesForPartition(partitionId int) : boolean from class org.apache.giraph.comm.messages.primitives.IdOneMessagePerVertexStore | From | To | |
| Rename Method | 2 | ||
| Rename Method public hasPartitionEdges(partitionId int) : boolean renamed to public hasEdgesForPartition(partitionId int) : boolean in class org.apache.giraph.edge.EdgeStore | From | To | |
| Rename Method public hasPartitionEdges(partitionId int) : boolean renamed to public hasEdgesForPartition(partitionId int) : boolean in class org.apache.giraph.edge.AbstractEdgeStore | From | To | |
| Pull Up Method | 1 | ||
| Pull Up Method public setDone() : void from class org.apache.giraph.ooc.AdaptiveOutOfCoreEngine to public failTheJob() : void from class org.apache.giraph.ooc.OutOfCoreEngine | From | To | |
| Push Down Method | 4 | ||
| Push Down Method public isEmpty() : boolean from class org.apache.giraph.partition.PartitionStore to public isEmpty() : boolean from class org.apache.giraph.ooc.data.DiskBackedPartitionStore | From | To | |
| Push Down Method public abstract getNextPartition() : Partition<I,V,E> from class org.apache.giraph.partition.PartitionStore to public getNextPartition() : Partition<I,V,E> from class org.apache.giraph.ooc.data.DiskBackedPartitionStore | From | To | |
| Push Down Method public abstract startIteration() : void from class org.apache.giraph.partition.PartitionStore to public startIteration() : void from class org.apache.giraph.ooc.data.DiskBackedPartitionStore | From | To | |
| Push Down Method public abstract putPartition(partition Partition<I,V,E>) : void from class org.apache.giraph.partition.PartitionStore to public putPartition(partition Partition<I,V,E>) : void from class org.apache.giraph.ooc.data.DiskBackedPartitionStore | From | To |