42ffd9b1c5b1025e7955ff61956c3c04487b33c3
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 12
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 11 | ||
| Rename Method protected createMainReaderTask() : ReadAllBytesTask renamed to protected init_StdOutReaderTask() : ReadAllBytesTask in class melnorme.utilbox.process.ExternalProcessNotifyingHelper | From | To | |
| Rename Method public awaitResult() : RET renamed to public awaitTermination() : void in class melnorme.utilbox.concurrency.AbstractFuture2 | From | To | |
| Rename Method protected createStdErrReaderTask() : EndlessReadTask renamed to protected init_StdErrReaderTask() : EndlessReadTask in class melnorme.utilbox.process.ExternalProcessHelper_Test.TestsExternalProcessHelper | From | To | |
| Rename Method protected createMainReaderTask() : ReadAllBytesTask renamed to protected init_StdOutReaderTask() : ReadAllBytesTask in class melnorme.utilbox.process.ExternalProcessHelper | From | To | |
| Rename Method public awaitResult(timeout long, unit TimeUnit) : RET renamed to public awaitTermination(timeout long, unit TimeUnit) : void in class melnorme.utilbox.concurrency.AbstractFuture2 | From | To | |
| Rename Method protected createMainReaderTask() : EndlessReadTask renamed to protected init_StdOutReaderTask() : EndlessReadTask in class melnorme.utilbox.process.ExternalProcessHelper_Test.TestsExternalProcessHelper | From | To | |
| Rename Method public getCompletionLatch() : CountDownLatch renamed to protected getTerminationLatch() : CountDownLatch in class melnorme.utilbox.concurrency.CompletableResult | From | To | |
| Rename Method protected createStdErrReaderTask() : ReadAllBytesTask renamed to protected init_StdErrReaderTask() : ReadAllBytesTask in class melnorme.utilbox.process.ExternalProcessNotifyingHelper | From | To | |
| Rename Method protected checkExecuted() : void renamed to public markExecuted() : void in class melnorme.utilbox.concurrency.CancellableTask | From | To | |
| Rename Method protected getStdOutBytes3() : ByteArrayOutputStreamExt renamed to protected getStdOutBytes() : ByteArrayOutputStreamExt in class melnorme.utilbox.process.ExternalProcessHelper | From | To | |
| Rename Method protected createStdErrReaderTask() : ReadAllBytesTask renamed to protected init_StdErrReaderTask() : ReadAllBytesTask in class melnorme.utilbox.process.ExternalProcessHelper | From | To | |
| Pull Up Method | 4 | ||
| Pull Up Method protected isCanceled() : boolean from class melnorme.utilbox.process.ExternalProcessHelper to protected isCanceled() : boolean from class melnorme.utilbox.process.ExternalProcessHandler | From | To | |
| Pull Up Method public awaitResult2() : RESULT from class melnorme.utilbox.concurrency.BasicFuture to public awaitResult2() : RESULT from class melnorme.utilbox.concurrency.AsyncSupplier | From | To | |
| Pull Up Method public awaitResult(timeout long, unit TimeUnit) : DATA from class melnorme.utilbox.concurrency.CompletableResult to public awaitResult(timeout long, unit TimeUnit) : RESULT from class melnorme.utilbox.concurrency.BasicFuture | From | To | |
| Pull Up Method public awaitData(cm ICancelMonitor) : DATA from class melnorme.utilbox.concurrency.NonCancellableFuture to public awaitResult(cm ICancelMonitor) : RESULT from class melnorme.utilbox.concurrency.AsyncSupplier | From | To | |
| Move And Rename Method | 1 | ||
| Move And Rename Method public awaitCompletion(timeout long, unit TimeUnit) : void from class melnorme.utilbox.concurrency.CompletableResult to public awaitTermination(timeout long, unit TimeUnit) : void from class melnorme.lang.utils.concurrency.ConcurrentlyDerivedData.DataUpdateFuture | From | To | |
| Move Method | 1 | ||
| Move Method public awaitResult() : DATA from class melnorme.utilbox.concurrency.CompletableResult to public awaitResult() : DATA from class melnorme.utilbox.concurrency.NonCancellableFuture | From | To | |
| Change Return Type | 4 | ||
| Change Return Type RET to void in method public awaitTermination() : void in class melnorme.utilbox.concurrency.AbstractFuture2 | From | To | |
| Change Return Type RET to void in method public awaitTermination(timeout long, unit TimeUnit) : void in class melnorme.utilbox.concurrency.AbstractFuture2 | From | To | |
| Change Return Type DATA to RESULT in method public awaitResult(timeout long, unit TimeUnit) : RESULT in class melnorme.utilbox.concurrency.BasicFuture | From | To | |
| Change Return Type DATA to RESULT in method public awaitResult(cm ICancelMonitor) : RESULT in class melnorme.utilbox.concurrency.AsyncSupplier | From | To | |
| Rename Attribute | 3 | ||
| Rename Attribute completionLatch : CountDownLatch to terminationLatch : CountDownLatch in class melnorme.utilbox.concurrency.CompletableResult | From | To | |
| Rename Attribute mainReader : STDOUT_TASK to stdoutReaderTask : STDOUT_TASK in class melnorme.utilbox.process.ExternalProcessHandler | From | To | |
| Rename Attribute stderrReader : STDERR_TASK to stderrReaderTask : STDERR_TASK in class melnorme.utilbox.process.ExternalProcessHandler | From | To | |
| Extract Interface | 1 | ||
| Extract Interface melnorme.utilbox.concurrency.AsyncSupplier from classes [melnorme.utilbox.concurrency.BasicFuture] | From | To | |
| Extract Method | 3 | ||
| Extract Method public awaitTermination() : void extracted from public awaitResult() : DATA in class melnorme.lang.utils.concurrency.ConcurrentlyDerivedData.DataUpdateFuture | From | To | |
| Extract Method public awaitTermination(timeout long, unit TimeUnit) : void extracted from public awaitResult(timeout long, unit TimeUnit) : DATA in class melnorme.lang.utils.concurrency.ConcurrentlyDerivedData.DataUpdateFuture | From | To | |
| Extract Method protected init_StdErrThread(readStdErr boolean) : ProcessHelperStdErrThread extracted from public ExternalProcessHandler(process Process, readStdErr boolean, startReaders boolean, cancelMonitor ICancelMonitor) in class melnorme.utilbox.process.ExternalProcessHandler | From | To |