goclipse 938afbeaca734270cab91690040634e6b499a3d9

938afbeaca734270cab91690040634e6b499a3d9

Files Diff

Added: 4
Removed: 1
Renamed: 0
Modified: 11

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Change Parameter Type	2
Change Parameter Type updateTask : StructureUpdateTask to updateTask : UpdateTask in method public setNewStructure(newData DATA, updateTask UpdateTask) : void in class melnorme.lang.utils.concurrency.ConcurrentDerivedData	From	To
Change Parameter Type updateTask : StructureUpdateTask to newUpdateTask : UpdateTask in method public setUpdateTask(newUpdateTask UpdateTask) : void in class melnorme.lang.utils.concurrency.ConcurrentDerivedData	From	To
Pull Up Attribute	3
Pull Up Attribute protected executor : ICommonExecutor from class melnorme.lang.ide.core.engine.StructureModelManager to protected executor : ICommonExecutor from class melnorme.lang.ide.core.engine.AbstractModelUpdateManager	From	To
Pull Up Attribute public log : SimpleLogger from class melnorme.lang.ide.core.engine.StructureModelManager to public log : SimpleLogger from class melnorme.lang.ide.core.engine.AbstractModelUpdateManager	From	To
Pull Up Attribute private latch : CountDownLatch from class melnorme.lang.ide.core.engine.StructureModelManager.StructureInfo to private latch : CountDownLatch from class melnorme.lang.utils.concurrency.ConcurrentDerivedData	From	To
Extract Class	1
Extract Class melnorme.lang.ide.core.engine.StructureModelManager.SourceModelRegistration from class melnorme.lang.ide.ui.editor.structure.AbstractLangStructureEditor	From	To
Move Class	1
Move Class melnorme.lang.ide.core.engine.UpdateTask moved to melnorme.lang.utils.concurrency.UpdateTask	From	To
Change Variable Type	2
Change Variable Type structureInfo2 : StructureInfo to registration_unmanaged : SourceModelRegistration in method protected testMultipleConnects(key Object, doc Document) : void in class melnorme.lang.ide.core.engine.StructureModelManagerTest	From	To
Change Variable Type structureInfo : StructureInfo to reconcileRegistration : SourceModelRegistration in method protected testBasicFlow(key Object, doc Document, initialConnect boolean) : void in class melnorme.lang.ide.core.engine.StructureModelManagerTest	From	To
Extract Method	1
Extract Method protected disconnectUpdates() : void extracted from protected internalDoSetInput(input IEditorInput) : void in class melnorme.lang.ide.ui.editor.structure.AbstractLangStructureEditor	From	To
Rename Method	11
Rename Method protected abstract createUpdateTask2(structureInfo StructureInfo, source String, fileLocation Location) : StructureUpdateTask renamed to protected abstract createUpdateTask(structureInfo StructureInfo, source String, fileLocation Location) : StructureUpdateTask in class melnorme.lang.ide.core.engine.StructureModelManager	From	To
Rename Method protected abstract createDisposeTask2(structureInfo StructureInfo, fileLocation Location) : StructureUpdateTask renamed to protected abstract createDisposeTask(structureInfo StructureInfo, fileLocation Location) : StructureUpdateTask in class melnorme.lang.ide.core.engine.StructureModelManager	From	To
Rename Method public isWorkingCopy() : boolean renamed to public hasConnectedListeners() : boolean in class melnorme.lang.ide.core.engine.StructureModelManager.StructureInfo	From	To
Rename Method public doRun2() : void renamed to public doRun() : void in class melnorme.lang.ide.core.engine.StructureModelManager.StructureUpdateTask	From	To
Rename Method protected createEngineClient() : EngineClient renamed to protected initializeTestsEngineClient() : EngineClient in class melnorme.lang.ide.core.engine.StructureModelManagerTest.StructureModelManager_ActualTest	From	To
Rename Method public connectStructureUpdates(key Object, document IDocument, structureListener IStructureModelListener) : StructureInfo renamed to public connectStructureUpdates3(key Object, document IDocument, structureListener IStructureModelListener) : SourceModelRegistration in class melnorme.lang.ide.core.engine.StructureModelManager	From	To
Rename Method protected createUpdateTask2(structureInfo StructureInfo, source String, fileLocation Location) : StructureUpdateTask renamed to protected createUpdateTask(structureInfo StructureInfo, source String, fileLocation Location) : StructureUpdateTask in class melnorme.lang.ide.core.engine.StructureModelManagerTest.InstrumentedEngineClient	From	To
Rename Method protected createDisposeTask2(structureInfo StructureInfo, fileLocation Location) : StructureUpdateTask renamed to protected createDisposeTask(structureInfo StructureInfo, fileLocation Location) : StructureUpdateTask in class melnorme.lang.ide.core.engine.StructureModelManagerTest.InstrumentedEngineClient	From	To
Rename Method public getUpdatedStructure(pm IProgressMonitor) : SourceFileStructure renamed to public awaitUpdatedData(pm IProgressMonitor) : SourceFileStructure in class melnorme.lang.ide.core.engine.StructureModelManager.StructureInfo	From	To
Rename Method public checkCounts(updateTaskCount int, disposeTaskCount int) : void renamed to public checkTaskDelta(updateTaskCount int, disposeTaskCount int) : void in class melnorme.lang.ide.core.engine.StructureModelManagerTest	From	To
Rename Method public disconnectStructureUpdates2(structureInfo StructureInfo, structureListener IStructureModelListener, docAcess MDocumentSynchedAcess) : void renamed to public disconnectStructureUpdates(structureInfo StructureInfo, structureListener IStructureModelListener) : void in class melnorme.lang.ide.core.engine.StructureModelManager	From	To
Pull Up Method	5
Pull Up Method public getUpdatedStructure(timeout long, unit TimeUnit) : SourceFileStructure from class melnorme.lang.ide.core.engine.StructureModelManager.StructureInfo to public awaitUpdatedData(timeout long, unit TimeUnit) : DATA from class melnorme.lang.utils.concurrency.ConcurrentDerivedData	From	To
Pull Up Method public dispose() : void from class melnorme.lang.ide.core.engine.StructureModelManager to public dispose() : void from class melnorme.lang.ide.core.engine.AbstractModelUpdateManager	From	To
Pull Up Method public isStale() : boolean from class melnorme.lang.ide.core.engine.StructureModelManager.StructureInfo to public isStale() : boolean from class melnorme.lang.utils.concurrency.ConcurrentDerivedData	From	To
Pull Up Method public setNewStructure(newStructure SourceFileStructure, updateTask StructureUpdateTask) : void from class melnorme.lang.ide.core.engine.StructureModelManager.StructureInfo to public setNewStructure(newData DATA, updateTask UpdateTask) : void from class melnorme.lang.utils.concurrency.ConcurrentDerivedData	From	To
Pull Up Method public queueTask(updateTask StructureUpdateTask) : void from class melnorme.lang.ide.core.engine.StructureModelManager.StructureInfo to public setUpdateTask(newUpdateTask UpdateTask) : void from class melnorme.lang.utils.concurrency.ConcurrentDerivedData	From	To
Inline Method	1
Inline Method private connectDocumentListener(document IDocument, structureInfo StructureInfo) : void inlined to public connectDocument(newDocument IDocument, structureListener IStructureModelListener) : boolean in class melnorme.lang.ide.core.engine.StructureModelManager.StructureInfo	From	To
Rename Variable	3
Rename Variable document : IDocument to doc : IDocument in method protected internalDoSetInput(input IEditorInput) : void in class melnorme.lang.ide.ui.editor.structure.AbstractLangStructureEditor	From	To
Rename Variable structureInfo2 : StructureInfo to registration_unmanaged : SourceModelRegistration in method protected testMultipleConnects(key Object, doc Document) : void in class melnorme.lang.ide.core.engine.StructureModelManagerTest	From	To
Rename Variable structureInfo : StructureInfo to reconcileRegistration : SourceModelRegistration in method protected testBasicFlow(key Object, doc Document, initialConnect boolean) : void in class melnorme.lang.ide.core.engine.StructureModelManagerTest	From	To
Change Return Type	3
Change Return Type SourceFileStructure to DATA in method public awaitUpdatedData(timeout long, unit TimeUnit) : DATA in class melnorme.lang.utils.concurrency.ConcurrentDerivedData	From	To
Change Return Type StructureInfo to SourceModelRegistration in method public connectStructureUpdates3(key Object, document IDocument, structureListener IStructureModelListener) : SourceModelRegistration in class melnorme.lang.ide.core.engine.StructureModelManager	From	To
Change Return Type StructureInfo to SourceModelRegistration in method protected testConnectStructureUpdates(key Object, doc Document, initialConnect boolean) : SourceModelRegistration in class melnorme.lang.ide.core.engine.StructureModelManagerTest	From	To
Extract Superclass	2
Extract Superclass melnorme.lang.ide.core.engine.AbstractModelUpdateManager from classes [melnorme.lang.ide.core.engine.StructureModelManager]	From	To
Extract Superclass melnorme.lang.utils.concurrency.ConcurrentDerivedData from classes [melnorme.lang.ide.core.engine.StructureModelManager.StructureInfo]	From	To
Rename Attribute	2
Rename Attribute workingCopyListeners : ListenerListHelper<IStructureModelListener> to updateListeners : ListenerListHelper<IStructureModelListener> in class melnorme.lang.ide.core.engine.StructureModelManager.StructureInfo	From	To
Rename Attribute structureInfos : EntryMapTS<Object,StructureInfo> to infosMap : EntryMapTS<Object,StructureInfo> in class melnorme.lang.ide.core.engine.StructureModelManager	From	To
Change Attribute Type	1
Change Attribute Type owned : ArrayList2<IDisposable> to owned : IOwner in class melnorme.lang.ide.ui.editor.TextEditorExt	From	To
Rename Parameter	1
Rename Parameter updateTask : StructureUpdateTask to newUpdateTask : UpdateTask in method public setUpdateTask(newUpdateTask UpdateTask) : void in class melnorme.lang.utils.concurrency.ConcurrentDerivedData	From	To

938afbeaca734270cab91690040634e6b499a3d9

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: