976957500f738f4e13dc4632dc069b2bffdd05d4
Files Diff
- Added: 4
- Removed: 4
- Renamed: 0
- Modified: 18
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 2 | ||
| Move And Rename Method protected doCreateMarkers(location Location, file IFile, sourceFileStructure SourceFileStructure) : void from class melnorme.lang.ide.core.engine.ProblemMarkerUpdater to protected doCreateProblemMarkers(file IFile) : void from class melnorme.lang.ide.core.engine.ProblemMarkerUpdater.UpdateProblemMarkersTask | From | To | |
| Move And Rename Method public awaitUpdatedData(timeout long, unit TimeUnit) : DATA from class melnorme.lang.utils.concurrency.ConcurrentlyDerivedData to public get(timeout long, unit TimeUnit) : DATA from class melnorme.lang.utils.concurrency.ConcurrentlyDerivedData.DataUpdateFuture | From | To | |
| Move And Inline Method | 1 | ||
| Move And Inline Method public awaitUpdatedWorkingCopy(modelKey Object, pm IProgressMonitor) : void moved from class melnorme.lang.ide.core.engine.SourceModelManager to class melnorme.lang.ide.core.engine.EngineOperation & inlined to protected doRunEngineOperation(pm IProgressMonitor) : RET | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type engineClient : EngineClient to manager : SourceModelManager in method public TestsStructureModelListener(manager SourceModelManager, structureInfo StructureInfo, expectedChanges int) in class melnorme.lang.ide.core.engine.StructureModelTest.TestsStructureModelListener | From | To | |
| Change Parameter Type derivedData : ConcurrentlyDerivedData<DATA> to derivedData : ConcurrentlyDerivedData<DATA,?> in method public DataUpdateTask(derivedData ConcurrentlyDerivedData<DATA,?>, taskDisplayName String) in class melnorme.lang.utils.concurrency.ConcurrentlyDerivedData.DataUpdateTask | From | To | |
| Change Parameter Type client : EngineClient to sourceModelMgr : SourceModelManager in method public EngineOperation(sourceModelMgr SourceModelManager, location Location, offset int, timeoutMillis int, opName String) in class melnorme.lang.ide.core.engine.EngineOperation | From | To | |
| Move Method | 4 | ||
| Move Method public checkMonitorCancelation_OCE(progressMonitor IProgressMonitor) : void from class melnorme.lang.ide.core.utils.EclipseUtils to public checkMonitorCancelation_OCE(progressMonitor IProgressMonitor) : void from class melnorme.lang.ide.core.utils.operation.OperationUtils | From | To | |
| Move Method protected createMarker(location Location, file IFile, problem ParserError) : void from class melnorme.lang.ide.core.engine.ProblemMarkerUpdater to protected createMarker(location Location, file IFile, problem ParserError) : void from class melnorme.lang.ide.core.engine.ProblemMarkerUpdater.UpdateProblemMarkersTask | From | To | |
| Move Method public updateProblemMarkers(location Location, sourceFileStructure SourceFileStructure) : void from class melnorme.lang.ide.core.engine.ProblemMarkerUpdater to protected updateProblemMarkers() : void from class melnorme.lang.ide.core.engine.ProblemMarkerUpdater.UpdateProblemMarkersTask | From | To | |
| Move Method public checkMonitorCancelation(progressMonitor IProgressMonitor) : void from class melnorme.lang.ide.core.utils.EclipseUtils to public checkMonitorCancelation(progressMonitor IProgressMonitor) : void from class melnorme.lang.ide.core.utils.operation.OperationUtils | From | To | |
| Extract Class | 1 | ||
| Extract Class melnorme.lang.ide.core.utils.operation.OperationUtils from class melnorme.lang.ide.core.utils.EclipseUtils | From | To | |
| Rename Class | 2 | ||
| Rename Class LANG_PROJECT_ID.ide.core.engine.LANGUAGE_EngineClient renamed to LANG_PROJECT_ID.ide.core.engine.LANGUAGE_SourceModelManager | From | To | |
| Rename Class melnorme.lang.ide.core.engine.StructureModelManagerTest renamed to melnorme.lang.ide.core.engine.StructureModelTest | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class melnorme.lang.ide.core.engine.StructureModelManagerTest.InstrumentedEngineClient moved and renamed to melnorme.lang.ide.core.engine.StructureModelTest.InstrumentedSourceModelManager | From | To | |
| Extract Method | 1 | ||
| Extract Method public asFuture() : DataUpdateFuture extracted from public awaitUpdatedData() : DATA in class melnorme.lang.utils.concurrency.ConcurrentlyDerivedData | From | To | |
| Rename Method | 5 | ||
| Rename Method public getLatchForCurrentUpdate() : CountDownLatch renamed to public getLatchForUpdateTask() : CountDownLatch in class melnorme.lang.utils.concurrency.ConcurrentlyDerivedData | From | To | |
| Rename Method public structureChanged(lockedStructureInfo StructureInfo) : void renamed to public dataChanged(lockedStructureInfo StructureInfo) : void in class melnorme.lang.ide.core.engine.StructureModelTest.TestsStructureModelListener | From | To | |
| Rename Method public createEngineClient() : LANGUAGE_EngineClient renamed to public createSourceModelManager() : LANGUAGE_SourceModelManager in class melnorme.lang.ide.core.LangCore_Actual | From | To | |
| Rename Method public getOwned() : Indexable<IDisposable> renamed to public asOwner() : IOwner in class melnorme.utilbox.ownership.LifecycleObject | From | To | |
| Rename Method public dispose() : void renamed to protected dispose_post() : void in class melnorme.lang.ide.core.engine.AbstractModelUpdateManager | From | To | |
| Pull Up Method | 1 | ||
| Pull Up Method public EngineClient() from class melnorme.lang.ide.core.engine.EngineClient to public SourceModelManager(problemUpdater ProblemMarkerUpdater) from class melnorme.lang.ide.core.engine.SourceModelManager | From | To | |
| Inline Method | 1 | ||
| Inline Method private disconnectStructureUpdates() : void inlined to protected disposeDo() : void in class melnorme.lang.ide.core.engine.SourceModelManager.StructureModelRegistration | From | To | |
| Change Return Type | 2 | ||
| Change Return Type LANGUAGE_EngineClient to LANGUAGE_SourceModelManager in method public createSourceModelManager() : LANGUAGE_SourceModelManager in class melnorme.lang.ide.core.LangCore_Actual | From | To | |
| Change Return Type Indexable<IDisposable> to IOwner in method public asOwner() : IOwner in class melnorme.utilbox.ownership.LifecycleObject | From | To | |
| Rename Attribute | 6 | ||
| Rename Attribute engineClient : EngineClient to sourceModelMgr : SourceModelManager in class melnorme.lang.ide.core.engine.EngineOperation | From | To | |
| Rename Attribute engineClient : EngineClient to sourceModelMgr : SourceModelManager in class melnorme.lang.ide.ui.editor.structure.AbstractLangStructureEditor | From | To | |
| Rename Attribute engineClient2 : InstrumentedEngineClient to manager2 : InstrumentedSourceModelManager in class melnorme.lang.ide.core.engine.StructureModelTest | From | To | |
| Rename Attribute engineClient : EngineClient to manager : SourceModelManager in class melnorme.lang.ide.core.engine.StructureModelTest | From | To | |
| Rename Attribute modelListeners : ListenerListHelper<IStructureModelListener> to globalListeners : ListenerListHelper<IStructureModelListener> in class melnorme.lang.ide.core.engine.SourceModelManager | From | To | |
| Rename Attribute engineClient : EngineClient to sourceModelManager : SourceModelManager in class melnorme.lang.ide.core.LangCore | From | To | |
| Change Attribute Type | 6 | ||
| Change Attribute Type engineClient : EngineClient to sourceModelManager : SourceModelManager in class melnorme.lang.ide.core.LangCore | From | To | |
| Change Attribute Type engineClient : EngineClient to sourceModelMgr : SourceModelManager in class melnorme.lang.ide.ui.editor.structure.AbstractLangStructureEditor | From | To | |
| Change Attribute Type engineClient : EngineClient to sourceModelMgr : SourceModelManager in class melnorme.lang.ide.core.engine.EngineOperation | From | To | |
| Change Attribute Type derivedData : ConcurrentlyDerivedData<DATA> to derivedData : ConcurrentlyDerivedData<DATA,?> in class melnorme.lang.utils.concurrency.ConcurrentlyDerivedData.DataUpdateTask | From | To | |
| Change Attribute Type engineClient2 : InstrumentedEngineClient to manager2 : InstrumentedSourceModelManager in class melnorme.lang.ide.core.engine.StructureModelTest | From | To | |
| Change Attribute Type engineClient : EngineClient to manager : SourceModelManager in class melnorme.lang.ide.core.engine.StructureModelTest | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter client : EngineClient to sourceModelMgr : SourceModelManager in method public EngineOperation(sourceModelMgr SourceModelManager, location Location, offset int, timeoutMillis int, opName String) in class melnorme.lang.ide.core.engine.EngineOperation | From | To | |
| Rename Parameter engineClient : EngineClient to manager : SourceModelManager in method public TestsStructureModelListener(manager SourceModelManager, structureInfo StructureInfo, expectedChanges int) in class melnorme.lang.ide.core.engine.StructureModelTest.TestsStructureModelListener | From | To |