graphhopper 264339c14a92e24b7e88bf3d0fb4cccc34470b47

264339c14a92e24b7e88bf3d0fb4cccc34470b47

Files Diff

Added: 6
Removed: 6
Renamed: 0
Modified: 6

Link to commit

io.dropwizard:dropwizard-core:1.2.2
com.vividsolutions:jts-core:1.14.0
javax.activation:activation:1.1.1
com.google.guava:guava:21.0
junit:junit:4.12
io.dropwizard:dropwizard-testing:1.2.2
org.hamcrest:hamcrest-library:1.3
com.squareup.okhttp3:okhttp:3.8.0
com.google.transit:gtfs-realtime-bindings:0.0.4
org.apache.xmlgraphics:xmlgraphics-commons:2.1
com.graphhopper:directions-api-client:0.10.0
javax.xml.ws:jaxws-api:2.3.0
org.assertj:assertj-core:3.6.2
org.apache.commons:commons-compress:1.12
io.dropwizard-bundles:dropwizard-configurable-assets-bundle:1.0.5
org.openstreetmap.osmosis:osmosis-osm-binary:0.46
com.fasterxml.jackson.core:jackson-databind:2.9.1
com.fasterxml.jackson.core:jackson-annotations:2.9.1
com.carrotsearch:hppc:0.7.2
log4j:log4j:1.2.17
com.conveyal:gtfs-lib:2.1.0
com.bedatadriven:jackson-datatype-jts:2.4
org.slf4j:slf4j-api:1.7.25
org.slf4j:slf4j-log4j12:1.7.25

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Change Parameter Type	6
Change Parameter Type witnessPathFinder : WitnessPathFinder to legacyWitnessPathFinder : LegacyWitnessPathFinder in method public shortcutRequired(node int, toNode int, outgoingEdge EdgeIteratorState, legacyWitnessPathFinder LegacyWitnessPathFinder, originalPath WitnessSearchEntry) : boolean in class com.graphhopper.routing.ch.EdgeBasedNodeContractor.TurnReplacementSearch	From	To
Change Parameter Type graph : CHGraph to graph : GraphHopperStorage in method public WitnessPathFinder(graph GraphHopperStorage, chGraph CHGraph, turnWeighting TurnWeighting) in class com.graphhopper.routing.ch.WitnessPathFinder	From	To
Change Parameter Type witnessPathFinder : WitnessPathFinder to legacyWitnessPathFinder : LegacyWitnessPathFinder in method public shortcutRequired(node int, toNode int, outgoingEdges EdgeIteratorState, legacyWitnessPathFinder LegacyWitnessPathFinder, entry WitnessSearchEntry) : boolean in class com.graphhopper.routing.ch.EdgeBasedNodeContractor.SimpleSearch	From	To
Change Parameter Type witnessPathFinder : WitnessPathFinder to legacyWitnessPathFinder : LegacyWitnessPathFinder in method private alternativeWitnessExistsOrNotNeeded(node int, outgoingEdge EdgeIteratorState, toNode int, legacyWitnessPathFinder LegacyWitnessPathFinder, originalPath CHEntry) : boolean in class com.graphhopper.routing.ch.EdgeBasedNodeContractor.TurnReplacementSearch	From	To
Change Parameter Type witnessPathFinder : WitnessPathFinder to legacyWitnessPathFinder : LegacyWitnessPathFinder in method public shortcutRequired(node int, toNode int, outgoingEdge EdgeIteratorState, legacyWitnessPathFinder LegacyWitnessPathFinder, entry WitnessSearchEntry) : boolean in class com.graphhopper.routing.ch.EdgeBasedNodeContractor.WitnessSearchStrategy	From	To
Change Parameter Type graph : GraphHopperStorage to graph : CHGraph in method public LegacyWitnessPathFinder(graph CHGraph, weighting Weighting, traversalMode TraversalMode, maxLevel int) in class com.graphhopper.routing.ch.LegacyWitnessPathFinder	From	To
Move Method	8
Move Method public test_shortcut_needed_bidirectional() : void from class com.graphhopper.routing.ch.SmartWitnessPathFinderTest to public test_shortcut_needed_bidirectional() : void from class com.graphhopper.routing.ch.WitnessPathFinderTest	From	To
Move Method private getEdgeKey(edge int, adjNode int) : int from class com.graphhopper.routing.ch.WitnessPathFinderTest to private getEdgeKey(edge int, adjNode int) : int from class com.graphhopper.routing.ch.LegacyWitnessPathFinderTest	From	To
Move Method public test_witness_basic() : void from class com.graphhopper.routing.ch.SmartWitnessPathFinderTest to public test_witness_basic() : void from class com.graphhopper.routing.ch.WitnessPathFinderTest	From	To
Move Method public test_witness_bidirectional() : void from class com.graphhopper.routing.ch.SmartWitnessPathFinderTest to public test_witness_bidirectional() : void from class com.graphhopper.routing.ch.WitnessPathFinderTest	From	To
Move Method private setMaxLevelOnAllNodes() : void from class com.graphhopper.routing.ch.SmartWitnessPathFinderTest to private setMaxLevelOnAllNodes() : void from class com.graphhopper.routing.ch.WitnessPathFinderTest	From	To
Move Method public findTarget_works() : void from class com.graphhopper.routing.ch.WitnessPathFinderTest to public findTarget_works() : void from class com.graphhopper.routing.ch.LegacyWitnessPathFinderTest	From	To
Move Method private assertFinderResult(expected WitnessSearchEntry, result WitnessSearchEntry) : void from class com.graphhopper.routing.ch.SmartWitnessPathFinderTest to private assertFinderResult(expected WitnessSearchEntry, result WitnessSearchEntry) : void from class com.graphhopper.routing.ch.WitnessPathFinderTest	From	To
Move Method public test_shortcut_needed_basic() : void from class com.graphhopper.routing.ch.SmartWitnessPathFinderTest to public test_shortcut_needed_basic() : void from class com.graphhopper.routing.ch.WitnessPathFinderTest	From	To
Move Attribute	4
Move Attribute protected weighting : Weighting from class com.graphhopper.routing.ch.WitnessPathFinder to private weighting : Weighting from class com.graphhopper.routing.ch.LegacyWitnessPathFinderTest	From	To
Move Attribute private weighting : Weighting from class com.graphhopper.routing.ch.WitnessPathFinderTest to private weighting : Weighting from class com.graphhopper.routing.ch.LegacyWitnessPathFinderTest	From	To
Move Attribute private chTurnWeighting : TurnWeighting from class com.graphhopper.routing.ch.SmartWitnessPathFinderTest to private chTurnWeighting : TurnWeighting from class com.graphhopper.routing.ch.WitnessPathFinderTest	From	To
Move Attribute private chGraph : CHGraph from class com.graphhopper.routing.ch.SmartWitnessPathFinderTest to protected chGraph : CHGraph from class com.graphhopper.routing.ch.WitnessPathFinder	From	To
Extract Class	1
Extract Class com.graphhopper.routing.ch.LegacyWitnessPathFinderTest from class com.graphhopper.routing.ch.WitnessPathFinderTest	From	To
Rename Class	5
Rename Class com.graphhopper.routing.ch.SmartWitnessPathFinder renamed to com.graphhopper.routing.ch.LegacyWitnessPathFinder	From	To
Rename Class com.graphhopper.routing.ch.ArrayBasedWitnessPathFinder renamed to com.graphhopper.routing.ch.ArrayBasedLegacyWitnessPathFinder	From	To
Rename Class com.graphhopper.routing.ch.MapSmartWitnessPathFinder renamed to com.graphhopper.routing.ch.MapWitnessPathFinder	From	To
Rename Class com.graphhopper.routing.ch.ArraySmartWitnessPathFinder renamed to com.graphhopper.routing.ch.ArrayWitnessPathFinder	From	To
Rename Class com.graphhopper.routing.ch.MapBasedWitnessPathFinder renamed to com.graphhopper.routing.ch.MapBasedLegacyWitnessPathFinder	From	To
Move Class	1
Move Class com.graphhopper.routing.ch.SmartWitnessPathFinderTest.ExpectedResultBuilder moved to com.graphhopper.routing.ch.WitnessPathFinderTest.ExpectedResultBuilder	From	To
Extract Variable	2
Extract Variable outEdgeFilter : DefaultEdgeFilter in method public WitnessPathFinder(graph GraphHopperStorage, chGraph CHGraph, turnWeighting TurnWeighting) from class com.graphhopper.routing.ch.WitnessPathFinder	From	To
Extract Variable inEdgeFilter : DefaultEdgeFilter in method public WitnessPathFinder(graph GraphHopperStorage, chGraph CHGraph, turnWeighting TurnWeighting) from class com.graphhopper.routing.ch.WitnessPathFinder	From	To
Change Variable Type	3
Change Variable Type witnessedPairs : LongSet to toNodes : IntSet in method private findAndHandleShortcutsAggressive(node int) : int in class com.graphhopper.routing.ch.EdgeBasedNodeContractor	From	To
Change Variable Type eis : CHEdgeIteratorState to eis : EdgeIteratorState in method protected getEdgeKey(edge int, adjNode int) : int in class com.graphhopper.routing.ch.LegacyWitnessPathFinder	From	To
Change Variable Type eis : EdgeIteratorState to eis : CHEdgeIteratorState in method package getEdgeKey(edge int, adjNode int) : int in class com.graphhopper.routing.ch.WitnessPathFinder	From	To
Rename Method	4
Rename Method public getNumEntriesPolled() : int renamed to public getNumPolledEdges() : int in class com.graphhopper.routing.ch.WitnessPathFinder	From	To
Rename Method public getNumPolledEdges() : int renamed to public getNumEntriesPolled() : int in class com.graphhopper.routing.ch.LegacyWitnessPathFinder	From	To
Rename Method private analyzeSmartVsAggressive() : void renamed to private analyzeLegacyVsAggressive() : void in class com.graphhopper.tools.CHMeasurement	From	To
Rename Method public init() : void renamed to public setup() : void in class com.graphhopper.routing.ch.WitnessPathFinderTest	From	To
Rename Variable	7
Rename Variable totalEdgesPolledS : int to totalEdgesPolledL : int in method public testNodeContraction_randomGraph_checkStatistics() : void in class com.graphhopper.routing.ch.EdgeBasedNodeContractorTest	From	To
Rename Variable numShortcutsS : int to numShortcutsL : int in method public testNodeContraction_randomGraph_checkStatistics() : void in class com.graphhopper.routing.ch.EdgeBasedNodeContractorTest	From	To
Rename Variable numEdgesPolledS : int to numEdgesPolledL : int in method public testNodeContraction_randomGraph_checkStatistics() : void in class com.graphhopper.routing.ch.EdgeBasedNodeContractorTest	From	To
Rename Variable numSearchesS : int to numSearchesL : int in method public testNodeContraction_randomGraph_checkStatistics() : void in class com.graphhopper.routing.ch.EdgeBasedNodeContractorTest	From	To
Rename Variable totalNumShortcutsS : int to totalNumShortcutsL : int in method public testNodeContraction_randomGraph_checkStatistics() : void in class com.graphhopper.routing.ch.EdgeBasedNodeContractorTest	From	To
Rename Variable witnessedPairs : LongSet to toNodes : IntSet in method private findAndHandleShortcutsAggressive(node int) : int in class com.graphhopper.routing.ch.EdgeBasedNodeContractor	From	To
Rename Variable totalNumSearchesS : int to totalNumSearchesL : int in method public testNodeContraction_randomGraph_checkStatistics() : void in class com.graphhopper.routing.ch.EdgeBasedNodeContractorTest	From	To
Rename Attribute	4
Rename Attribute weighting : Weighting to turnWeighting : TurnWeighting in class com.graphhopper.routing.ch.WitnessPathFinder	From	To
Rename Attribute turnWeighting : TurnWeighting to weighting : Weighting in class com.graphhopper.routing.ch.LegacyWitnessPathFinder	From	To
Rename Attribute numEntriesPolled : int to numPolledEdges : int in class com.graphhopper.routing.ch.WitnessPathFinder	From	To
Rename Attribute numPolledEdges : int to numEntriesPolled : int in class com.graphhopper.routing.ch.LegacyWitnessPathFinder	From	To
Change Attribute Type	4
Change Attribute Type graph : GraphHopperStorage to graph : CHGraph in class com.graphhopper.routing.ch.LegacyWitnessPathFinder	From	To
Change Attribute Type weighting : Weighting to turnWeighting : TurnWeighting in class com.graphhopper.routing.ch.WitnessPathFinder	From	To
Change Attribute Type turnWeighting : TurnWeighting to weighting : Weighting in class com.graphhopper.routing.ch.LegacyWitnessPathFinder	From	To
Change Attribute Type graph : CHGraph to graph : GraphHopperStorage in class com.graphhopper.routing.ch.WitnessPathFinder	From	To
Rename Parameter	4
Rename Parameter witnessPathFinder : WitnessPathFinder to legacyWitnessPathFinder : LegacyWitnessPathFinder in method private alternativeWitnessExistsOrNotNeeded(node int, outgoingEdge EdgeIteratorState, toNode int, legacyWitnessPathFinder LegacyWitnessPathFinder, originalPath CHEntry) : boolean in class com.graphhopper.routing.ch.EdgeBasedNodeContractor.TurnReplacementSearch	From	To
Rename Parameter witnessPathFinder : WitnessPathFinder to legacyWitnessPathFinder : LegacyWitnessPathFinder in method public shortcutRequired(node int, toNode int, outgoingEdge EdgeIteratorState, legacyWitnessPathFinder LegacyWitnessPathFinder, entry WitnessSearchEntry) : boolean in class com.graphhopper.routing.ch.EdgeBasedNodeContractor.WitnessSearchStrategy	From	To
Rename Parameter witnessPathFinder : WitnessPathFinder to legacyWitnessPathFinder : LegacyWitnessPathFinder in method public shortcutRequired(node int, toNode int, outgoingEdges EdgeIteratorState, legacyWitnessPathFinder LegacyWitnessPathFinder, entry WitnessSearchEntry) : boolean in class com.graphhopper.routing.ch.EdgeBasedNodeContractor.SimpleSearch	From	To
Rename Parameter witnessPathFinder : WitnessPathFinder to legacyWitnessPathFinder : LegacyWitnessPathFinder in method public shortcutRequired(node int, toNode int, outgoingEdge EdgeIteratorState, legacyWitnessPathFinder LegacyWitnessPathFinder, originalPath WitnessSearchEntry) : boolean in class com.graphhopper.routing.ch.EdgeBasedNodeContractor.TurnReplacementSearch	From	To

264339c14a92e24b7e88bf3d0fb4cccc34470b47

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: