graphhopper 26a1acff08f3e28a77125171592224e45dcea182

26a1acff08f3e28a77125171592224e45dcea182

Files Diff

Added: 3
Removed: 0
Renamed: 0
Modified: 23

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Pull Up Method	12
Pull Up Method protected initCollections(size int) : void from class com.graphhopper.routing.DijkstraBidirectionEdgeCHNoSOD to protected initCollections(size int) : void from class com.graphhopper.routing.AbstractBidirectionEdgeCHNoSOD	From	To
Pull Up Method public calcPath(from int, to int) : Path from class com.graphhopper.routing.DijkstraBidirectionEdgeCHNoSOD to public calcPath(from int, to int) : Path from class com.graphhopper.routing.AbstractBidirectionEdgeCHNoSOD	From	To
Pull Up Method protected getOrigEdgeId(edge EdgeIteratorState, reverse boolean) : int from class com.graphhopper.routing.DijkstraBidirectionEdgeCHNoSOD to protected getOrigEdgeId(edge EdgeIteratorState, reverse boolean) : int from class com.graphhopper.routing.AbstractBidirectionEdgeCHNoSOD	From	To
Pull Up Method protected accept(edge EdgeIteratorState, currEdge CHEntry, reverse boolean) : boolean from class com.graphhopper.routing.DijkstraBidirectionEdgeCHNoSOD to protected accept(edge EdgeIteratorState, currEdge CHEntry, reverse boolean) : boolean from class com.graphhopper.routing.AbstractBidirectionEdgeCHNoSOD	From	To
Pull Up Method public finished() : boolean from class com.graphhopper.routing.DijkstraBidirectionEdgeCHNoSOD to public finished() : boolean from class com.graphhopper.routing.AbstractBidirectionEdgeCHNoSOD	From	To
Pull Up Method public initTo(to int, weight double) : void from class com.graphhopper.routing.DijkstraBidirectionEdgeCHNoSOD to public initTo(to int, weight double) : void from class com.graphhopper.routing.AbstractBidirectionEdgeCHNoSOD	From	To
Pull Up Method public initFrom(from int, weight double) : void from class com.graphhopper.routing.DijkstraBidirectionEdgeCHNoSOD to public initFrom(from int, weight double) : void from class com.graphhopper.routing.AbstractBidirectionEdgeCHNoSOD	From	To
Pull Up Method protected createAndInitPath() : Path from class com.graphhopper.routing.DijkstraBidirectionEdgeCHNoSOD to protected createAndInitPath() : Path from class com.graphhopper.routing.AbstractBidirectionEdgeCHNoSOD	From	To
Pull Up Method protected calcWeight(edge EdgeIteratorState, currEdge CHEntry, reverse boolean) : double from class com.graphhopper.routing.DijkstraBidirectionEdgeCHNoSOD to protected calcWeight(edge EdgeIteratorState, currEdge CHEntry, reverse boolean) : double from class com.graphhopper.routing.AbstractBidirectionEdgeCHNoSOD	From	To
Pull Up Method private setFinished() : void from class com.graphhopper.routing.DijkstraBidirectionEdgeCHNoSOD to private setFinished() : void from class com.graphhopper.routing.AbstractBidirectionEdgeCHNoSOD	From	To
Pull Up Method public toString() : String from class com.graphhopper.routing.DijkstraBidirectionEdgeCHNoSOD to public toString() : String from class com.graphhopper.routing.AbstractBidirectionEdgeCHNoSOD	From	To
Pull Up Method protected getTraversalId(edge EdgeIteratorState, origEdgeId int, reverse boolean) : int from class com.graphhopper.routing.DijkstraBidirectionEdgeCHNoSOD to protected getTraversalId(edge EdgeIteratorState, origEdgeId int, reverse boolean) : int from class com.graphhopper.routing.AbstractBidirectionEdgeCHNoSOD	From	To
Move Method	1
Move Method protected updateBestPath(edgeState EdgeIteratorState, entryCurrent SPTEntry, traversalId int) : void from class com.graphhopper.routing.DijkstraBidirectionEdgeCHNoSOD to protected updateBestPath(edgeState EdgeIteratorState, entry T, traversalId int, reverse boolean) : void from class com.graphhopper.routing.AbstractBidirectionEdgeCHNoSOD	From	To
Rename Variable	1
Rename Variable decorator : CHAlgoFactoryDecorator to chDecorator : CHAlgoFactoryDecorator in method private testPerformanceAutomaticNodeOrdering(args String[]) : void in class com.graphhopper.tools.CHMeasurement	From	To
Pull Up Attribute	4
Pull Up Attribute private innerOutExplorer : EdgeExplorer from class com.graphhopper.routing.DijkstraBidirectionEdgeCHNoSOD to private innerOutExplorer : EdgeExplorer from class com.graphhopper.routing.AbstractBidirectionEdgeCHNoSOD	From	To
Pull Up Attribute private to : int from class com.graphhopper.routing.DijkstraBidirectionEdgeCHNoSOD to private to : int from class com.graphhopper.routing.AbstractBidirectionEdgeCHNoSOD	From	To
Pull Up Attribute private innerInExplorer : EdgeExplorer from class com.graphhopper.routing.DijkstraBidirectionEdgeCHNoSOD to private innerInExplorer : EdgeExplorer from class com.graphhopper.routing.AbstractBidirectionEdgeCHNoSOD	From	To
Pull Up Attribute private from : int from class com.graphhopper.routing.DijkstraBidirectionEdgeCHNoSOD to private from : int from class com.graphhopper.routing.AbstractBidirectionEdgeCHNoSOD	From	To
Change Return Type	1
Change Return Type DijkstraBidirectionEdgeCHNoSOD to AbstractBidirectionEdgeCHNoSOD in method private createAlgo(traversalMode TraversalMode) : AbstractBidirectionEdgeCHNoSOD in class com.graphhopper.routing.CHQueryWithTurnCostsTest	From	To
Extract Superclass	1
Extract Superclass com.graphhopper.routing.AbstractBidirectionEdgeCHNoSOD from classes [com.graphhopper.routing.DijkstraBidirectionEdgeCHNoSOD]	From	To
Change Variable Type	1
Change Variable Type algo : DijkstraBidirectionEdgeCHNoSOD to algo : AbstractBidirectionEdgeCHNoSOD in method private testPathCalculation(from int, to int, expectedWeight int, expectedNodes IntArrayList, traversalMode TraversalMode) : void in class com.graphhopper.routing.CHQueryWithTurnCostsTest	From	To
Extract Method	6
Extract Method private createAlgoNodeBased(graph Graph, opts AlgorithmOptions) : AbstractBidirAlgo extracted from public createAlgo(graph Graph, opts AlgorithmOptions) : RoutingAlgorithm in class com.graphhopper.routing.ch.PrepareContractionHierarchies	From	To
Extract Method private runCompareTest(algo String, graphHopper GraphHopper, withTurnCosts boolean, seed long, iterations int) : void extracted from private testPerformanceAutomaticNodeOrdering(args String[]) : void in class com.graphhopper.tools.CHMeasurement	From	To
Extract Method private runPerformanceTest(algo String, graphHopper GraphHopper, withTurnCosts boolean, seed long, iterations int) : void extracted from private testPerformanceAutomaticNodeOrdering(args String[]) : void in class com.graphhopper.tools.CHMeasurement	From	To
Extract Method package init(from int, fromWeight double, to int, toWeight double) : void extracted from public calcPath(from int, to int) : Path in class com.graphhopper.routing.AbstractBidirAlgo	From	To
Extract Method private doCreateAlgo(graph Graph, opts AlgorithmOptions) : AbstractBidirAlgo extracted from public createAlgo(graph Graph, opts AlgorithmOptions) : RoutingAlgorithm in class com.graphhopper.routing.ch.PrepareContractionHierarchies	From	To
Extract Method private createAlgoEdgeBased(graph Graph, opts AlgorithmOptions) : AbstractBidirAlgo extracted from public createAlgo(graph Graph, opts AlgorithmOptions) : RoutingAlgorithm in class com.graphhopper.routing.ch.PrepareContractionHierarchies	From	To
Extract And Move Method	2
Extract And Move Method package init(from int, fromWeight double, to int, toWeight double) : void extracted from public searchBest(to int, from int) : Path in class com.graphhopper.routing.AlternativeRoute.AlternativeBidirSearch & moved to class com.graphhopper.routing.AbstractBidirAlgo	From	To
Extract And Move Method package init(from int, fromWeight double, to int, toWeight double) : void extracted from public testInitFromAndTo() : void in class com.graphhopper.routing.AStarBidirectionTest & moved to class com.graphhopper.routing.AbstractBidirAlgo	From	To
Rename Parameter	7
Rename Parameter currLoc : int to traversalId : int in method public updateBestPath(es EdgeIteratorState, entry SPTEntry, traversalId int, reverse boolean) : void in class com.graphhopper.ui.DebugDijkstraBidirection	From	To
Rename Parameter currLoc : int to traversalId : int in method public updateBestPath(edgeState EdgeIteratorState, entry AStar.AStarEntry, traversalId int, reverse boolean) : void in class com.graphhopper.ui.DebugAStarBi	From	To
Rename Parameter entryCurrent : AStar.AStarEntry to entry : AStar.AStarEntry in method public updateBestPath(edgeState EdgeIteratorState, entry AStar.AStarEntry, traversalId int, reverse boolean) : void in class com.graphhopper.ui.DebugAStarBi	From	To
Rename Parameter bestEE : SPTEntry to entry : SPTEntry in method public updateBestPath(es EdgeIteratorState, entry SPTEntry, traversalId int, reverse boolean) : void in class com.graphhopper.ui.DebugDijkstraBidirection	From	To
Rename Parameter currLoc : int to traversalId : int in method public updateBestPath(edgeState EdgeIteratorState, entry AStarEntry, traversalId int, reverse boolean) : void in class com.graphhopper.routing.AStarBidirection	From	To
Rename Parameter entryCurrent : AStarEntry to entry : AStarEntry in method public updateBestPath(edgeState EdgeIteratorState, entry AStarEntry, traversalId int, reverse boolean) : void in class com.graphhopper.routing.AStarBidirection	From	To
Rename Parameter entryCurrent : SPTEntry to entry : SPTEntry in method protected updateBestPath(edgeState EdgeIteratorState, entry SPTEntry, traversalId int, reverse boolean) : void in class com.graphhopper.routing.DijkstraBidirectionRef	From	To

26a1acff08f3e28a77125171592224e45dcea182

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: