graphhopper d3381bebedae15c360e1b5cadc0a9e4644de5950

d3381bebedae15c360e1b5cadc0a9e4644de5950

Files Diff

Added: 4
Removed: 1
Renamed: 0
Modified: 11

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Extract Subclass	1
Extract Subclass com.graphhopper.routing.ch.AbstractNodeContractor from class com.graphhopper.routing.ch.NodeContractor	From	To
Change Parameter Type	3
Change Parameter Type value : int to value : float in method public update(key int, oldValue float, value float) : void in class com.graphhopper.coll.GHTreeMapComposed	From	To
Change Parameter Type value : int to value : float in method public insert(key int, value float) : void in class com.graphhopper.coll.GHTreeMapComposed	From	To
Change Parameter Type oldValue : int to oldValue : float in method public update(key int, oldValue float, value float) : void in class com.graphhopper.coll.GHTreeMapComposed	From	To
Move Method	7
Move Method private findShortcuts(sch ShortcutHandler) : long from class com.graphhopper.routing.ch.NodeContractor to private findShortcuts(sch ShortcutHandler) : long from class com.graphhopper.routing.ch.NodeBasedNodeContractor	From	To
Move Method private addShortcuts(shortcuts Collection<Shortcut>) : int from class com.graphhopper.routing.ch.NodeContractor to private addShortcuts(shortcuts Collection<Shortcut>) : int from class com.graphhopper.routing.ch.NodeBasedNodeContractor	From	To
Move Method package calcShortcutCount(node int) : CalcShortcutsResult from class com.graphhopper.routing.ch.NodeContractor to private calcShortcutCount(node int) : CalcShortcutsResult from class com.graphhopper.routing.ch.NodeBasedNodeContractor	From	To
Move Method package getDijkstraCount() : long from class com.graphhopper.routing.ch.NodeContractor to public getDijkstraCount() : long from class com.graphhopper.routing.ch.NodeBasedNodeContractor	From	To
Move Method private getMaxVisitedNodesEstimate() : int from class com.graphhopper.routing.ch.PrepareContractionHierarchies to private getMaxVisitedNodesEstimate() : int from class com.graphhopper.routing.ch.NodeBasedNodeContractor	From	To
Move Method package getDijkstraSeconds() : float from class com.graphhopper.routing.ch.NodeContractor to public getDijkstraSeconds() : float from class com.graphhopper.routing.ch.NodeBasedNodeContractor	From	To
Move Method private getCoords(edge EdgeIteratorState, graph Graph) : String from class com.graphhopper.routing.ch.NodeContractor to private getCoords(edge EdgeIteratorState, graph Graph) : String from class com.graphhopper.routing.ch.NodeBasedNodeContractor	From	To
Push Down Attribute	5
Push Down Attribute private maxLevel : int from class com.graphhopper.routing.ch.NodeContractor to package maxLevel : int from class com.graphhopper.routing.ch.AbstractNodeContractor	From	To
Push Down Attribute private originalEdges : DataAccess from class com.graphhopper.routing.ch.NodeContractor to private originalEdges : DataAccess from class com.graphhopper.routing.ch.AbstractNodeContractor	From	To
Push Down Attribute private ghStorage : GraphHopperStorage from class com.graphhopper.routing.ch.NodeContractor to private ghStorage : GraphHopperStorage from class com.graphhopper.routing.ch.AbstractNodeContractor	From	To
Push Down Attribute private maxEdgesCount : int from class com.graphhopper.routing.ch.NodeContractor to private maxEdgesCount : int from class com.graphhopper.routing.ch.AbstractNodeContractor	From	To
Push Down Attribute private prepareGraph : CHGraph from class com.graphhopper.routing.ch.NodeContractor to package prepareGraph : CHGraph from class com.graphhopper.routing.ch.AbstractNodeContractor	From	To
Move Attribute	10
Move Attribute private addScHandler : AddShortcutHandler from class com.graphhopper.routing.ch.NodeContractor to private addScHandler : AddShortcutHandler from class com.graphhopper.routing.ch.NodeBasedNodeContractor	From	To
Move Attribute private ignoreNodeFilter : IgnoreNodeFilter from class com.graphhopper.routing.ch.NodeContractor to private ignoreNodeFilter : IgnoreNodeFilter from class com.graphhopper.routing.ch.NodeBasedNodeContractor	From	To
Move Attribute private prepareWeighting : PreparationWeighting from class com.graphhopper.routing.ch.NodeContractor to private prepareWeighting : PreparationWeighting from class com.graphhopper.routing.ch.NodeBasedNodeContractor	From	To
Move Attribute private prepareAlgo : DijkstraOneToMany from class com.graphhopper.routing.ch.NodeContractor to private prepareAlgo : DijkstraOneToMany from class com.graphhopper.routing.ch.NodeBasedNodeContractor	From	To
Move Attribute private dijkstraCount : long from class com.graphhopper.routing.ch.NodeContractor to private dijkstraCount : long from class com.graphhopper.routing.ch.NodeBasedNodeContractor	From	To
Move Attribute private shortcuts : Map<Shortcut,Shortcut> from class com.graphhopper.routing.ch.NodeContractor to private shortcuts : Map<Shortcut,Shortcut> from class com.graphhopper.routing.ch.NodeBasedNodeContractor	From	To
Move Attribute private calcScHandler : CalcShortcutHandler from class com.graphhopper.routing.ch.NodeContractor to private calcScHandler : CalcShortcutHandler from class com.graphhopper.routing.ch.NodeBasedNodeContractor	From	To
Move Attribute private addedShortcutsCount : int from class com.graphhopper.routing.ch.NodeContractor to private addedShortcutsCount : int from class com.graphhopper.routing.ch.NodeBasedNodeContractor	From	To
Move Attribute private meanDegree : double from class com.graphhopper.routing.ch.PrepareContractionHierarchies to private meanDegree : double from class com.graphhopper.routing.ch.NodeBasedNodeContractor	From	To
Move Attribute private dijkstraSW : StopWatch from class com.graphhopper.routing.ch.NodeContractor to private dijkstraSW : StopWatch from class com.graphhopper.routing.ch.NodeBasedNodeContractor	From	To
Extract Class	1
Extract Class com.graphhopper.routing.ch.NodeBasedNodeContractor from class com.graphhopper.routing.ch.NodeContractor	From	To
Rename Class	1
Rename Class com.graphhopper.routing.ch.NodeContractorTest renamed to com.graphhopper.routing.ch.NodeBasedNodeContractorTest	From	To
Move Class	1
Move Class com.graphhopper.routing.ch.NodeContractor.IgnoreNodeFilter moved to com.graphhopper.routing.util.IgnoreNodeFilter	From	To
Change Variable Type	9
Change Variable Type oldPrio : int to oldPrio : float in method private contractNodes() : void in class com.graphhopper.routing.ch.PrepareContractionHierarchies	From	To
Change Variable Type singleThreadShortcutCount : Integer to singleThreadShortcutCount : Long in method public testMultipleCHPreparationsInParallel() : void in class com.graphhopper.reader.osm.GraphHopperOSMTest	From	To
Change Variable Type counter : long to checkCounter : int in method private contractNodes() : void in class com.graphhopper.routing.ch.PrepareContractionHierarchies	From	To
Change Variable Type numShortcuts : int to numShortcuts : long in method public testDirectedGraph2() : void in class com.graphhopper.routing.ch.PrepareContractionHierarchiesTest	From	To
Change Variable Type shortcutCountMap : HashMap<String,Integer> to shortcutCountMap : HashMap<String,Long> in method public testMultipleCHPreparationsInParallel() : void in class com.graphhopper.reader.osm.GraphHopperOSMTest	From	To
Change Variable Type priority : int to priority : float in method private prepareNodes() : boolean in class com.graphhopper.routing.ch.PrepareContractionHierarchies	From	To
Change Variable Type priority : int to priority : float in method private contractNodes() : void in class com.graphhopper.routing.ch.PrepareContractionHierarchies	From	To
Inline Variable	1
Inline Variable len : int in method private contractNodes() : void from class com.graphhopper.routing.ch.PrepareContractionHierarchies	From	To
Extract Method	1
Extract Method private doCreateAlgo(graph Graph, opts AlgorithmOptions) : AbstractBidirAlgo extracted from public createAlgo(graph Graph, opts AlgorithmOptions) : RoutingAlgorithm in class com.graphhopper.routing.ch.PrepareContractionHierarchies	From	To
Rename Method	1
Rename Method public getTime() : long renamed to public getMillis() : long in class com.graphhopper.util.StopWatch	From	To
Push Down Method	6
Push Down Method package NodeContractor(dir Directory, ghStorage GraphHopperStorage, prepareGraph CHGraph, weighting Weighting, traversalMode TraversalMode) from class com.graphhopper.routing.ch.NodeContractor to public AbstractNodeContractor(dir Directory, ghStorage GraphHopperStorage, prepareGraph CHGraph, weighting Weighting) from class com.graphhopper.routing.ch.AbstractNodeContractor	From	To
Push Down Method private setOrigEdgeCount(edgeId int, value int) : void from class com.graphhopper.routing.ch.NodeContractor to package setOrigEdgeCount(edgeId int, value int) : void from class com.graphhopper.routing.ch.AbstractNodeContractor	From	To
Push Down Method package contractNode(node int) : long from class com.graphhopper.routing.ch.NodeContractor to public contractNode(node int) : void from class com.graphhopper.routing.ch.NodeBasedNodeContractor	From	To
Push Down Method package close() : void from class com.graphhopper.routing.ch.NodeContractor to public close() : void from class com.graphhopper.routing.ch.AbstractNodeContractor	From	To
Push Down Method private getOrigEdgeCount(edgeId int) : int from class com.graphhopper.routing.ch.NodeContractor to package getOrigEdgeCount(edgeId int) : int from class com.graphhopper.routing.ch.AbstractNodeContractor	From	To
Push Down Method package initFromGraph() : void from class com.graphhopper.routing.ch.NodeContractor to public initFromGraph() : void from class com.graphhopper.routing.ch.AbstractNodeContractor	From	To
Change Return Type	4
Change Return Type int to long in method public getShortcuts() : long in class com.graphhopper.routing.ch.PrepareContractionHierarchies	From	To
Change Return Type int to float in method public peekValue() : float in class com.graphhopper.coll.GHTreeMapComposed	From	To
Change Return Type long to void in method public contractNode(node int) : void in class com.graphhopper.routing.ch.NodeBasedNodeContractor	From	To
Change Return Type int to float in method private calculatePriority(node int) : float in class com.graphhopper.routing.ch.PrepareContractionHierarchies	From	To
Replace Variable With Attribute	4
Replace Variable With Attribute periodSW : StopWatch to periodicUpdateSW : StopWatch in method private contractNodes() : void in class com.graphhopper.routing.ch.PrepareContractionHierarchies	From	To
Replace Variable With Attribute neighborSW : StopWatch to contractionSW : StopWatch in method private contractNodes() : void in class com.graphhopper.routing.ch.PrepareContractionHierarchies	From	To
Replace Variable With Attribute lazySW : StopWatch to lazyUpdateSW : StopWatch in method private contractNodes() : void in class com.graphhopper.routing.ch.PrepareContractionHierarchies	From	To
Replace Variable With Attribute counter : long to checkCounter : int in method private contractNodes() : void in class com.graphhopper.routing.ch.PrepareContractionHierarchies	From	To
Rename Attribute	1
Rename Attribute nanoTime : long to elapsedNanos : long in class com.graphhopper.util.StopWatch	From	To
Change Attribute Type	1
Change Attribute Type oldPriorities : int[] to oldPriorities : float[] in class com.graphhopper.routing.ch.PrepareContractionHierarchies	From	To

d3381bebedae15c360e1b5cadc0a9e4644de5950

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: