2fe82f5fa68de7f6b96f64e91011e451998f2389
Files Diff
- Added: 4
- Removed: 2
- Renamed: 0
- Modified: 9
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method private preparePermissions(all ListMultimap<String,String>, permissions Set<String>) : void from class org.graylog2.shared.security.RestPermissions to private buildPermissionsMap(permissions Set<String>) : Map<String,Collection<String>> from class org.graylog2.shared.security.Permissions | From | To | |
| Change Parameter Type | 4 | ||
| Change Parameter Type permissions : RestPermissions to permissions : Permissions in method public UserServiceImpl(mongoConnection MongoConnection, configuration Configuration, roleService RoleService, userFactory UserImpl.Factory, permissions Permissions, inMemoryRolePermissionResolver InMemoryRolePermissionResolver) in class org.graylog2.users.UserServiceImpl | From | To | |
| Change Parameter Type permissions : RestPermissions to permissions : Permissions in method protected RoleServiceImpl(mongoConnection MongoConnection, mapper MongoJackObjectMapperProvider, permissions Permissions, validator Validator) in class org.graylog2.users.RoleServiceImpl | From | To | |
| Change Parameter Type permissions : RestPermissions to permissions : Permissions in method public UserPermissionMigrationPeriodical(userService UserService, roleService RoleService, permissions Permissions, clusterConfigService ClusterConfigService) in class org.graylog2.periodical.UserPermissionMigrationPeriodical | From | To | |
| Change Parameter Type permissions : RestPermissions to permissions : Permissions in method public PermissionsResource(permissions Permissions) in class org.graylog2.rest.resources.system.PermissionsResource | From | To | |
| Move Method | 3 | ||
| Move Method public userSelfEditPermissions(username String) : Set<String> from class org.graylog2.shared.security.RestPermissions to public userSelfEditPermissions(username String) : Set<String> from class org.graylog2.shared.security.Permissions | From | To | |
| Move Method public readerPermissions(username String) : Set<String> from class org.graylog2.shared.security.RestPermissions to public readerPermissions(username String) : Set<String> from class org.graylog2.shared.security.Permissions | From | To | |
| Move Method private perInstance(permission String, instance String) : String from class org.graylog2.shared.security.RestPermissions to private perInstance(permission String, instance String) : String from class org.graylog2.shared.security.Permissions | From | To | |
| Change Return Type | 4 | ||
| Change Return Type Set<String> to Set<Permission> in method public readerBasePermissions() : Set<Permission> in class org.graylog2.shared.security.RestPermissions | From | To | |
| Change Return Type void to Map<String,Collection<String>> in method private buildPermissionsMap(permissions Set<String>) : Map<String,Collection<String>> in class org.graylog2.shared.security.Permissions | From | To | |
| Change Return Type RestPermission to Permission in method public create(permission String, description String) : Permission in class org.graylog2.plugin.security.Permission | From | To | |
| Change Return Type Set<RestPermission> to Set<Permission> in method public permissions() : Set<Permission> in class org.graylog2.plugin.security.PluginPermissions | From | To | |
| Extract Class | 1 | ||
| Extract Class org.graylog2.shared.security.Permissions from class org.graylog2.shared.security.RestPermissions | From | To | |
| Rename Class | 2 | ||
| Rename Class org.graylog2.shared.security.RestPermissionsTest renamed to org.graylog2.shared.security.PermissionsTest | From | To | |
| Rename Class org.graylog2.plugin.security.RestPermission renamed to org.graylog2.plugin.security.Permission | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type permissions : RestPermissions to permissions : Permissions in method public testPluginPermissions() : void in class org.graylog2.shared.security.PermissionsTest | From | To | |
| Change Attribute Type | 5 | ||
| Change Attribute Type permissions : RestPermissions to permissions : Permissions in class org.graylog2.users.UserServiceImpl | From | To | |
| Change Attribute Type permissions : RestPermissions to permissions : Permissions in class org.graylog2.rest.resources.system.PermissionsResource | From | To | |
| Change Attribute Type readerBasePermissions : Set<String> to readerBasePermissions : Set<Permission> in class org.graylog2.shared.security.RestPermissions | From | To | |
| Change Attribute Type permissions : RestPermissions to permissions : Permissions in class org.graylog2.shared.security.PermissionsTest | From | To | |
| Change Attribute Type permissions : RestPermissions to permissions : Permissions in class org.graylog2.periodical.UserPermissionMigrationPeriodical | From | To |