68271beb2b5d648e3f7cd3f843bf98d0a55dae1a
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 2
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method protected decode(channelHandlerContext ChannelHandlerContext, channel Channel, channelBuffer ChannelBuffer) : Object renamed to private processUncompressedBuffer(channel Channel, buffer ChannelBuffer) : ChannelBuffer[] in class org.graylog.plugins.beats.BeatsFrameDecoder | From | To | |
| Rename Variable | 3 | ||
| Rename Variable resultBuffers : Iterable<ChannelBuffer> to output : ChannelBuffer[] in method public decodeJsonFrame() : void in class org.graylog.plugins.beats.BeatsFrameDecoderTest | From | To | |
| Rename Variable resultBuffers : Iterable<ChannelBuffer> to output : ChannelBuffer[] in method public decodeCompressedFrame() : void in class org.graylog.plugins.beats.BeatsFrameDecoderTest | From | To | |
| Rename Variable resultBuffers : Iterable<ChannelBuffer> to output : ChannelBuffer[] in method public decodeDataFrame() : void in class org.graylog.plugins.beats.BeatsFrameDecoderTest | From | To | |
| Inline Method | 1 | ||
| Inline Method private processBuffer(channel Channel, channelBuffer ChannelBuffer) : Iterable<ChannelBuffer> inlined to private processUncompressedBuffer(channel Channel, buffer ChannelBuffer) : ChannelBuffer[] in class org.graylog.plugins.beats.BeatsFrameDecoder | From | To | |
| Change Return Type | 5 | ||
| Change Return Type ChannelBuffer to ChannelBuffer[] in method private parseJsonFrame(channel Channel, channelBuffer ChannelBuffer) : ChannelBuffer[] in class org.graylog.plugins.beats.BeatsFrameDecoder | From | To | |
| Change Return Type Object to ChannelBuffer[] in method private processUncompressedBuffer(channel Channel, buffer ChannelBuffer) : ChannelBuffer[] in class org.graylog.plugins.beats.BeatsFrameDecoder | From | To | |
| Change Return Type ChannelBuffer to ChannelBuffer[] in method private parseDataFrame(channel Channel, channelBuffer ChannelBuffer) : ChannelBuffer[] in class org.graylog.plugins.beats.BeatsFrameDecoder | From | To | |
| Change Return Type Iterable<ChannelBuffer> to ChannelBuffer[] in method private processCompressedFrame(channel Channel, channelBuffer ChannelBuffer) : ChannelBuffer[] in class org.graylog.plugins.beats.BeatsFrameDecoder | From | To | |
| Change Return Type Iterable<ChannelBuffer> to ChannelBuffer[] in method private processCompressedDataFrames(channel Channel, channelBuffer ChannelBuffer) : ChannelBuffer[] in class org.graylog.plugins.beats.BeatsFrameDecoder | From | To | |
| Parameterize Variable | 3 | ||
| Parameterize Variable replyBuffer : ChannelBuffer to buffer : ChannelBuffer in method private extractSequenceNumber(buffer ChannelBuffer) : long in class org.graylog.plugins.beats.BeatsFrameDecoderTest | From | To | |
| Change Variable Type | 4 | ||
| Change Variable Type resultBuffers : Iterable<ChannelBuffer> to output : ChannelBuffer[] in method public decodeJsonFrame() : void in class org.graylog.plugins.beats.BeatsFrameDecoderTest | From | To | |
| Change Variable Type events : Iterable<ChannelBuffer> to events : ChannelBuffer[] in method private processUncompressedBuffer(channel Channel, buffer ChannelBuffer) : ChannelBuffer[] in class org.graylog.plugins.beats.BeatsFrameDecoder | From | To | |
| Change Variable Type resultBuffers : Iterable<ChannelBuffer> to output : ChannelBuffer[] in method public decodeCompressedFrame() : void in class org.graylog.plugins.beats.BeatsFrameDecoderTest | From | To | |
| Change Variable Type resultBuffers : Iterable<ChannelBuffer> to output : ChannelBuffer[] in method public decodeDataFrame() : void in class org.graylog.plugins.beats.BeatsFrameDecoderTest | From | To | |
| Extract Method | 8 | ||
| Extract Method private extractSequenceNumber(buffer ChannelBuffer) : long extracted from public decodeCompressedFrame() : void in class org.graylog.plugins.beats.BeatsFrameDecoderTest | From | To | |
| Extract Method private buildDataFrame(data Map<String,String>, sequenceNum int) : ChannelBuffer extracted from public decodeDataFrame() : void in class org.graylog.plugins.beats.BeatsFrameDecoderTest | From | To | |
| Extract Method private buildCompressedFrame(payload byte[], compressionLevel int) : ChannelBuffer extracted from public decodeCompressedFrame() : void in class org.graylog.plugins.beats.BeatsFrameDecoderTest | From | To | |
| Extract Method private buildJsonFrame(jsonBytes byte[], sequenceNum int) : ChannelBuffer extracted from public decodeCompressedFrame() : void in class org.graylog.plugins.beats.BeatsFrameDecoderTest | From | To | |
| Extract Method private extractSequenceNumber(buffer ChannelBuffer) : long extracted from public decodeDataFrame() : void in class org.graylog.plugins.beats.BeatsFrameDecoderTest | From | To | |
| Extract Method private buildWindowSizeFrame(windowSize int) : ChannelBuffer extracted from public decodeWindowSizeFrame() : void in class org.graylog.plugins.beats.BeatsFrameDecoderTest | From | To | |
| Extract Method private buildJsonFrame(jsonBytes byte[], sequenceNum int) : ChannelBuffer extracted from public decodeJsonFrame() : void in class org.graylog.plugins.beats.BeatsFrameDecoderTest | From | To | |
| Extract Method private extractSequenceNumber(buffer ChannelBuffer) : long extracted from public decodeJsonFrame() : void in class org.graylog.plugins.beats.BeatsFrameDecoderTest | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type channel : Channel to channel : DecoderEmbedder<Iterable<ChannelBuffer>> in class org.graylog.plugins.beats.BeatsFrameDecoderTest | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter channelBuffer : ChannelBuffer to buffer : ChannelBuffer in method private processUncompressedBuffer(channel Channel, buffer ChannelBuffer) : ChannelBuffer[] in class org.graylog.plugins.beats.BeatsFrameDecoder | From | To |