ac21a44af0f0814269ff1be5ab3c29d193fe467f
Files Diff
- Added: 2
- Removed: 1
- Renamed: 0
- Modified: 29
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method public buildEndpointUri(httpHeaders HttpHeaders, defaultEndpointUri URI) : String renamed to public buildExternalUri(httpHeaders MultivaluedMap<String,String>, defaultUri URI) : URI in class org.graylog2.rest.RestTools | From | To | |
| Rename Method public getNodeIdFile() : String renamed to public getHttpTlsKeyPassword() : String in class org.graylog2.configuration.HttpConfiguration | From | To | |
| Move And Rename Method | 3 | ||
| Move And Rename Method public validateRestTlsConfig() : void from class org.graylog2.plugin.BaseConfiguration to public validateTlsConfig() : void from class org.graylog2.configuration.HttpConfiguration | From | To | |
| Move And Rename Method public validateWebTlsConfig() : void from class org.graylog2.plugin.BaseConfiguration to public validateTlsConfig() : void from class org.graylog2.configuration.HttpConfiguration | From | To | |
| Move And Rename Method protected getDefaultRestTransportUri() : URI from class org.graylog2.plugin.BaseConfiguration to private getDefaultHttpUri(path String) : URI from class org.graylog2.configuration.HttpConfiguration | From | To | |
| Change Parameter Type | 6 | ||
| Change Parameter Type listenUri : URI to bindAddress : HostAndPort in method private shutdownHttpServer(httpServer HttpServer, bindAddress HostAndPort) : void in class org.graylog2.shared.initializers.JerseyService | From | To | |
| Change Parameter Type configuration : BaseConfiguration to httpConfiguration : HttpConfiguration in method public DocumentationResource(httpConfiguration HttpConfiguration, restControllerPackages String[], objectMapper ObjectMapper, pluginRestResourceClasses PluginRestResourceClasses) in class org.graylog2.shared.rest.resources.documentation.DocumentationResource | From | To | |
| Change Parameter Type configuration : Configuration to configuration : HttpConfiguration in method public JerseyService(configuration HttpConfiguration, dynamicFeatures Set<Class<? extends DynamicFeature>>, containerResponseFilters Set<Class<? extends ContainerResponseFilter>>, exceptionMappers Set<Class<? extends ExceptionMapper>>, additionalComponents Set<Class>, pluginRestResources Map<String,Set<Class<? extends PluginRestResource>>>, restControllerPackages String[], pluginAuditEventTypes Set<PluginAuditEventTypes>, objectMapper ObjectMapper, metricRegistry MetricRegistry, errorPageGenerator ErrorPageGenerator) in class org.graylog2.shared.initializers.JerseyService | From | To | |
| Change Parameter Type httpHeaders : HttpHeaders to httpHeaders : MultivaluedMap<String,String> in method public buildExternalUri(httpHeaders MultivaluedMap<String,String>, defaultUri URI) : URI in class org.graylog2.rest.RestTools | From | To | |
| Change Parameter Type configuration : Configuration to httpConfiguration : HttpConfiguration in method public NodePingThread(nodeService NodeService, notificationService NotificationService, activityWriter ActivityWriter, httpConfiguration HttpConfiguration, serverStatus ServerStatus) in class org.graylog2.periodical.NodePingThread | From | To | |
| Change Parameter Type configuration : Configuration to httpConfiguration : HttpConfiguration in method public DocumentationBrowserResource(mimeTypes MimetypesFileTypeMap, httpConfiguration HttpConfiguration, templateEngine Engine) in class org.graylog2.shared.rest.resources.documentation.DocumentationBrowserResource | From | To | |
| Move Method | 2 | ||
| Move Method public getUriScheme(enableTls boolean) : String from class org.graylog2.plugin.BaseConfiguration to public getUriScheme() : String from class org.graylog2.configuration.HttpConfiguration | From | To | |
| Move Method private isRegularFileAndReadable(path Path) : boolean from class org.graylog2.plugin.BaseConfiguration to private isRegularFileAndReadable(path Path) : boolean from class org.graylog2.configuration.HttpConfiguration | From | To | |
| Rename Variable | 4 | ||
| Rename Variable endpointUri : Optional<String> to externalUri : Optional<URI> in method public buildExternalUri(httpHeaders MultivaluedMap<String,String>, defaultUri URI) : URI in class org.graylog2.rest.RestTools | From | To | |
| Rename Variable restTransportUri : URI to httpPublishUri : URI in method protected getUriBuilderToSelf() : UriBuilder in class org.graylog2.shared.rest.resources.RestResource | From | To | |
| Rename Variable sslContext : SSLContextConfigurator to sslContextConfigurator : SSLContextConfigurator in method private buildSslEngineConfigurator(certFile Path, keyFile Path, keyPassword String) : SSLEngineConfigurator in class org.graylog2.shared.initializers.JerseyService | From | To | |
| Rename Variable restListenUri : URI to bindAddress : HostAndPort in method private startUpApi() : void in class org.graylog2.shared.initializers.JerseyService | From | To | |
| Change Return Type | 1 | ||
| Change Return Type String to URI in method public buildExternalUri(httpHeaders MultivaluedMap<String,String>, defaultUri URI) : URI in class org.graylog2.rest.RestTools | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class org.graylog2.plugin.BaseConfigurationTest.Configuration moved and renamed to org.graylog2.configuration.HttpConfiguration | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute configuration : Configuration to httpConfiguration : HttpConfiguration in class org.graylog2.periodical.NodePingThread | From | To | |
| Rename Attribute configuration : BaseConfiguration to httpConfiguration : HttpConfiguration in class org.graylog2.shared.rest.resources.documentation.DocumentationResource | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type restListenUri : URI to bindAddress : HostAndPort in method private startUpApi() : void in class org.graylog2.shared.initializers.JerseyService | From | To | |
| Change Variable Type endpointUri : Optional<String> to externalUri : Optional<URI> in method public buildExternalUri(httpHeaders MultivaluedMap<String,String>, defaultUri URI) : URI in class org.graylog2.rest.RestTools | From | To | |
| Change Attribute Type | 4 | ||
| Change Attribute Type configuration : BaseConfiguration to configuration : HttpConfiguration in class org.graylog2.shared.rest.resources.RestResource | From | To | |
| Change Attribute Type configuration : Configuration to configuration : HttpConfiguration in class org.graylog2.shared.initializers.JerseyService | From | To | |
| Change Attribute Type configuration : Configuration to httpConfiguration : HttpConfiguration in class org.graylog2.periodical.NodePingThread | From | To | |
| Change Attribute Type configuration : BaseConfiguration to httpConfiguration : HttpConfiguration in class org.graylog2.shared.rest.resources.documentation.DocumentationResource | From | To | |
| Rename Parameter | 7 | ||
| Rename Parameter configuration : Configuration to httpConfiguration : HttpConfiguration in method public NodePingThread(nodeService NodeService, notificationService NotificationService, activityWriter ActivityWriter, httpConfiguration HttpConfiguration, serverStatus ServerStatus) in class org.graylog2.periodical.NodePingThread | From | To | |
| Rename Parameter configuration : Configuration to httpConfiguration : HttpConfiguration in method public DocumentationBrowserResource(mimeTypes MimetypesFileTypeMap, httpConfiguration HttpConfiguration, templateEngine Engine) in class org.graylog2.shared.rest.resources.documentation.DocumentationBrowserResource | From | To | |
| Rename Parameter listenUri : URI to bindAddress : HostAndPort in method private shutdownHttpServer(httpServer HttpServer, bindAddress HostAndPort) : void in class org.graylog2.shared.initializers.JerseyService | From | To | |
| Rename Parameter configuration : BaseConfiguration to httpConfiguration : HttpConfiguration in method public DocumentationResource(httpConfiguration HttpConfiguration, restControllerPackages String[], objectMapper ObjectMapper, pluginRestResourceClasses PluginRestResourceClasses) in class org.graylog2.shared.rest.resources.documentation.DocumentationResource | From | To | |
| Rename Parameter restTransportUri : URI to httpPublishUri : URI in method public registerServer(nodeId String, isMaster boolean, httpPublishUri URI, hostname String) : String in class org.graylog2.cluster.NodeService | From | To | |
| Rename Parameter defaultEndpointUri : URI to defaultUri : URI in method public buildExternalUri(httpHeaders MultivaluedMap<String,String>, defaultUri URI) : URI in class org.graylog2.rest.RestTools | From | To | |
| Rename Parameter restTransportUri : URI to httpPublishUri : URI in method public registerServer(nodeId String, isMaster boolean, httpPublishUri URI, hostname String) : String in class org.graylog2.cluster.NodeServiceImpl | From | To |