gwt 779f8bf96ae1ff93ba8417d2cb40826a49f6234f

779f8bf96ae1ff93ba8417d2cb40826a49f6234f

Files Diff

Added: 2
Removed: 2
Renamed: 0
Modified: 56

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move And Rename Method	1
Move And Rename Method public testInstanceOf() : void from class com.google.gwt.dev.jjs.impl.TypeTightenerTest to public testInstanceOf_nullability() : void from class com.google.gwt.dev.jjs.impl.DeadCodeEliminationTest	From	To
Move And Inline Method	3
Move And Inline Method public getTypeNull() : JNullType moved from class com.google.gwt.dev.jjs.ast.JProgram to class com.google.gwt.dev.jjs.impl.Pruner & inlined to package primitiveTypeOrNullTypeOrArray(program JProgram, type JType) : JType	From	To
Move And Inline Method public visit(x JInterfaceType, ctx Context) : boolean moved from class com.google.gwt.dev.jjs.impl.ToStringGenerationVisitor to class com.google.gwt.dev.jjs.impl.SourceGenerationVisitor & inlined to public visit(x JInterfaceType, ctx Context) : boolean	From	To
Move And Inline Method public visit(x JInterfaceType, ctx Context) : boolean moved from class com.google.gwt.dev.jjs.impl.ToStringGenerationVisitor to class com.google.gwt.dev.jjs.impl.SourceGenerationVisitor & inlined to public visit(x JClassType, ctx Context) : boolean	From	To
Change Parameter Type	2
Change Parameter Type types : Collection<? extends JReferenceType> to types : Iterable<JReferenceType> in method public generalizeTypes(types Iterable<JReferenceType>) : JReferenceType in class com.google.gwt.dev.jjs.ast.JProgram	From	To
Change Parameter Type x : JClassType to x : JDeclaredType in method public visit(x JDeclaredType, ctx Context) : boolean in class com.google.gwt.dev.jjs.impl.ToStringGenerationVisitor	From	To
Move Method	1
Move Method private staticallyEvaluateInstanceOf(fromType JReferenceType, toType JReferenceType) : AnalysisResult from class com.google.gwt.dev.jjs.impl.TypeTightener to private staticallyEvaluateInstanceOf(fromType JReferenceType, toType JReferenceType) : AnalysisResult from class com.google.gwt.dev.jjs.impl.DeadCodeElimination.DeadCodeVisitor	From	To
Move And Rename Class	1
Move And Rename Class com.google.gwt.dev.jjs.ast.JNonNullType moved and renamed to com.google.gwt.dev.jjs.ast.JReferenceType.JAnalysisDecoratedType	From	To
Move Class	1
Move Class com.google.gwt.dev.jjs.impl.TypeTightener.AnalysisResult moved to com.google.gwt.dev.jjs.ast.JReferenceType.AnalysisResult	From	To
Merge Variable	2
Merge Variable [type2 : JReferenceType, classify2 : int, classify1 : int, type1 : JReferenceType] to thisType : JReferenceType in method private generalizeUnderlyingTypes(thisType JReferenceType, thatType JReferenceType) : JReferenceType in class com.google.gwt.dev.jjs.ast.JProgram	From	To
Merge Variable [type1 : JReferenceType, classify2 : int, type2 : JReferenceType] to thatType : JReferenceType in method private generalizeUnderlyingTypes(thisType JReferenceType, thatType JReferenceType) : JReferenceType in class com.google.gwt.dev.jjs.ast.JProgram	From	To
Extract Variable	2
Extract Variable rhsType : JType in method private staticallyEvaluateEq(lhs JExpression, rhs JExpression) : AnalysisResult from class com.google.gwt.dev.jjs.impl.DeadCodeElimination.DeadCodeVisitor	From	To
Extract Variable arrayInstance : JExpression in method public endVisit(x JBinaryOperation, ctx Context) : void from class com.google.gwt.dev.jjs.impl.ArrayNormalizer.ArrayVisitor	From	To
Change Variable Type	4
Change Variable Type typeList : List<JReferenceType> to assignedTypes : Collection<JReferenceType> in method private getAssignmentsIfValid(variable JVariable) : Collection<JReferenceType> in class com.google.gwt.dev.jjs.impl.TypeTightener.TightenTypesVisitor	From	To
Change Variable Type classify1 : int to interfaceType : JInterfaceType in method private generalizeUnderlyingTypes(thisType JReferenceType, thatType JReferenceType) : JReferenceType in class com.google.gwt.dev.jjs.ast.JProgram	From	To
Change Variable Type myAssignments : Collection<JExpression> to assignmentTypes : Collection<JReferenceType> in method private tighten(x JVariable) : void in class com.google.gwt.dev.jjs.impl.TypeTightener.TightenTypesVisitor	From	To
Change Variable Type it : Iterator<? extends JReferenceType> to it : Iterator<JReferenceType> in method public generalizeTypes(types Iterable<JReferenceType>) : JReferenceType in class com.google.gwt.dev.jjs.ast.JProgram	From	To
Inline Variable	7
Inline Variable class1 : JClassType in method private generalizeTypes(type1 JReferenceType, type2 JReferenceType) : JReferenceType from class com.google.gwt.dev.jjs.ast.JProgram	From	To
Inline Variable cType : JClassType in method public canTriviallyCast(type JReferenceType, qType JReferenceType) : boolean from class com.google.gwt.dev.jjs.ast.JTypeOracle	From	To
Inline Variable aType2 : JArrayType in method private generalizeTypes(type1 JReferenceType, type2 JReferenceType) : JReferenceType from class com.google.gwt.dev.jjs.ast.JProgram	From	To
Inline Variable iType : JInterfaceType in method public canTriviallyCast(type JReferenceType, qType JReferenceType) : boolean from class com.google.gwt.dev.jjs.ast.JTypeOracle	From	To
Inline Variable aType1 : JArrayType in method private generalizeTypes(type1 JReferenceType, type2 JReferenceType) : JReferenceType from class com.google.gwt.dev.jjs.ast.JProgram	From	To
Inline Variable class2 : JClassType in method private generalizeTypes(type1 JReferenceType, type2 JReferenceType) : JReferenceType from class com.google.gwt.dev.jjs.ast.JProgram	From	To
Inline Variable toType : JReferenceType in method public endVisit(x JInstanceOf, ctx Context) : void from class com.google.gwt.dev.jjs.impl.TypeTightener.TightenTypesVisitor	From	To
Extract Method	13
Extract Method package getAnalysisResult() : AnalysisResult extracted from public canBeNull() : boolean in class com.google.gwt.dev.jjs.ast.JReferenceType	From	To
Extract Method private generalizeArrayTypes(thisArrayType JArrayType, thatArrayType JArrayType) : JReferenceType extracted from private generalizeTypes(type1 JReferenceType, type2 JReferenceType) : JReferenceType in class com.google.gwt.dev.jjs.ast.JProgram	From	To
Extract Method private getAssignmentsIfValid(variable JVariable) : Collection<JReferenceType> extracted from private tighten(x JVariable) : void in class com.google.gwt.dev.jjs.impl.TypeTightener.TightenTypesVisitor	From	To
Extract Method private isArrayInterface(type JType) : boolean extracted from public canTriviallyCast(type JReferenceType, qType JReferenceType) : boolean in class com.google.gwt.dev.jjs.ast.JTypeOracle	From	To
Extract Method private isJavaLangObject(type JType) : boolean extracted from public canTriviallyCast(type JReferenceType, qType JReferenceType) : boolean in class com.google.gwt.dev.jjs.ast.JTypeOracle	From	To
Extract Method public castSucceedsTrivially(fromType JReferenceType, toType JReferenceType) : boolean extracted from public canTriviallyCast(type JReferenceType, qType JReferenceType) : boolean in class com.google.gwt.dev.jjs.ast.JTypeOracle	From	To
Extract Method package getAnalysisDecoratedTypePool() : AnalysisDecoratedTypePool extracted from private readResolve() : Object in class com.google.gwt.dev.jjs.ast.JReferenceType.JAnalysisDecoratedType	From	To
Extract Method public visit(x JType, ctx Context) : boolean extracted from public visit(x JClassType, ctx Context) : boolean in class com.google.gwt.dev.jjs.impl.ToStringGenerationVisitor	From	To
Extract Method private castSucceedsTrivially(fromType JClassType, toType JReferenceType) : boolean extracted from public canTriviallyCast(type JReferenceType, qType JReferenceType) : boolean in class com.google.gwt.dev.jjs.ast.JTypeOracle	From	To
Extract Method private isJavaLangObject(type JType) : boolean extracted from public canTheoreticallyCast(type JReferenceType, qType JReferenceType) : boolean in class com.google.gwt.dev.jjs.ast.JTypeOracle	From	To
Extract Method private generalizeClasses(thisClass JClassType, thatClass JClassType) : JReferenceType extracted from private generalizeTypes(type1 JReferenceType, type2 JReferenceType) : JReferenceType in class com.google.gwt.dev.jjs.ast.JProgram	From	To
Extract Method private generalizeInterfaces(thisInterface JInterfaceType, thatInterface JInterfaceType) : JReferenceType extracted from private generalizeTypes(type1 JReferenceType, type2 JReferenceType) : JReferenceType in class com.google.gwt.dev.jjs.ast.JProgram	From	To
Extract Method private generalizeUnderlyingTypes(thisType JReferenceType, thatType JReferenceType) : JReferenceType extracted from private generalizeTypes(type1 JReferenceType, type2 JReferenceType) : JReferenceType in class com.google.gwt.dev.jjs.ast.JProgram	From	To
Rename Method	6
Rename Method public canTheoreticallyCast(type JReferenceType, qType JReferenceType) : boolean renamed to public castFailsTrivially(fromType JReferenceType, toType JReferenceType) : boolean in class com.google.gwt.dev.jjs.ast.JTypeOracle	From	To
Rename Method public testCanTriviallyCast() : void renamed to public testCastFailsTrivially() : void in class com.google.gwt.dev.jjs.JjsTypeTest	From	To
Rename Method public canBeNull() : boolean renamed to package getAnalysisResult() : AnalysisResult in class com.google.gwt.dev.jjs.ast.JReferenceType.JAnalysisDecoratedType	From	To
Rename Method public canTriviallyCast(type JType, qType JType) : boolean renamed to public castSucceedsTrivially(fromType JType, toType JType) : boolean in class com.google.gwt.dev.jjs.ast.JTypeOracle	From	To
Rename Method public testCanTheoreticallyCast() : void renamed to public testCastSucceedsTrivially() : void in class com.google.gwt.dev.jjs.JjsTypeTest	From	To
Rename Method public canTriviallyCast(type JReferenceType, qType JReferenceType) : boolean renamed to private castSucceedsTrivially(fromArrayType JArrayType, toType JReferenceType) : boolean in class com.google.gwt.dev.jjs.ast.JTypeOracle	From	To
Pull Up Method	1
Pull Up Method public isAbstract() : boolean from class com.google.gwt.dev.jjs.ast.JNullType to public isNullType() : boolean from class com.google.gwt.dev.jjs.ast.JType	From	To
Rename Variable	25
Rename Variable leafType : JType to toLeafType : JType in method public castFailsTrivially(fromType JReferenceType, toType JReferenceType) : boolean in class com.google.gwt.dev.jjs.ast.JTypeOracle	From	To
Rename Variable qLeafType : JType to fromLeafType : JType in method public castFailsTrivially(fromType JReferenceType, toType JReferenceType) : boolean in class com.google.gwt.dev.jjs.ast.JTypeOracle	From	To
Rename Variable tGreater : JReferenceType to nonInterfaceType : JReferenceType in method private generalizeUnderlyingTypes(thisType JReferenceType, thatType JReferenceType) : JReferenceType in class com.google.gwt.dev.jjs.ast.JProgram	From	To
Rename Variable expr : JExpression to expression : JExpression in method private getAssignmentsIfValid(variable JVariable) : Collection<JReferenceType> in class com.google.gwt.dev.jjs.impl.TypeTightener.TightenTypesVisitor	From	To
Rename Variable refType : JReferenceType to varType : JReferenceType in method private tighten(x JVariable) : void in class com.google.gwt.dev.jjs.impl.TypeTightener.TightenTypesVisitor	From	To
Rename Variable type : JType to expressionType : JType in method private getAssignmentsIfValid(variable JVariable) : Collection<JReferenceType> in class com.google.gwt.dev.jjs.impl.TypeTightener.TightenTypesVisitor	From	To
Rename Variable refType : JReferenceType to returnType : JReferenceType in method public exit(x JMethod, ctx Context) : void in class com.google.gwt.dev.jjs.impl.TypeTightener.TightenTypesVisitor	From	To
Rename Variable resultType : JReferenceType to strengthenedType : JReferenceType in method public exit(x JMethod, ctx Context) : void in class com.google.gwt.dev.jjs.impl.TypeTightener.TightenTypesVisitor	From	To
Rename Variable cType : JClassType to classType : JClassType in method private isJavaLangObject(type JType) : boolean in class com.google.gwt.dev.jjs.ast.JTypeOracle	From	To
Rename Variable resultType : JReferenceType to strengthenedType : JReferenceType in method private tighten(x JVariable) : void in class com.google.gwt.dev.jjs.impl.TypeTightener.TightenTypesVisitor	From	To
Rename Variable myAssignments : Collection<JExpression> to assignmentTypes : Collection<JReferenceType> in method private tighten(x JVariable) : void in class com.google.gwt.dev.jjs.impl.TypeTightener.TightenTypesVisitor	From	To
Rename Variable classify1 : int to interfaceType : JInterfaceType in method private generalizeUnderlyingTypes(thisType JReferenceType, thatType JReferenceType) : JReferenceType in class com.google.gwt.dev.jjs.ast.JProgram	From	To
Rename Variable refType : JReferenceType to type : JReferenceType in method public endVisit(x JConditional, ctx Context) : void in class com.google.gwt.dev.jjs.impl.TypeTightener.TightenTypesVisitor	From	To
Rename Variable typeList : List<JReferenceType> to assignedTypes : Collection<JReferenceType> in method private getAssignmentsIfValid(variable JVariable) : Collection<JReferenceType> in class com.google.gwt.dev.jjs.impl.TypeTightener.TightenTypesVisitor	From	To
Rename Variable aType : JArrayType to toArrayType : JArrayType in method public castFailsTrivially(fromType JReferenceType, toType JReferenceType) : boolean in class com.google.gwt.dev.jjs.ast.JTypeOracle	From	To
Rename Variable qDims : int to fromDims : int in method public castFailsTrivially(fromType JReferenceType, toType JReferenceType) : boolean in class com.google.gwt.dev.jjs.ast.JTypeOracle	From	To
Rename Variable myAssignments : Collection<JExpression> to assignedExpressions : Collection<JExpression> in method private getAssignmentsIfValid(variable JVariable) : Collection<JReferenceType> in class com.google.gwt.dev.jjs.impl.TypeTightener.TightenTypesVisitor	From	To
Rename Variable leafType1 : JType to thisLeafType : JType in method private generalizeArrayTypes(thisArrayType JArrayType, thatArrayType JArrayType) : JReferenceType in class com.google.gwt.dev.jjs.ast.JProgram	From	To
Rename Variable leafType2 : JType to thatLeafType : JType in method private generalizeArrayTypes(thisArrayType JArrayType, thatArrayType JArrayType) : JReferenceType in class com.google.gwt.dev.jjs.ast.JProgram	From	To
Rename Variable argType : JType to argumentType : JType in method public endVisit(x JCastOperation, ctx Context) : void in class com.google.gwt.dev.jjs.impl.TypeTightener.TightenTypesVisitor	From	To
Rename Variable dims : int to toDims : int in method public castFailsTrivially(fromType JReferenceType, toType JReferenceType) : boolean in class com.google.gwt.dev.jjs.ast.JTypeOracle	From	To
Rename Variable qaType : JArrayType to fromArrayType : JArrayType in method public castFailsTrivially(fromType JReferenceType, toType JReferenceType) : boolean in class com.google.gwt.dev.jjs.ast.JTypeOracle	From	To
Rename Variable iType : JInterfaceType to fromInterfaceType : JInterfaceType in method public castFailsTrivially(fromType JReferenceType, toType JReferenceType) : boolean in class com.google.gwt.dev.jjs.ast.JTypeOracle	From	To
Rename Variable call : JMethodCall to newCall : JMethodCall in method public endVisit(x JMethodCall, ctx Context) : void in class com.google.gwt.dev.jjs.impl.MethodCallTightener.MethodCallTighteningVisitor	From	To
Change Return Type	7
Change Return Type JNonNullType to JReferenceType in method public getType() : JReferenceType in class com.google.gwt.dev.jjs.ast.JNameOf	From	To
Change Return Type JNonNullType to JReferenceType in method public getType() : JReferenceType in class com.google.gwt.dev.jjs.ast.JNewInstance	From	To
Change Return Type JNonNullType to JReferenceType in method public getNewType() : JReferenceType in class com.google.gwt.dev.jjs.ast.JConstructor	From	To
Change Return Type boolean to AnalysisResult in method package getAnalysisResult() : AnalysisResult in class com.google.gwt.dev.jjs.ast.JReferenceType.JAnalysisDecoratedType	From	To
Change Return Type JNonNullType to JType in method public getType() : JType in class com.google.gwt.dev.jjs.ast.JThisRef	From	To
Change Return Type JNonNullType to JReferenceType in method public getType() : JReferenceType in class com.google.gwt.dev.jjs.ast.JStringLiteral	From	To
Change Return Type JNonNullType to JReferenceType in method public getType() : JReferenceType in class com.google.gwt.dev.jjs.ast.JNewArray	From	To
Change Attribute Type	2
Change Attribute Type classBaseNn : JNonNullType to classBaseNn : JReferenceType in class com.google.gwt.dev.jjs.JjsTypeTest	From	To
Change Attribute Type classBnn : JNonNullType to classBnn : JReferenceType in class com.google.gwt.dev.jjs.JjsTypeTest	From	To
Extract And Move Method	1
Extract And Move Method private strongerType(type JReferenceType, assignedTypes Iterable<JReferenceType>) : JReferenceType extracted from public exit(x JMethod, ctx Context) : void in class com.google.gwt.dev.jjs.impl.TypeTightener.TightenTypesVisitor & moved to class com.google.gwt.dev.jjs.impl.TypeTightener	From	To
Rename Parameter	11
Rename Parameter qType : JReferenceType to toType : JReferenceType in method private castSucceedsTrivially(fromArrayType JArrayType, toType JReferenceType) : boolean in class com.google.gwt.dev.jjs.ast.JTypeOracle	From	To
Rename Parameter type1 : JReferenceType to thisType : JReferenceType in method private generalizeTypes(thisType JReferenceType, thatType JReferenceType) : JReferenceType in class com.google.gwt.dev.jjs.ast.JProgram	From	To
Rename Parameter target : T to key : T in method private add(key T, value V, map Map<T,Collection<V>>) : void in class com.google.gwt.dev.jjs.impl.TypeTightener	From	To
Rename Parameter type : JType to fromType : JType in method public castSucceedsTrivially(fromType JType, toType JType) : boolean in class com.google.gwt.dev.jjs.ast.JTypeOracle	From	To
Rename Parameter type2 : JReferenceType to thatType : JReferenceType in method private generalizeTypes(thisType JReferenceType, thatType JReferenceType) : JReferenceType in class com.google.gwt.dev.jjs.ast.JProgram	From	To
Rename Parameter x : JVariable to variable : JVariable in method private getAssignmentsIfValid(variable JVariable) : Collection<JReferenceType> in class com.google.gwt.dev.jjs.impl.TypeTightener.TightenTypesVisitor	From	To
Rename Parameter qType : JType to toType : JType in method public castSucceedsTrivially(fromType JType, toType JType) : boolean in class com.google.gwt.dev.jjs.ast.JTypeOracle	From	To
Rename Parameter type : JReferenceType to toType : JReferenceType in method private castSucceedsTrivially(fromArrayType JArrayType, toType JReferenceType) : boolean in class com.google.gwt.dev.jjs.ast.JTypeOracle	From	To
Rename Parameter newType : JType to type : JType in method public setType(type JType) : void in class com.google.gwt.dev.jjs.ast.JConditional	From	To
Rename Parameter qType : JReferenceType to toType : JReferenceType in method public castFailsTrivially(fromType JReferenceType, toType JReferenceType) : boolean in class com.google.gwt.dev.jjs.ast.JTypeOracle	From	To
Rename Parameter type : JReferenceType to fromType : JReferenceType in method public castFailsTrivially(fromType JReferenceType, toType JReferenceType) : boolean in class com.google.gwt.dev.jjs.ast.JTypeOracle	From	To

779f8bf96ae1ff93ba8417d2cb40826a49f6234f

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: