a97b924f35a37a108ed66612bba4ee1066a96e34
Files Diff
- Added: 2
- Removed: 1
- Renamed: 0
- Modified: 18
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 2 | ||
| Move And Rename Method private isDirectOrTransitiveJsProperty(method JMethod) : boolean from class com.google.gwt.dev.jjs.impl.JsInteropRestrictionChecker to public isOrOverridesJsProperty() : boolean from class com.google.gwt.dev.jjs.ast.JMethod | From | To | |
| Move And Rename Method public convertQualifiedPrototypeToNameRef(sourceInfo SourceInfo, jsPrototype String) : JsNameRef from class com.google.gwt.dev.javac.JsInteropUtil to private createQualifier(namespace String, sourceInfo SourceInfo, qualifyWithWnd boolean) : JsNameRef from class com.google.gwt.dev.jjs.impl.GenerateJavaScriptAST.GenerateJavaScriptVisitor | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type jsNamespace : String to pkgInfo : JDeclaredType in method public resolve(resolvedInterfaces List<JInterfaceType>, pkgInfo JDeclaredType) : void in class com.google.gwt.dev.jjs.ast.JDeclaredType | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class com.google.gwt.dev.jjs.ast.JDeclaredType.JsInteropType moved and renamed to com.google.gwt.core.client.interop.MyClassWithNestedExportedClass.InnerEnum | From | To | |
| Merge Variable | 2 | ||
| Merge Variable [lastProvidedNamespace : String, globalStmts : List<JsStatement>, exportRhs : JsNameRef, exportName : String] to f : JField in method private generateExports(x JDeclaredType) : void in class com.google.gwt.dev.jjs.impl.GenerateJavaScriptAST.GenerateJavaScriptVisitor | From | To | |
| Merge Variable [lastProvidedNamespace : String, globalStmts : List<JsStatement>, exportRhs : JsExpression, exportName : String] to m : JMethod in method private generateExports(x JDeclaredType) : void in class com.google.gwt.dev.jjs.impl.GenerateJavaScriptAST.GenerateJavaScriptVisitor | From | To | |
| Extract Variable | 3 | ||
| Extract Variable options : PrecompileTaskOptions in method private GenerateJavaScriptAST(logger TreeLogger, program JProgram, jsProgram JsProgram, compilerContext CompilerContext, typeMapper TypeMapper<?>, symbolTable Map<StandardSymbolData,JsName>, props PermProps) from class com.google.gwt.dev.jjs.impl.GenerateJavaScriptAST | From | To | |
| Extract Variable sourceInfo : SourceInfo in method private exportMemberJs(x JDeclaredType, member JMember, exportRhs JsExpression) : void from class com.google.gwt.dev.jjs.impl.GenerateJavaScriptAST.GenerateJavaScriptVisitor | From | To | |
| Extract Variable sourceInfo : SourceInfo in method private exportMemberClosure(x JDeclaredType, member JMember, exportRhs JsExpression) : void from class com.google.gwt.dev.jjs.impl.GenerateJavaScriptAST.GenerateJavaScriptVisitor | From | To | |
| Extract Method | 3 | ||
| Extract Method private checkExportName(x JMember) : void extracted from public visit(x JField, ctx Context) : boolean in class com.google.gwt.dev.jjs.impl.JsInteropRestrictionChecker | From | To | |
| Extract Method private exportMemberJs(x JDeclaredType, member JMember, exportRhs JsExpression) : void extracted from private exportProvidedNamespace(x JDeclaredType, globalStmts List<JsStatement>, lastProvidedNamespace String, exportNamespacePair Pair<String,String>) : String in class com.google.gwt.dev.jjs.impl.GenerateJavaScriptAST.GenerateJavaScriptVisitor | From | To | |
| Extract Method private checkExportName(x JMember) : void extracted from public visit(x JMethod, ctx Context) : boolean in class com.google.gwt.dev.jjs.impl.JsInteropRestrictionChecker | From | To | |
| Rename Method | 6 | ||
| Rename Method public getJsNamespace() : String renamed to public getExportNamespace() : String in class com.google.gwt.dev.jjs.ast.JDeclaredType | From | To | |
| Rename Method private createAndAddExportAssignment(x JDeclaredType, globalStmts List<JsStatement>, exportRhs JsExpression, exportNamespacePair Pair<String,String>) : void renamed to private exportMemberClosure(x JDeclaredType, member JMember, exportRhs JsExpression) : void in class com.google.gwt.dev.jjs.impl.GenerateJavaScriptAST.GenerateJavaScriptVisitor | From | To | |
| Rename Method public setExportName(exportName String) : void renamed to public setExportInfo(namespace String, name String) : void in class com.google.gwt.dev.jjs.ast.JField | From | To | |
| Rename Method private createSyntheticMethodFromBinding(info SourceInfo, binding MethodBinding, paramNames String[]) : JMethod renamed to private createMethodFromBinding(info SourceInfo, binding MethodBinding, paramNames String[]) : JMethod in class com.google.gwt.dev.jjs.impl.GwtAstBuilder | From | To | |
| Rename Method private exportProvidedNamespace(x JDeclaredType, globalStmts List<JsStatement>, lastProvidedNamespace String, exportNamespacePair Pair<String,String>) : String renamed to private exportMember(x JDeclaredType, member JMember) : void in class com.google.gwt.dev.jjs.impl.GenerateJavaScriptAST.GenerateJavaScriptVisitor | From | To | |
| Rename Method public setExportName(exportName String) : void renamed to public setExportInfo(namespace String, name String) : void in class com.google.gwt.dev.jjs.ast.JMethod | From | To | |
| Pull Up Method | 2 | ||
| Pull Up Method public JInterfaceType(info SourceInfo, name String, interopType JsInteropType, jsPrototype String) from class com.google.gwt.dev.jjs.ast.JInterfaceType to public JDeclaredType(info SourceInfo, name String) from class com.google.gwt.dev.jjs.ast.JDeclaredType | From | To | |
| Pull Up Method public JEnumType(info SourceInfo, name String, isAbstract boolean, interopType JsInteropType) from class com.google.gwt.dev.jjs.ast.JEnumType to public JDeclaredType(info SourceInfo, name String) from class com.google.gwt.dev.jjs.ast.JDeclaredType | From | To | |
| Rename Variable | 1 | ||
| Rename Variable provideStat : JsExprStmt to astStat : JsExprStmt in method private exportMemberJs(x JDeclaredType, member JMember, exportRhs JsExpression) : void in class com.google.gwt.dev.jjs.impl.GenerateJavaScriptAST.GenerateJavaScriptVisitor | From | To | |
| Change Return Type | 1 | ||
| Change Return Type String to void in method private exportMember(x JDeclaredType, member JMember) : void in class com.google.gwt.dev.jjs.impl.GenerateJavaScriptAST.GenerateJavaScriptVisitor | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute lastProvidedNamespace : String to lastExportedNamespace : String in method private exportMemberJs(x JDeclaredType, member JMember, exportRhs JsExpression) : void in class com.google.gwt.dev.jjs.impl.GenerateJavaScriptAST.GenerateJavaScriptVisitor | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute jsExportClosureStyle : boolean to closureCompilerFormatEnabled : boolean in class com.google.gwt.dev.jjs.impl.GenerateJavaScriptAST | From | To | |
| Rename Attribute isJsPrototype : boolean to isJsPrototypeStub : boolean in class com.google.gwt.dev.jjs.ast.JClassType | From | To | |
| Extract Interface | 1 | ||
| Extract Interface com.google.gwt.dev.jjs.ast.JMember from classes [com.google.gwt.dev.jjs.ast.JField, com.google.gwt.dev.jjs.ast.JMethod] | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method public isOrOverridesJsTypeMethod() : boolean extracted from public isJsTypeMethod(x JMethod) : boolean in class com.google.gwt.dev.jjs.ast.JTypeOracle & moved to class com.google.gwt.dev.jjs.ast.JMethod | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter jsPrototype : String to namespace : String in method private createQualifier(namespace String, sourceInfo SourceInfo, qualifyWithWnd boolean) : JsNameRef in class com.google.gwt.dev.jjs.impl.GenerateJavaScriptAST.GenerateJavaScriptVisitor | From | To | |
| Rename Parameter jsNamespace : String to pkgInfo : JDeclaredType in method public resolve(resolvedInterfaces List<JInterfaceType>, pkgInfo JDeclaredType) : void in class com.google.gwt.dev.jjs.ast.JDeclaredType | From | To |