00e85e7a2b9446dc37265feba07473b156d66367
Files Diff
- Added: 6
- Removed: 0
- Renamed: 0
- Modified: 6
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method public testAdditionalEntityEmptyEventInfo() : void renamed to public testEventsWithEmptyInfo() : void in class org.apache.hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineWriterImpl | From | To | |
| Rename Method private testAdditionalEntity() : void renamed to public testEvents() : void in class org.apache.hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineWriterImpl | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type prefix : EntityColumnPrefix to prefix : ColumnPrefix<T> in method private readKeyValuePairs(entity TimelineEntity, result Result, prefix ColumnPrefix<T>, isConfig boolean) : void in class org.apache.hadoop.yarn.server.timelineservice.storage.HBaseTimelineReaderImpl | From | To | |
| Change Parameter Type entityColumnPrefix : EntityColumnPrefix to columnPrefix : ColumnPrefix<T> in method private storeRelations(rowKey byte[], connectedEntities Map<String,Set<String>>, columnPrefix ColumnPrefix<T>, table TypedBufferedMutator<T>) : void in class org.apache.hadoop.yarn.server.timelineservice.storage.HBaseTimelineWriterImpl | From | To | |
| Change Parameter Type prefix : EntityColumnPrefix to prefix : ColumnPrefix<T> in method private readRelationship(entity TimelineEntity, result Result, prefix ColumnPrefix<T>, isRelatedTo boolean) : void in class org.apache.hadoop.yarn.server.timelineservice.storage.HBaseTimelineReaderImpl | From | To | |
| Change Return Type | 1 | ||
| Change Return Type NavigableMap<String,NavigableMap<Long,T>> to NavigableMap<String,NavigableMap<Long,V>> in method public readResultsWithTimestamps(result Result) : NavigableMap<String,NavigableMap<Long,V>> in class org.apache.hadoop.yarn.server.timelineservice.storage.entity.EntityColumnPrefix | From | To | |
| Extract Variable | 3 | ||
| Extract Variable entityId : String in method private parseEntity(result Result, fieldsToRetrieve EnumSet<Field>, checkCreatedTime boolean, createdTimeBegin long, createdTimeEnd long, checkModifiedTime boolean, modifiedTimeBegin long, modifiedTimeEnd long, isRelatedTo Map<String,Set<String>>, relatesTo Map<String,Set<String>>, infoFilters Map<String,Object>, configFilters Map<String,String>, eventFilters Set<String>, metricFilters Set<String>, isApplication boolean) : TimelineEntity from class org.apache.hadoop.yarn.server.timelineservice.storage.HBaseTimelineReaderImpl | From | To | |
| Extract Variable result : Result in method public getEntity(userId String, clusterId String, flowId String, flowRunId Long, appId String, entityType String, entityId String, fieldsToRetrieve EnumSet<Field>) : TimelineEntity from class org.apache.hadoop.yarn.server.timelineservice.storage.HBaseTimelineReaderImpl | From | To | |
| Extract Variable entityType : String in method private parseEntity(result Result, fieldsToRetrieve EnumSet<Field>, checkCreatedTime boolean, createdTimeBegin long, createdTimeEnd long, checkModifiedTime boolean, modifiedTimeBegin long, modifiedTimeEnd long, isRelatedTo Map<String,Set<String>>, relatesTo Map<String,Set<String>>, infoFilters Map<String,Object>, configFilters Map<String,String>, eventFilters Set<String>, metricFilters Set<String>, isApplication boolean) : TimelineEntity from class org.apache.hadoop.yarn.server.timelineservice.storage.HBaseTimelineReaderImpl | From | To | |
| Extract Method | 2 | ||
| Extract Method private isApplicationEntity(te TimelineEntity) : boolean extracted from public write(clusterId String, userId String, flowName String, flowVersion String, flowRunId long, appId String, data TimelineEntities) : TimelineWriteResponse in class org.apache.hadoop.yarn.server.timelineservice.storage.HBaseTimelineWriterImpl | From | To | |
| Extract Method private isApplicationEntity(te TimelineEntity) : boolean extracted from private isApplicationCreated(te TimelineEntity) : boolean in class org.apache.hadoop.yarn.server.timelineservice.storage.HBaseTimelineWriterImpl | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter entityColumnPrefix : EntityColumnPrefix to columnPrefix : ColumnPrefix<T> in method private storeRelations(rowKey byte[], connectedEntities Map<String,Set<String>>, columnPrefix ColumnPrefix<T>, table TypedBufferedMutator<T>) : void in class org.apache.hadoop.yarn.server.timelineservice.storage.HBaseTimelineWriterImpl | From | To |