00fe1ed3a4b3ee35fe24be257ec36445d2f44d63
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 27
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 4 | ||
| Rename Method package removePath(src String) : boolean renamed to package removeFile(inodeId long) : boolean in class org.apache.hadoop.hdfs.server.namenode.LeaseManager.Lease | From | To | |
| Rename Method package hasPath() : boolean renamed to package hasFiles() : boolean in class org.apache.hadoop.hdfs.server.namenode.LeaseManager.Lease | From | To | |
| Rename Method package getPaths() : Collection<String> renamed to private getFiles() : Collection<Long> in class org.apache.hadoop.hdfs.server.namenode.LeaseManager.Lease | From | To | |
| Rename Method public getLeaseByPath(src String) : Lease renamed to public getLease(src INodeFile) : Lease in class org.apache.hadoop.hdfs.server.namenode.LeaseManager | From | To | |
| Change Parameter Type | 7 | ||
| Change Parameter Type src : String to src : INodeFile in method package removeLease(holder String, src INodeFile) : void in class org.apache.hadoop.hdfs.server.namenode.LeaseManager | From | To | |
| Change Parameter Type src : String to inodeId : long in method package removeFile(inodeId long) : boolean in class org.apache.hadoop.hdfs.server.namenode.LeaseManager.Lease | From | To | |
| Change Parameter Type src : String to inodeId : long in method private removeLease(lease Lease, inodeId long) : void in class org.apache.hadoop.hdfs.server.namenode.LeaseManager | From | To | |
| Change Parameter Type src : String to src : INodeFile in method public getLease(src INodeFile) : Lease in class org.apache.hadoop.hdfs.server.namenode.LeaseManager | From | To | |
| Change Parameter Type src : String to inodeId : long in method package addLease(holder String, inodeId long) : Lease in class org.apache.hadoop.hdfs.server.namenode.LeaseManager | From | To | |
| Change Parameter Type src : String to src : INodeFile in method package reassignLease(lease Lease, src INodeFile, newHolder String) : Lease in class org.apache.hadoop.hdfs.server.namenode.LeaseManager | From | To | |
| Change Parameter Type src : String to removedUCFiles : List<Long> in method package removeLeasesAndINodes(removedUCFiles List<Long>, removedINodes List<INode>, acquireINodeMapLock boolean) : void in class org.apache.hadoop.hdfs.server.namenode.FSNamesystem | From | To | |
| Move Method | 1 | ||
| Move Method package saveFilesUnderConstruction(out DataOutputStream, snapshotUCMap Map<Long,INodeFile>) : void from class org.apache.hadoop.hdfs.server.namenode.FSNamesystem to package saveFilesUnderConstruction(fsn FSNamesystem, out DataOutputStream, snapshotUCMap Map<Long,INodeFile>) : void from class org.apache.hadoop.hdfs.server.namenode.FSImageFormat.Saver | From | To | |
| Rename Variable | 3 | ||
| Rename Variable p : String to id : Long in method package checkLeases() : boolean in class org.apache.hadoop.hdfs.server.namenode.LeaseManager | From | To | |
| Rename Variable lease : Lease to id : Long in method package getNumUnderConstructionBlocks() : long in class org.apache.hadoop.hdfs.server.namenode.LeaseManager | From | To | |
| Rename Variable entry : Map.Entry<String,INodeFile> to id : Long in method package serializeFilesUCSection(out OutputStream) : void in class org.apache.hadoop.hdfs.server.namenode.FSImageFormatPBINode.Saver | From | To | |
| Change Return Type | 1 | ||
| Change Return Type Collection<String> to Collection<Long> in method private getFiles() : Collection<Long> in class org.apache.hadoop.hdfs.server.namenode.LeaseManager.Lease | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute sortedLeasesByPath : SortedMap<String,Lease> to leasesById : HashMap<Long,Lease> in class org.apache.hadoop.hdfs.server.namenode.LeaseManager | From | To | |
| Rename Attribute paths : Collection<String> to files : HashSet<Long> in class org.apache.hadoop.hdfs.server.namenode.LeaseManager.Lease | From | To | |
| Change Variable Type | 4 | ||
| Change Variable Type p : String to id : Long in method package checkLeases() : boolean in class org.apache.hadoop.hdfs.server.namenode.LeaseManager | From | To | |
| Change Variable Type lease : Lease to id : Long in method package getNumUnderConstructionBlocks() : long in class org.apache.hadoop.hdfs.server.namenode.LeaseManager | From | To | |
| Change Variable Type removing : List<String> to removing : List<Long> in method package checkLeases() : boolean in class org.apache.hadoop.hdfs.server.namenode.LeaseManager | From | To | |
| Change Variable Type entry : Map.Entry<String,INodeFile> to id : Long in method package serializeFilesUCSection(out OutputStream) : void in class org.apache.hadoop.hdfs.server.namenode.FSImageFormatPBINode.Saver | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type sortedLeases : NavigableSet<Lease> to sortedLeases : PriorityQueue<Lease> in class org.apache.hadoop.hdfs.server.namenode.LeaseManager | From | To | |
| Change Attribute Type paths : Collection<String> to files : HashSet<Long> in class org.apache.hadoop.hdfs.server.namenode.LeaseManager.Lease | From | To | |
| Change Attribute Type sortedLeasesByPath : SortedMap<String,Lease> to leasesById : HashMap<Long,Lease> in class org.apache.hadoop.hdfs.server.namenode.LeaseManager | From | To | |
| Rename Parameter | 4 | ||
| Rename Parameter src : String to inodeId : long in method private removeLease(lease Lease, inodeId long) : void in class org.apache.hadoop.hdfs.server.namenode.LeaseManager | From | To | |
| Rename Parameter src : String to removedUCFiles : List<Long> in method package removeLeasesAndINodes(removedUCFiles List<Long>, removedINodes List<INode>, acquireINodeMapLock boolean) : void in class org.apache.hadoop.hdfs.server.namenode.FSNamesystem | From | To | |
| Rename Parameter src : String to inodeId : long in method package addLease(holder String, inodeId long) : Lease in class org.apache.hadoop.hdfs.server.namenode.LeaseManager | From | To | |
| Rename Parameter src : String to inodeId : long in method package removeFile(inodeId long) : boolean in class org.apache.hadoop.hdfs.server.namenode.LeaseManager.Lease | From | To |