hadoop 013532a95e63d7c53e601be530021d6d5a15ab7f

013532a95e63d7c53e601be530021d6d5a15ab7f

Files Diff

Added: 5
Removed: 1
Renamed: 0
Modified: 28

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	4
Rename Method private testSubmissionReservationHelper(path String, media String, arrival Long, reservationName String, expectedId int) : ReservationId renamed to private reservationSubmissionTestHelper(path String, media String, arrival Long, reservationName String, reservationId ReservationId) : ClientResponse in class org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesReservation	From	To
Rename Method public testReservationAPIs() : void renamed to public testListReservationsByTimeInterval() : void in class org.apache.hadoop.yarn.server.resourcemanager.TestClientRMService	From	To
Rename Method public testReservationAPIs() : void renamed to public testListReservationsByTimeInterval() : void in class org.apache.hadoop.yarn.client.api.impl.TestYarnClient	From	To
Rename Method private testUpdateReservationHelper(path String, reservationId ReservationId, media String) : void renamed to private updateReservationTestHelper(path String, reservationId ReservationId, media String) : void in class org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesReservation	From	To
Change Parameter Type	1
Change Parameter Type expectedId : int to reservationId : ReservationId in method private reservationSubmissionTestHelper(path String, media String, arrival Long, reservationName String, reservationId ReservationId) : ClientResponse in class org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesReservation	From	To
Move Method	11
Move Method public setReservationId(reservationId String) : void from class org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.ReservationSubmissionResponseInfo to public setReservationId(reservationId String) : void from class org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.ReservationSubmissionRequestInfo	From	To
Move Method public abstract getReservationId() : ReservationId from class org.apache.hadoop.yarn.api.protocolrecords.ReservationSubmissionResponse to public abstract getReservationId() : ReservationId from class org.apache.hadoop.yarn.api.protocolrecords.GetNewReservationResponse	From	To
Move Method private convertToProtoFormat(t ReservationId) : ReservationIdProto from class org.apache.hadoop.yarn.api.protocolrecords.impl.pb.ReservationSubmissionResponsePBImpl to private convertToProtoFormat(t ReservationId) : ReservationIdProto from class org.apache.hadoop.yarn.api.protocolrecords.impl.pb.GetNewReservationResponsePBImpl	From	To
Move Method public abstract setReservationId(reservationId ReservationId) : void from class org.apache.hadoop.yarn.api.protocolrecords.ReservationSubmissionResponse to public abstract setReservationId(reservationId ReservationId) : void from class org.apache.hadoop.yarn.api.protocolrecords.GetNewReservationResponse	From	To
Move Method public getReservationId() : ReservationId from class org.apache.hadoop.yarn.api.protocolrecords.impl.pb.ReservationSubmissionResponsePBImpl to public getReservationId() : ReservationId from class org.apache.hadoop.yarn.api.protocolrecords.impl.pb.GetNewReservationResponsePBImpl	From	To
Move Method public getReservationId() : String from class org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.ReservationSubmissionResponseInfo to public getReservationId() : String from class org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.ReservationSubmissionRequestInfo	From	To
Move Method private maybeInitBuilder() : void from class org.apache.hadoop.yarn.api.protocolrecords.impl.pb.ReservationSubmissionResponsePBImpl to private maybeInitBuilder() : void from class org.apache.hadoop.yarn.api.protocolrecords.impl.pb.GetNewReservationResponsePBImpl	From	To
Move Method private mergeLocalToBuilder() : void from class org.apache.hadoop.yarn.api.protocolrecords.impl.pb.ReservationSubmissionResponsePBImpl to private mergeLocalToBuilder() : void from class org.apache.hadoop.yarn.api.protocolrecords.impl.pb.GetNewReservationResponsePBImpl	From	To
Move Method public setReservationId(reservationId ReservationId) : void from class org.apache.hadoop.yarn.api.protocolrecords.impl.pb.ReservationSubmissionResponsePBImpl to public setReservationId(reservationId ReservationId) : void from class org.apache.hadoop.yarn.api.protocolrecords.impl.pb.GetNewReservationResponsePBImpl	From	To
Move Method private convertFromProtoFormat(p ReservationIdProto) : ReservationIdPBImpl from class org.apache.hadoop.yarn.api.protocolrecords.impl.pb.ReservationSubmissionResponsePBImpl to private convertFromProtoFormat(p ReservationIdProto) : ReservationIdPBImpl from class org.apache.hadoop.yarn.api.protocolrecords.impl.pb.GetNewReservationResponsePBImpl	From	To
Move Method private mergeLocalToProto() : void from class org.apache.hadoop.yarn.api.protocolrecords.impl.pb.ReservationSubmissionResponsePBImpl to private mergeLocalToProto() : void from class org.apache.hadoop.yarn.api.protocolrecords.impl.pb.GetNewReservationResponsePBImpl	From	To
Rename Variable	1
Rename Variable dResponse : ReservationDeleteResponse to getNewReservationResponse : GetNewReservationResponse in method private getNewReservation(rmClient YarnClient) : GetNewReservationResponse in class org.apache.hadoop.yarn.client.api.impl.TestYarnClient	From	To
Change Return Type	2
Change Return Type ReservationId to void in method private submitReservation(submitter String, queueName String, reservationId ReservationId) : void in class org.apache.hadoop.yarn.server.resourcemanager.ReservationACLsTestBase	From	To
Change Return Type ReservationId to ClientResponse in method private reservationSubmissionTestHelper(path String, media String, arrival Long, reservationName String, reservationId ReservationId) : ClientResponse in class org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesReservation	From	To
Move Attribute	2
Move Attribute private reservationId : ReservationId from class org.apache.hadoop.yarn.api.protocolrecords.impl.pb.ReservationSubmissionResponsePBImpl to private reservationId : ReservationId from class org.apache.hadoop.yarn.api.protocolrecords.impl.pb.GetNewReservationResponsePBImpl	From	To
Move Attribute private reservationId : String from class org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.ReservationSubmissionResponseInfo to private reservationId : String from class org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.ReservationSubmissionRequestInfo	From	To
Extract Class	2
Extract Class org.apache.hadoop.yarn.api.protocolrecords.GetNewReservationResponse from class org.apache.hadoop.yarn.api.protocolrecords.ReservationSubmissionResponse	From	To
Extract Class org.apache.hadoop.yarn.api.protocolrecords.impl.pb.GetNewReservationResponsePBImpl from class org.apache.hadoop.yarn.api.protocolrecords.impl.pb.ReservationSubmissionResponsePBImpl	From	To
Change Variable Type	1
Change Variable Type dResponse : ReservationDeleteResponse to getNewReservationResponse : GetNewReservationResponse in method private getNewReservation(rmClient YarnClient) : GetNewReservationResponse in class org.apache.hadoop.yarn.client.api.impl.TestYarnClient	From	To
Extract Method	6
Extract Method private setupYarnClient(cluster MiniYARNCluster) : YarnClient extracted from public testReservationAPIs() : void in class org.apache.hadoop.yarn.client.api.impl.TestYarnClient	From	To
Extract Method private getNewReservation(rmClient YarnClient) : GetNewReservationResponse extracted from public testReservationAPIs() : void in class org.apache.hadoop.yarn.client.api.impl.TestYarnClient	From	To
Extract Method private submitReservationTestHelper(client YarnClient, arrival long, deadline long, duration long) : ReservationSubmissionRequest extracted from public testReservationAPIs() : void in class org.apache.hadoop.yarn.client.api.impl.TestYarnClient	From	To
Extract Method private setupResourceManager() : ResourceManager extracted from public testReservationAPIs() : void in class org.apache.hadoop.yarn.server.resourcemanager.TestClientRMService	From	To
Extract Method private setupMiniYARNCluster() : MiniYARNCluster extracted from public testReservationAPIs() : void in class org.apache.hadoop.yarn.client.api.impl.TestYarnClient	From	To
Extract Method private submitReservationTestHelper(clientService ClientRMService, arrival long, deadline long, duration long) : ReservationSubmissionRequest extracted from public testReservationAPIs() : void in class org.apache.hadoop.yarn.server.resourcemanager.TestClientRMService	From	To
Rename Parameter	1
Rename Parameter expectedId : int to reservationId : ReservationId in method private reservationSubmissionTestHelper(path String, media String, arrival Long, reservationName String, reservationId ReservationId) : ClientResponse in class org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesReservation	From	To

013532a95e63d7c53e601be530021d6d5a15ab7f

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: