08ac06283a3e9bf0d49d873823aabd419b08e41f
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 39
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Variable | 2 | ||
| Rename Variable replicafile : File to blockFile : File in method private updateReplicaUnderRecovery(bpid String, rur ReplicaUnderRecovery, recoveryId long, newBlockId long, newlength long) : FinalizedReplica in class org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl | From | To | |
| Rename Variable last : FileDiff to diff : FileDiff in method public collectBlocksAndClear(file INodeFile, info BlocksMapUpdateInfo, removedINodes List<INode>) : void in class org.apache.hadoop.hdfs.server.namenode.snapshot.FileWithSnapshotFeature | From | To | |
| Inline Method | 3 | ||
| Inline Method public initializeBlockRecovery(s BlockUCState, recoveryId long) : void inlined to public initializeBlockRecovery(recoveryId long) : void in class org.apache.hadoop.hdfs.server.blockmanagement.BlockInfoUnderConstruction | From | To | |
| Inline Method private computeContentSummary4Snapshot(counts Content.Counts) : void inlined to public computeContentSummary(summary ContentSummaryComputationContext) : ContentSummaryComputationContext in class org.apache.hadoop.hdfs.server.namenode.INodeFile | From | To | |
| Inline Method private computeContentSummary4Current(counts Content.Counts) : void inlined to public computeContentSummary(summary ContentSummaryComputationContext) : ContentSummaryComputationContext in class org.apache.hadoop.hdfs.server.namenode.INodeFile | From | To | |
| Change Return Type | 1 | ||
| Change Return Type void to D in method public saveSelf2Snapshot(latestSnapshotId int, currentINode N, snapshotCopy A) : D in class org.apache.hadoop.hdfs.server.namenode.snapshot.AbstractINodeDiffList | From | To | |
| Extract Variable | 6 | ||
| Extract Variable primaryBlock : ExtendedBlock in method public handleHeartbeat(nodeReg DatanodeRegistration, reports StorageReport[], blockPoolId String, cacheCapacity long, cacheUsed long, xceiverCount int, maxTransfers int, failedVolumes int) : DatanodeCommand[] from class org.apache.hadoop.hdfs.server.blockmanagement.DatanodeManager | From | To | |
| Extract Variable s : String in method public testTruncateEditLogLoad() : void from class org.apache.hadoop.hdfs.server.namenode.TestFileTruncate | From | To | |
| Extract Variable blockId : long in method package syncBlock(rBlock RecoveringBlock, syncList List<BlockRecord>) : void from class org.apache.hadoop.hdfs.server.datanode.DataNode | From | To | |
| Extract Variable metaFile : File in method private updateReplicaUnderRecovery(bpid String, rur ReplicaUnderRecovery, recoveryId long, newBlockId long, newlength long) : FinalizedReplica from class org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl | From | To | |
| Extract Variable sf : FileWithSnapshotFeature in method package combinePosteriorAndCollectBlocks(currentINode INodeFile, posterior FileDiff, collectedBlocks BlocksMapUpdateInfo, removedINodes List<INode>) : Quota.Counts from class org.apache.hadoop.hdfs.server.namenode.snapshot.FileDiff | From | To | |
| Extract Variable recoveryInfos : DatanodeInfo[] in method public handleHeartbeat(nodeReg DatanodeRegistration, reports StorageReport[], blockPoolId String, cacheCapacity long, cacheUsed long, xceiverCount int, maxTransfers int, failedVolumes int) : DatanodeCommand[] from class org.apache.hadoop.hdfs.server.blockmanagement.DatanodeManager | From | To | |
| Extract Method | 5 | ||
| Extract Method package checkFullFile(p Path, newLength int, contents byte[]) : void extracted from public testTruncateEditLogLoad() : void in class org.apache.hadoop.hdfs.server.namenode.TestFileTruncate | From | To | |
| Extract Method public recordModification(latestSnapshotId int, withBlocks boolean) : void extracted from public recordModification(latestSnapshotId int) : void in class org.apache.hadoop.hdfs.server.namenode.INodeFile | From | To | |
| Extract Method package truncateBlocksTo(n int) : void extracted from public collectBlocksBeyondMax(max long, collectedBlocks BlocksMapUpdateInfo) : long in class org.apache.hadoop.hdfs.server.namenode.INodeFile | From | To | |
| Extract Method package checkFullFile(p Path, newLength int, contents byte[]) : void extracted from public testTruncateFailure() : void in class org.apache.hadoop.hdfs.server.namenode.TestFileTruncate | From | To | |
| Extract Method package copyBlockFiles(srcMeta File, srcFile File, dstMeta File, dstFile File, calculateChecksum boolean) : File[] extracted from package copyBlockFiles(blockId long, genStamp long, srcMeta File, srcFile File, destRoot File, calculateChecksum boolean) : File[] in class org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter lastblock : ExtendedBlock to oldBlock : ExtendedBlock in method package commitBlockSynchronization(oldBlock ExtendedBlock, newgenerationstamp long, newlength long, closeFile boolean, deleteblock boolean, newtargets DatanodeID[], newtargetstorages String[]) : void in class org.apache.hadoop.hdfs.server.namenode.FSNamesystem | From | To |