0987a7b8cbbbb2c1e4c2095821d98a7db19644df
Files Diff
- Added: 3
- Removed: 0
- Renamed: 0
- Modified: 18
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 3 | ||
| Rename Method public getQueueForApp(asc ApplicationSubmissionContext, user String) : String renamed to public getPlacementForApp(asc ApplicationSubmissionContext, user String) : ApplicationPlacementContext in class org.apache.hadoop.yarn.server.resourcemanager.placement.UserGroupMappingPlacementRule | From | To | |
| Rename Method public abstract getQueueForApp(asc ApplicationSubmissionContext, user String) : String renamed to public abstract getPlacementForApp(asc ApplicationSubmissionContext, user String) : ApplicationPlacementContext in class org.apache.hadoop.yarn.server.resourcemanager.placement.PlacementRule | From | To | |
| Rename Method private getMappedQueue(user String) : String renamed to private getPlacementForUser(user String) : ApplicationPlacementContext in class org.apache.hadoop.yarn.server.resourcemanager.placement.UserGroupMappingPlacementRule | From | To | |
| Push Down Method | 1 | ||
| Push Down Method protected sumOfChildCapacities() : float from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.ParentQueue to protected sumOfChildCapacities() : float from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractManagedParentQueue | From | To | |
| Move And Rename Method | 1 | ||
| Move And Rename Method public getUserLimitForAutoCreatedQueues() : int from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractManagedParentQueue to public getUserLimit() : int from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractManagedParentQueue.AutoCreatedLeafQueueTemplate | From | To | |
| Move Method | 2 | ||
| Move Method public getUserLimitFactor() : float from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractManagedParentQueue to public getUserLimitFactor() : float from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractManagedParentQueue.AutoCreatedLeafQueueTemplate | From | To | |
| Move Method public getUserLimit() : int from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractManagedParentQueue to public getUserLimit() : int from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractManagedParentQueue.AutoCreatedLeafQueueTemplate | From | To | |
| Rename Variable | 2 | ||
| Rename Variable newQueueName : String to placement : ApplicationPlacementContext in method public placeApplication(asc ApplicationSubmissionContext, user String) : ApplicationPlacementContext in class org.apache.hadoop.yarn.server.resourcemanager.placement.PlacementManager | From | To | |
| Rename Variable queue : String to ctx : ApplicationPlacementContext in method private verifyQueueMapping(queueMapping QueueMapping, inputUser String, inputQueue String, expectedQueue String, overwrite boolean) : void in class org.apache.hadoop.yarn.server.resourcemanager.placement.TestUserGroupMappingPlacementRule | From | To | |
| Change Return Type | 7 | ||
| Change Return Type void to ApplicationPlacementContext in method public placeApplication(asc ApplicationSubmissionContext, user String) : ApplicationPlacementContext in class org.apache.hadoop.yarn.server.resourcemanager.placement.PlacementManager | From | To | |
| Change Return Type String to ApplicationPlacementContext in method private getPlacementForUser(user String) : ApplicationPlacementContext in class org.apache.hadoop.yarn.server.resourcemanager.placement.UserGroupMappingPlacementRule | From | To | |
| Change Return Type void to AutoCreatedLeafQueueTemplate.Builder in method protected initializeLeafQueueConfigs(queuePath String) : AutoCreatedLeafQueueTemplate.Builder in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.PlanQueue | From | To | |
| Change Return Type UserGroupMappingPlacementRule to PlacementRule in method public getUserGroupMappingPlacementRule() : PlacementRule in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler | From | To | |
| Change Return Type String to ApplicationPlacementContext in method public abstract getPlacementForApp(asc ApplicationSubmissionContext, user String) : ApplicationPlacementContext in class org.apache.hadoop.yarn.server.resourcemanager.placement.PlacementRule | From | To | |
| Change Return Type void to AutoCreatedLeafQueueTemplate.Builder in method protected initializeLeafQueueConfigs(queuePath String) : AutoCreatedLeafQueueTemplate.Builder in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractManagedParentQueue | From | To | |
| Change Return Type String to ApplicationPlacementContext in method public getPlacementForApp(asc ApplicationSubmissionContext, user String) : ApplicationPlacementContext in class org.apache.hadoop.yarn.server.resourcemanager.placement.UserGroupMappingPlacementRule | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private userLimit : int from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractManagedParentQueue to private userLimit : int from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractManagedParentQueue.AutoCreatedLeafQueueTemplate | From | To | |
| Move Attribute private userLimitFactor : float from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractManagedParentQueue to private userLimitFactor : float from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractManagedParentQueue.AutoCreatedLeafQueueTemplate | From | To | |
| Extract Class | 1 | ||
| Extract Class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractManagedParentQueue.AutoCreatedLeafQueueTemplate from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractManagedParentQueue | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type parent : ParentQueue to parent : AbstractManagedParentQueue in method public setEntitlement(inQueue String, entitlement QueueEntitlement) : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler | From | To | |
| Change Variable Type queue : String to ctx : ApplicationPlacementContext in method private verifyQueueMapping(queueMapping QueueMapping, inputUser String, inputQueue String, expectedQueue String, overwrite boolean) : void in class org.apache.hadoop.yarn.server.resourcemanager.placement.TestUserGroupMappingPlacementRule | From | To | |
| Change Variable Type newQueueName : String to placement : ApplicationPlacementContext in method public placeApplication(asc ApplicationSubmissionContext, user String) : ApplicationPlacementContext in class org.apache.hadoop.yarn.server.resourcemanager.placement.PlacementManager | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method public get(schedulerContext CapacitySchedulerContext) : UserGroupMappingPlacementRule extracted from public getUserGroupMappingPlacementRule() : UserGroupMappingPlacementRule in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler & moved to class org.apache.hadoop.yarn.server.resourcemanager.placement.UserGroupMappingPlacementRule | From | To |