0da69c324dee9baab0f0b9700db1cc5b623f8421
Files Diff
- Added: 3
- Removed: 0
- Renamed: 0
- Modified: 25
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 1 | ||
| Change Parameter Type timeout : long to timeout : int in method private refreshNodes(timeout int, trackingMode String) : int in class org.apache.hadoop.yarn.client.cli.RMAdminCLI | From | To | |
| Rename Variable | 1 | ||
| Rename Variable newExcludes : Set<String> to nodes : HashSet<String> in method public readFileToMapWithFileInputStream(type String, filename String, inputStream InputStream, map Map<String,Integer>) : void in class org.apache.hadoop.util.HostsFileReader | From | To | |
| Change Return Type | 1 | ||
| Change Return Type long to int in method private validateTimeout(strTimeout String) : int in class org.apache.hadoop.yarn.client.cli.RMAdminCLI | From | To | |
| Change Variable Type | 5 | ||
| Change Variable Type timeout : long to timeout : int in method private handleRefreshNodes(args String[], cmd String, isHAEnabled boolean) : int in class org.apache.hadoop.yarn.client.cli.RMAdminCLI | From | To | |
| Change Variable Type timeout : long to timeout : int in method private validateTimeout(strTimeout String) : int in class org.apache.hadoop.yarn.client.cli.RMAdminCLI | From | To | |
| Change Variable Type newExcludes : Set<String> to newExcludes : Map<String,Integer> in method public refresh(inFileInputStream InputStream, exFileInputStream InputStream) : void in class org.apache.hadoop.util.HostsFileReader | From | To | |
| Change Variable Type newExcludes : Set<String> to nodes : HashSet<String> in method public readFileToMapWithFileInputStream(type String, filename String, inputStream InputStream, map Map<String,Integer>) : void in class org.apache.hadoop.util.HostsFileReader | From | To | |
| Change Variable Type newExcludes : Set<String> to newExcludes : Map<String,Integer> in method public refresh(includeFiles String, excludeFiles String) : void in class org.apache.hadoop.util.HostsFileReader | From | To | |
| Extract Method | 7 | ||
| Extract Method private handleRefreshNodes(args String[], cmd String, isHAEnabled boolean) : int extracted from public run(args String[]) : int in class org.apache.hadoop.yarn.client.cli.RMAdminCLI | From | To | |
| Extract Method private handleUpdateNodeResource(args String[], cmd String, isHAEnabled boolean) : int extracted from public run(args String[]) : int in class org.apache.hadoop.yarn.client.cli.RMAdminCLI | From | To | |
| Extract Method private isValidNode(hostName String, hostsList Set<String>, excludeList Set<String>) : boolean extracted from public isValidNode(hostName String) : boolean in class org.apache.hadoop.yarn.server.resourcemanager.NodesListManager | From | To | |
| Extract Method public readFileToMapWithFileInputStream(type String, filename String, inputStream InputStream, map Map<String,Integer>) : void extracted from public refresh(inFileInputStream InputStream, exFileInputStream InputStream) : void in class org.apache.hadoop.util.HostsFileReader | From | To | |
| Extract Method private testNodeRemovalUtilDecomToUntracked(rmContext RMContext, conf Configuration, nm1 MockNM, nm2 MockNM, nm3 MockNM, maxThreadSleeptime long, doGraceful boolean) : void extracted from public testNodeRemovalUtil(doGraceful boolean) : void in class org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService | From | To | |
| Extract Method private refreshNodes(graceful boolean) : int extracted from private refreshNodes() : int in class org.apache.hadoop.yarn.client.cli.RMAdminCLI | From | To | |
| Extract Method public refreshNodes(yarnConf Configuration, graceful boolean) : void extracted from public refreshNodes(yarnConf Configuration) : void in class org.apache.hadoop.yarn.server.resourcemanager.NodesListManager | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type excludes : Set<String> to excludes : Map<String,Integer> in class org.apache.hadoop.util.HostsFileReader | From | To |