0f25a1bb52bc56661fd020a6ba82df99f8c6ef1f
Files Diff
- Added: 4
- Removed: 0
- Renamed: 0
- Modified: 25
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Variable | 1 | ||
| Rename Variable containerID : ContainerId to containerId : ContainerId in method protected setContainerCompletedStatus(exitCode int) : void in class org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.ContainerLaunch | From | To | |
| Parameterize Variable | 2 | ||
| Parameterize Variable ret : int to exitCode : int in method protected setContainerCompletedStatus(exitCode int) : void in class org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.ContainerLaunch | From | To | |
| Parameterize Variable ret : int to exitCode : int in method protected handleContainerExitCode(exitCode int, containerLogDir Path) : void in class org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.ContainerLaunch | From | To | |
| Merge Parameter | 1 | ||
| Merge Parameter [recoveredStatus : RecoveredContainerStatus, exitCode : int, wasKilled : boolean, diagnostics : String, recoveredCapability : Resource] to rcs : RecoveredContainerState in method public ContainerImpl(conf Configuration, dispatcher Dispatcher, launchContext ContainerLaunchContext, creds Credentials, metrics NodeManagerMetrics, containerTokenIdentifier ContainerTokenIdentifier, context Context, rcs RecoveredContainerState) in class org.apache.hadoop.yarn.server.nodemanager.containermanager.container.ContainerImpl | From | To | |
| Extract Method | 7 | ||
| Extract Method protected handleContainerExitCode(exitCode int, containerLogDir Path) : void extracted from public call() : Integer in class org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.ContainerLaunch | From | To | |
| Extract Method public newInstance(localResources Map<String,LocalResource>, environment Map<String,String>, commands List<String>, serviceData Map<String,ByteBuffer>, tokens ByteBuffer, acls Map<ApplicationAccessType,String>, containerRetryContext ContainerRetryContext) : ContainerLaunchContext extracted from public newInstance(localResources Map<String,LocalResource>, environment Map<String,String>, commands List<String>, serviceData Map<String,ByteBuffer>, tokens ByteBuffer, acls Map<ApplicationAccessType,String>) : ContainerLaunchContext in class org.apache.hadoop.yarn.api.records.ContainerLaunchContext | From | To | |
| Extract Method protected validateContainerState() : boolean extracted from public call() : Integer in class org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.ContainerLaunch | From | To | |
| Extract Method protected getContainerLogDirs(logDirs List<String>) : List<String> extracted from public call() : Integer in class org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.ContainerLaunch | From | To | |
| Extract Method protected setContainerCompletedStatus(exitCode int) : void extracted from public call() : Integer in class org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.ContainerLaunch | From | To | |
| Extract Method protected launchContainer(ctx ContainerStartContext) : int extracted from public call() : Integer in class org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.ContainerLaunch | From | To | |
| Extract Method protected getLocalizedResources() : Map<Path,List<String>> extracted from public call() : Integer in class org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.ContainerLaunch | From | To |