0fa54d45b1cf8a29f089f64d24f35bd221b4803f
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 9
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 3 | ||
| Change Parameter Type proxy : TestProtocol to proxy : TestRpcService in method package SlowRPC(proxy TestRpcService) in class org.apache.hadoop.ipc.TestRPC.SlowRPC | From | To | |
| Change Parameter Type request : EmptyRequestProto to request : TestProtos.EmptyRequestProto in method public ping(unused RpcController, request TestProtos.EmptyRequestProto) : TestProtos.EmptyResponseProto in class org.apache.hadoop.yarn.server.nodemanager.TestNMAuditLogger.MyTestRPCServer | From | To | |
| Change Parameter Type proxy : TestProtocol to proxy : TestRpcService in method package Transactions(proxy TestRpcService, datasize int) in class org.apache.hadoop.ipc.TestRPC.Transactions | From | To | |
| Move Method | 2 | ||
| Move Method public testRPCServerShutdown() : void from class org.apache.hadoop.ipc.TestRPC to public testRPCServerShutdown() : void from class org.apache.hadoop.ipc.TestRPCServerShutdown | From | To | |
| Move Method public ping(unused RpcController, request EmptyRequestProto) : EmptyResponseProto from class org.apache.hadoop.ipc.TestProtoBufRpc.PBServerImpl to public ping(unused RpcController, request TestProtos.EmptyRequestProto) : TestProtos.EmptyResponseProto from class org.apache.hadoop.yarn.server.nodemanager.TestNMAuditLogger.MyTestRPCServer | From | To | |
| Pull Up Attribute | 7 | ||
| Pull Up Attribute private ADDRESS : String from class org.apache.hadoop.ipc.TestRPC to protected ADDRESS : String from class org.apache.hadoop.ipc.TestRpcBase | From | To | |
| Pull Up Attribute private conf : Configuration from class org.apache.hadoop.ipc.TestProtoBufRpc to protected conf : Configuration from class org.apache.hadoop.ipc.TestRpcBase | From | To | |
| Pull Up Attribute private conf : Configuration from class org.apache.hadoop.ipc.TestRPC to protected conf : Configuration from class org.apache.hadoop.ipc.TestRpcBase | From | To | |
| Pull Up Attribute public ADDRESS : String from class org.apache.hadoop.ipc.TestProtoBufRpc to protected ADDRESS : String from class org.apache.hadoop.ipc.TestRpcBase | From | To | |
| Pull Up Attribute private addr : InetSocketAddress from class org.apache.hadoop.ipc.TestProtoBufRpc to protected addr : InetSocketAddress from class org.apache.hadoop.ipc.TestRpcBase | From | To | |
| Pull Up Attribute public PORT : int from class org.apache.hadoop.ipc.TestProtoBufRpc to protected PORT : int from class org.apache.hadoop.ipc.TestRpcBase | From | To | |
| Pull Up Attribute private ADDRESS : String from class org.apache.hadoop.ipc.TestMultipleProtocolServer to protected ADDRESS : String from class org.apache.hadoop.ipc.TestRpcBase | From | To | |
| Move Class | 1 | ||
| Move Class org.apache.hadoop.ipc.TestProtoBufRpc.TestRpcService moved to org.apache.hadoop.ipc.TestRpcBase.TestRpcService | From | To | |
| Extract Variable | 1 | ||
| Extract Variable strings : String[] in method private testCallsInternal(myConf Configuration) : void from class org.apache.hadoop.ipc.TestRPC | From | To | |
| Change Variable Type | 9 | ||
| Change Variable Type sendProto : EnumDescriptorProto to echoRequest2 : TestProtos.EchoRequestProto2 in method private testCallsInternal(myConf Configuration) : void in class org.apache.hadoop.ipc.TestRPC | From | To | |
| Change Variable Type proxy : TestProtocol to proxy : TestRpcService in method private doRPCs(myConf Configuration, expectFailure boolean) : void in class org.apache.hadoop.ipc.TestRPC | From | To | |
| Change Variable Type outdata : int[] to outdata : Integer[] in method public run() : void in class org.apache.hadoop.ipc.TestRPC.Transactions | From | To | |
| Change Variable Type stringResult : String to echoResp : TestProtos.EchoResponseProto in method private testCallsInternal(myConf Configuration) : void in class org.apache.hadoop.ipc.TestRPC | From | To | |
| Change Variable Type proxy : TestProtocol to proxy : TestRpcService in method public testSlowRpc() : void in class org.apache.hadoop.ipc.TestRPC | From | To | |
| Change Variable Type proxy : TestProtocol to proxy : TestRpcService in method public testProxyAddress() : void in class org.apache.hadoop.ipc.TestRPC | From | To | |
| Change Variable Type proxy : TestProtocol to proxy : TestRpcService in method private testCallsInternal(myConf Configuration) : void in class org.apache.hadoop.ipc.TestRPC | From | To | |
| Change Variable Type proxy : TestProtocol to proxy : TestRpcService in method public testErrorMsgForInsecureClient() : void in class org.apache.hadoop.ipc.TestRPC | From | To | |
| Change Variable Type ioe : IOException to se : ServiceException in method public testRPCInterruptedSimple() : void in class org.apache.hadoop.ipc.TestRPC | From | To | |
| Extract Method | 1 | ||
| Extract Method package ping(shouldSlow boolean) : void extracted from public run() : void in class org.apache.hadoop.ipc.TestRPC.SlowRPC | From | To | |
| Pull Up Method | 2 | ||
| Pull Up Method public setupConf() : void from class org.apache.hadoop.ipc.TestRPC to protected setupConf() : void from class org.apache.hadoop.ipc.TestRpcBase | From | To | |
| Pull Up Method private countThreads(search String) : int from class org.apache.hadoop.ipc.TestRPC to protected countThreads(search String) : int from class org.apache.hadoop.ipc.TestRpcBase | From | To | |
| Rename Variable | 4 | ||
| Rename Variable stringResult : String to echoResp : TestProtos.EchoResponseProto in method private testCallsInternal(myConf Configuration) : void in class org.apache.hadoop.ipc.TestRPC | From | To | |
| Rename Variable ioe : IOException to se : ServiceException in method public testRPCInterruptedSimple() : void in class org.apache.hadoop.ipc.TestRPC | From | To | |
| Rename Variable conf : Configuration to myConf : Configuration in method public testAuthorization() : void in class org.apache.hadoop.ipc.TestRPC | From | To | |
| Rename Variable sendProto : EnumDescriptorProto to echoRequest2 : TestProtos.EchoRequestProto2 in method private testCallsInternal(myConf Configuration) : void in class org.apache.hadoop.ipc.TestRPC | From | To | |
| Change Return Type | 1 | ||
| Change Return Type EmptyResponseProto to TestProtos.EmptyResponseProto in method public ping(unused RpcController, request TestProtos.EmptyRequestProto) : TestProtos.EmptyResponseProto in class org.apache.hadoop.yarn.server.nodemanager.TestNMAuditLogger.MyTestRPCServer | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute configuration : Configuration to conf : Configuration in method public testRpcMetrics() : void in class org.apache.hadoop.ipc.TestRPC | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.apache.hadoop.ipc.TestRpcBase from classes [org.apache.hadoop.ipc.RPCCallBenchmark, org.apache.hadoop.ipc.TestMultipleProtocolServer, org.apache.hadoop.ipc.TestProtoBufRpc, org.apache.hadoop.ipc.TestRPC] | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type proxy : TestProtocol to proxy : TestRpcService in class org.apache.hadoop.ipc.TestRPC.Transactions | From | To | |
| Change Attribute Type proxy : TestProtocol to proxy : TestRpcService in class org.apache.hadoop.ipc.TestRPC.SlowRPC | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method package ping(shouldSlow boolean) : void extracted from public testSlowRpc() : void in class org.apache.hadoop.ipc.TestRPC & moved to class org.apache.hadoop.ipc.TestRPC.SlowRPC | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter conf : Configuration to myConf : Configuration in method private testCallsInternal(myConf Configuration) : void in class org.apache.hadoop.ipc.TestRPC | From | To | |
| Rename Parameter conf : Configuration to myConf : Configuration in method private doRPCs(myConf Configuration, expectFailure boolean) : void in class org.apache.hadoop.ipc.TestRPC | From | To |