0fefda645bca935b87b6bb8ca63e6f18340d59f5
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 23
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method private checkResourceRequestMatchingNodeLabel(offswitchResourceRequest ResourceRequest, node FiCaSchedulerNode) : boolean from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue to public checkResourceRequestMatchingNodePartition(offswitchResourceRequest ResourceRequest, nodePartition String, schedulingMode SchedulingMode) : boolean from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerUtils | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type nodeLabels : Set<String> to nodePartition : String in method package allocateResource(clusterResource Resource, application SchedulerApplicationAttempt, resource Resource, nodePartition String) : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue | From | To | |
| Change Parameter Type nodeLabels : Set<String> to nodePartition : String in method package releaseResource(clusterResource Resource, application FiCaSchedulerApp, resource Resource, nodePartition String) : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue | From | To | |
| Move Method | 7 | ||
| Move Method public testContainerAllocateWithDefaultQueueLabels() : void from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation to public testContainerAllocateWithDefaultQueueLabels() : void from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation | From | To | |
| Move Method public testContainerAllocateWithComplexLabels() : void from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation to public testContainerAllocateWithComplexLabels() : void from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation | From | To | |
| Move Method public testContainerAllocationWithSingleUserLimits() : void from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation to public testContainerAllocationWithSingleUserLimits() : void from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation | From | To | |
| Move Method private getConfigurationWithQueueLabels(config Configuration) : Configuration from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation to private getConfigurationWithQueueLabels(config Configuration) : Configuration from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation | From | To | |
| Move Method private checkTaskContainersHost(attemptId ApplicationAttemptId, containerId ContainerId, rm ResourceManager, host String) : void from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation to private checkTaskContainersHost(attemptId ApplicationAttemptId, containerId ContainerId, rm ResourceManager, host String) : void from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation | From | To | |
| Move Method private toSet(elements E...) : Set<E> from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation to private toSet(elements E...) : Set<E> from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation | From | To | |
| Move Method public testContainerAllocateWithLabels() : void from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation to public testContainerAllocateWithLabels() : void from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation | From | To | |
| Pull Up Attribute | 2 | ||
| Pull Up Attribute private NULL_ASSIGNMENT : CSAssignment from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue to package NULL_ASSIGNMENT : CSAssignment from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractCSQueue | From | To | |
| Pull Up Attribute private SKIP_ASSIGNMENT : CSAssignment from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue to package SKIP_ASSIGNMENT : CSAssignment from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractCSQueue | From | To | |
| Extract Class | 1 | ||
| Extract Class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation | From | To | |
| Parameterize Variable | 2 | ||
| Parameterize Variable label : String to nodePartition : String in method package canAssignToThisQueue(clusterResource Resource, nodePartition String, currentResourceLimits ResourceLimits, nowRequired Resource, resourceCouldBeUnreserved Resource, schedulingMode SchedulingMode) : boolean in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractCSQueue | From | To | |
| Parameterize Variable label : String to nodePartition : String in method protected canAssignToUser(clusterResource Resource, userName String, limit Resource, application FiCaSchedulerApp, checkReservations boolean, nodePartition String) : boolean in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue | From | To | |
| Extract Variable | 2 | ||
| Extract Variable decreasedResource : Resource in method public updateResourceRequests(requests List<ResourceRequest>, recoverPreemptedRequest boolean) : void from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.AppSchedulingInfo | From | To | |
| Extract Variable increasedResource : Resource in method public updateResourceRequests(requests List<ResourceRequest>, recoverPreemptedRequest boolean) : void from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.AppSchedulingInfo | From | To | |
| Extract Method | 2 | ||
| Extract Method public allocate(host String, memory int, numContainers int, priority int, releases List<ContainerId>, labelExpression String) : AllocateResponse extracted from public allocate(host String, memory int, numContainers int, releases List<ContainerId>, labelExpression String) : AllocateResponse in class org.apache.hadoop.yarn.server.resourcemanager.MockAM | From | To | |
| Extract Method public waitForState(nms Collection<MockNM>, containerId ContainerId, containerState RMContainerState, timeoutMillisecs int) : boolean extracted from public waitForState(nm MockNM, containerId ContainerId, containerState RMContainerState, timeoutMillisecs int) : boolean in class org.apache.hadoop.yarn.server.resourcemanager.MockRM | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter nodeLabel : String to nodePartition : String in method private getCurrentLimitResource(nodePartition String, clusterResource Resource, currentResourceLimits ResourceLimits, schedulingMode SchedulingMode) : Resource in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractCSQueue | From | To | |
| Rename Parameter nodeLabels : Set<String> to nodePartition : String in method package releaseResource(clusterResource Resource, application FiCaSchedulerApp, resource Resource, nodePartition String) : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue | From | To | |
| Rename Parameter nodeLabels : Set<String> to nodePartition : String in method package allocateResource(clusterResource Resource, application SchedulerApplicationAttempt, resource Resource, nodePartition String) : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue | From | To |