102b56ee96f0723dcc97d7f51b9ee910d8cd782b
Files Diff
- Added: 4
- Removed: 3
- Renamed: 0
- Modified: 3
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method public write(clusterId String, userId String, flowName String, flowVersion String, flowRunId long, appId String, entities TimelineEntities) : TimelineWriteResponse renamed to public writeAggregatedEntity(context TimelineCollectorContext, entities TimelineEntities, info OfflineAggregationInfo) : TimelineWriteResponse in class org.apache.hadoop.yarn.server.timelineservice.storage.PhoenixOfflineAggregationWriterImpl | From | To | |
| Rename Method private storeEvents(entity TimelineEntity, context TimelineCollectorContext, conn Connection) : void renamed to private storeEntityVariableLengthFields(entity TimelineEntity, formattedMetrics Map<String,TimelineMetric>, context TimelineCollectorContext, conn Connection, aggregationInfo OfflineAggregationInfo) : void in class org.apache.hadoop.yarn.server.timelineservice.storage.PhoenixOfflineAggregationWriterImpl | From | To | |
| Rename Variable | 4 | ||
| Rename Variable sqlEvents : String to sqlVariableLengthFields : String in method private storeEntityVariableLengthFields(entity TimelineEntity, formattedMetrics Map<String,TimelineMetric>, context TimelineCollectorContext, conn Connection, aggregationInfo OfflineAggregationInfo) : void in class org.apache.hadoop.yarn.server.timelineservice.storage.PhoenixOfflineAggregationWriterImpl | From | To | |
| Rename Variable psEvent : PreparedStatement to psVariableLengthFields : PreparedStatement in method private storeEntityVariableLengthFields(entity TimelineEntity, formattedMetrics Map<String,TimelineMetric>, context TimelineCollectorContext, conn Connection, aggregationInfo OfflineAggregationInfo) : void in class org.apache.hadoop.yarn.server.timelineservice.storage.PhoenixOfflineAggregationWriterImpl | From | To | |
| Rename Variable sqlColumns : StringBuilder to columnDefs : StringBuilder in method private storeEntityVariableLengthFields(entity TimelineEntity, formattedMetrics Map<String,TimelineMetric>, context TimelineCollectorContext, conn Connection, aggregationInfo OfflineAggregationInfo) : void in class org.apache.hadoop.yarn.server.timelineservice.storage.PhoenixOfflineAggregationWriterImpl | From | To | |
| Rename Variable currContext : TimelineCollectorContext to formattedMetrics : HashMap<String,TimelineMetric> in method public writeAggregatedEntity(context TimelineCollectorContext, entities TimelineEntities, info OfflineAggregationInfo) : TimelineWriteResponse in class org.apache.hadoop.yarn.server.timelineservice.storage.PhoenixOfflineAggregationWriterImpl | From | To | |
| Change Return Type | 1 | ||
| Change Return Type PhoenixTimelineWriterImpl to PhoenixOfflineAggregationWriterImpl in method private setupPhoenixClusterAndWriterForTest(conf YarnConfiguration) : PhoenixOfflineAggregationWriterImpl in class org.apache.hadoop.yarn.server.timelineservice.storage.TestPhoenixOfflineAggregationWriterImpl | From | To | |
| Rename Class | 2 | ||
| Rename Class org.apache.hadoop.yarn.server.timelineservice.storage.TestPhoenixTimelineWriterImpl renamed to org.apache.hadoop.yarn.server.timelineservice.storage.TestPhoenixOfflineAggregationWriterImpl | From | To | |
| Rename Class org.apache.hadoop.yarn.server.timelineservice.storage.PhoenixTimelineWriterImpl renamed to org.apache.hadoop.yarn.server.timelineservice.storage.PhoenixOfflineAggregationWriterImpl | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.apache.hadoop.yarn.server.timelineservice.storage.OfflineAggregationWriter from classes [org.apache.hadoop.yarn.server.timelineservice.storage.PhoenixOfflineAggregationWriterImpl] | From | To | |
| Rename Attribute | 3 | ||
| Rename Attribute EVENT_INFO_COLUMN_FAMILY : String to METRIC_COLUMN_FAMILY : String in class org.apache.hadoop.yarn.server.timelineservice.storage.PhoenixOfflineAggregationWriterImpl | From | To | |
| Rename Attribute PHOENIX_STORAGE_SEPARATOR : String to AGGREGATION_STORAGE_SEPARATOR : String in class org.apache.hadoop.yarn.server.timelineservice.storage.PhoenixOfflineAggregationWriterImpl | From | To | |
| Rename Attribute writer : PhoenixTimelineWriterImpl to storage : PhoenixOfflineAggregationWriterImpl in class org.apache.hadoop.yarn.server.timelineservice.storage.TestPhoenixOfflineAggregationWriterImpl | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type currContext : TimelineCollectorContext to formattedMetrics : HashMap<String,TimelineMetric> in method public writeAggregatedEntity(context TimelineCollectorContext, entities TimelineEntities, info OfflineAggregationInfo) : TimelineWriteResponse in class org.apache.hadoop.yarn.server.timelineservice.storage.PhoenixOfflineAggregationWriterImpl | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type writer : PhoenixTimelineWriterImpl to storage : PhoenixOfflineAggregationWriterImpl in class org.apache.hadoop.yarn.server.timelineservice.storage.TestPhoenixOfflineAggregationWriterImpl | From | To | |
| Inline Variable | 1 | ||
| Inline Variable configKeys : String in method public write(clusterId String, userId String, flowName String, flowVersion String, flowRunId long, appId String, entities TimelineEntities) : TimelineWriteResponse from class org.apache.hadoop.yarn.server.timelineservice.storage.PhoenixTimelineWriterImpl | From | To |