121865c3f96166e2190ed54b433ebcf8d053b91c
Files Diff
- Added: 3
- Removed: 0
- Renamed: 0
- Modified: 18
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move Method | 2 | ||
| Move Method private stabilizeComponents(context ServiceContext) : void from class org.apache.hadoop.yarn.service.component.TestComponent to private stabilizeComponents(context ServiceContext) : void from class org.apache.hadoop.yarn.service.MockRunningServiceContext | From | To | |
| Move Method private assignNewContainer(attemptId ApplicationAttemptId, containerNum long, context ServiceContext, component Component) : void from class org.apache.hadoop.yarn.service.component.TestComponent to public assignNewContainer(attemptId ApplicationAttemptId, containerNum long, component Component) : void from class org.apache.hadoop.yarn.service.MockRunningServiceContext | From | To | |
| Change Return Type | 1 | ||
| Change Return Type ServiceContext to MockRunningServiceContext in method public createTestContext(fsWatcher ServiceTestUtils.ServiceFSWatcher, serviceName String) : MockRunningServiceContext in class org.apache.hadoop.yarn.service.component.TestComponent | From | To | |
| Move Attribute | 3 | ||
| Move Attribute private COMP_JSON_SERDE : JsonSerDeser<Component[]> from class org.apache.hadoop.yarn.service.client.ApiServiceClient to public COMP_JSON_SERDE : JsonSerDeser<Component[]> from class org.apache.hadoop.yarn.service.utils.ServiceApiUtil | From | To | |
| Move Attribute private NODE_ID : NodeId from class org.apache.hadoop.yarn.service.component.TestComponent to private NODE_ID : NodeId from class org.apache.hadoop.yarn.service.MockRunningServiceContext | From | To | |
| Move Attribute private CONTAINER_JSON_SERDE : JsonSerDeser<Container[]> from class org.apache.hadoop.yarn.service.client.ApiServiceClient to public CONTAINER_JSON_SERDE : JsonSerDeser<Container[]> from class org.apache.hadoop.yarn.service.utils.ServiceApiUtil | From | To | |
| Extract Variable | 1 | ||
| Extract Variable appAttemptIdOrName : String in method public run(args String[]) : int from class org.apache.hadoop.yarn.client.cli.ApplicationCLI | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type context : ServiceContext to context : MockRunningServiceContext in method public testContainerCompletedWhenUpgrading() : void in class org.apache.hadoop.yarn.service.component.TestComponent | From | To | |
| Extract Method | 3 | ||
| Extract Method private appendUserNameIfRequired(builder StringBuilder) : void extracted from private getServicePath(appName String) : String in class org.apache.hadoop.yarn.service.client.ApiServiceClient | From | To | |
| Extract Method private appendUserNameIfRequired(builder StringBuilder) : void extracted from private getComponentsPath(appName String) : String in class org.apache.hadoop.yarn.service.client.ApiServiceClient | From | To | |
| Extract Method private appendUserNameIfRequired(builder StringBuilder) : void extracted from private getInstancesPath(appName String) : String in class org.apache.hadoop.yarn.service.client.ApiServiceClient | From | To |