12b7059ddc8d8f67dd7131565f03a0e09cb92ca7
Files Diff
- Added: 4
- Removed: 0
- Renamed: 0
- Modified: 26
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 2 | ||
| Change Parameter Type priority : Priority to requestKey : SchedulerRequestKey in method public recordSkippedAppActivityWithoutAllocation(activitiesManager ActivitiesManager, node SchedulerNode, application SchedulerApplicationAttempt, requestKey SchedulerRequestKey, diagnostic String) : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.activities.ActivitiesLogger.APP | From | To | |
| Change Parameter Type priority : Priority to schedulerKey : SchedulerRequestKey in method public recordAppActivityWithoutAllocation(activitiesManager ActivitiesManager, node SchedulerNode, application SchedulerApplicationAttempt, schedulerKey SchedulerRequestKey, diagnostic String, appState ActivityState) : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.activities.ActivitiesLogger.APP | From | To | |
| Move Method | 9 | ||
| Move Method private verifyNumberOfAllocations(json JSONObject, realValue int) : void from class org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesSchedulerActivitiesWithMultiNodesEnabled to public verifyNumberOfAllocations(json JSONObject, expectValue int) : void from class org.apache.hadoop.yarn.server.resourcemanager.webapp.ActivitiesTestUtils | From | To | |
| Move Method private getQueueOrder(node JSONObject) : String from class org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesSchedulerActivities to public getQueueOrder(node JSONObject) : String from class org.apache.hadoop.yarn.server.resourcemanager.webapp.ActivitiesTestUtils | From | To | |
| Move Method private verifyStateOfAllocations(allocation JSONObject, nameToCheck String, realState String) : void from class org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesSchedulerActivities to public verifyStateOfAllocations(allocation JSONObject, nameToCheck String, expectState String) : void from class org.apache.hadoop.yarn.server.resourcemanager.webapp.ActivitiesTestUtils | From | To | |
| Move Method private getNumberOfNodes(allocation JSONObject) : int from class org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesSchedulerActivities to public getNumberOfNodes(allocation JSONObject) : int from class org.apache.hadoop.yarn.server.resourcemanager.webapp.ActivitiesTestUtils | From | To | |
| Move Method private verifyStateOfAllocations(allocation JSONObject, nameToCheck String, realState String) : void from class org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesSchedulerActivitiesWithMultiNodesEnabled to public verifyStateOfAllocations(allocation JSONObject, nameToCheck String, expectState String) : void from class org.apache.hadoop.yarn.server.resourcemanager.webapp.ActivitiesTestUtils | From | To | |
| Move Method private verifyQueueOrder(json JSONObject, realOrder String) : void from class org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesSchedulerActivities to public verifyQueueOrder(json JSONObject, expectOrder String) : void from class org.apache.hadoop.yarn.server.resourcemanager.webapp.ActivitiesTestUtils | From | To | |
| Move Method private verifyNumberOfAllocationAttempts(allocation JSONObject, realValue int) : void from class org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesSchedulerActivities to public verifyNumberOfAllocationAttempts(allocation JSONObject, expectValue int) : void from class org.apache.hadoop.yarn.server.resourcemanager.webapp.ActivitiesTestUtils | From | To | |
| Move Method private verifyNumberOfNodes(allocation JSONObject, realValue int) : void from class org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesSchedulerActivities to public verifyNumberOfNodes(allocation JSONObject, expectValue int) : void from class org.apache.hadoop.yarn.server.resourcemanager.webapp.ActivitiesTestUtils | From | To | |
| Move Method private verifyNumberOfAllocations(json JSONObject, realValue int) : void from class org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesSchedulerActivities to public verifyNumberOfAllocations(json JSONObject, expectValue int) : void from class org.apache.hadoop.yarn.server.resourcemanager.webapp.ActivitiesTestUtils | From | To | |
| Move Attribute | 1 | ||
| Move Attribute protected allocationAttempt : List<ActivityNodeInfo> from class org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.AppAllocationInfo to private allocationAttempt : List<ActivityNodeInfo> from class org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.AppRequestAllocationInfo | From | To | |
| Extract Class | 2 | ||
| Extract Class org.apache.hadoop.yarn.server.resourcemanager.webapp.ActivitiesTestUtils from class org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesSchedulerActivitiesWithMultiNodesEnabled | From | To | |
| Extract Class org.apache.hadoop.yarn.server.resourcemanager.webapp.ActivitiesTestUtils from class org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesSchedulerActivities | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type attempt : ActivityNode to requestActivityNodes : List<ActivityNode> in method package AppAllocationInfo(allocation AppAllocation) in class org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.AppAllocationInfo | From | To | |
| Change Variable Type containerInfo : ActivityNodeInfo to requestAllocationInfo : AppRequestAllocationInfo in method package AppAllocationInfo(allocation AppAllocation) in class org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.AppAllocationInfo | From | To | |
| Extract Variable | 1 | ||
| Extract Variable containerPriorityStr : String in method public recordAppActivityWithAllocation(activitiesManager ActivitiesManager, node SchedulerNode, application SchedulerApplicationAttempt, updatedContainer RMContainer, activityState ActivityState) : void from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.activities.ActivitiesLogger.APP | From | To | |
| Extract Method | 3 | ||
| Extract Method public canSatisfyConstraints(applicationId ApplicationId, request SchedulingRequest, schedulerNode SchedulerNode, pcm PlacementConstraintManager, atm AllocationTagsManager, dcOpt Optional<DiagnosticsCollector>) : boolean extracted from public canSatisfyConstraints(applicationId ApplicationId, request SchedulingRequest, schedulerNode SchedulerNode, pcm PlacementConstraintManager, atm AllocationTagsManager) : boolean in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.constraint.PlacementConstraintsUtil | From | To | |
| Extract Method public precheckNode(schedulerNode SchedulerNode, schedulingMode SchedulingMode, dcOpt Optional<DiagnosticsCollector>) : boolean extracted from public precheckNode(schedulerNode SchedulerNode, schedulingMode SchedulingMode) : boolean in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.placement.SingleConstraintAppPlacementAllocator | From | To | |
| Extract Method public precheckNode(schedulerNode SchedulerNode, schedulingMode SchedulingMode, dcOpt Optional<DiagnosticsCollector>) : boolean extracted from public precheckNode(schedulerNode SchedulerNode, schedulingMode SchedulingMode) : boolean in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.placement.LocalityAppPlacementAllocator | From | To | |
| Rename Method | 1 | ||
| Rename Method private getPriority(node ActivityNode) : void renamed to private setPriority(node ActivityNode) : void in class org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.ActivityNodeInfo | From | To | |
| Rename Variable | 3 | ||
| Rename Variable containerInfo : ActivityNodeInfo to requestAllocationInfo : AppRequestAllocationInfo in method package AppAllocationInfo(allocation AppAllocation) in class org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.AppAllocationInfo | From | To | |
| Rename Variable allocationAttempts : JSONArray to allocationAttemptArray : JSONArray in method public testAppAssignContainer() : void in class org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesSchedulerActivitiesWithMultiNodesEnabled | From | To | |
| Rename Variable attempt : ActivityNode to requestActivityNodes : List<ActivityNode> in method package AppAllocationInfo(allocation AppAllocation) in class org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.AppAllocationInfo | From | To | |
| Change Return Type | 1 | ||
| Change Return Type String to NodeId in method public getNodeId() : NodeId in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.activities.NodeAllocation | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute allocationAttempt : List<ActivityNodeInfo> to requestAllocation : List<AppRequestAllocationInfo> in class org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.AppAllocationInfo | From | To | |
| Rename Attribute timeStamp : String to timestamp : long in class org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.AppAllocationInfo | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type allocationAttempt : List<ActivityNodeInfo> to requestAllocation : List<AppRequestAllocationInfo> in class org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.AppAllocationInfo | From | To | |
| Change Attribute Type timeStamp : String to timestamp : long in class org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.AppAllocationInfo | From | To | |
| Rename Parameter | 9 | ||
| Rename Parameter realValue : int to expectValue : int in method public verifyNumberOfNodes(allocation JSONObject, expectValue int) : void in class org.apache.hadoop.yarn.server.resourcemanager.webapp.ActivitiesTestUtils | From | To | |
| Rename Parameter realState : String to expectState : String in method public verifyStateOfAllocations(allocation JSONObject, nameToCheck String, expectState String) : void in class org.apache.hadoop.yarn.server.resourcemanager.webapp.ActivitiesTestUtils | From | To | |
| Rename Parameter priority : Priority to schedulerKey : SchedulerRequestKey in method public recordAppActivityWithoutAllocation(activitiesManager ActivitiesManager, node SchedulerNode, application SchedulerApplicationAttempt, schedulerKey SchedulerRequestKey, diagnostic String, appState ActivityState) : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.activities.ActivitiesLogger.APP | From | To | |
| Rename Parameter realValue : int to expectValue : int in method public verifyNumberOfAllocationAttempts(allocation JSONObject, expectValue int) : void in class org.apache.hadoop.yarn.server.resourcemanager.webapp.ActivitiesTestUtils | From | To | |
| Rename Parameter realOrder : String to expectOrder : String in method public verifyQueueOrder(json JSONObject, expectOrder String) : void in class org.apache.hadoop.yarn.server.resourcemanager.webapp.ActivitiesTestUtils | From | To | |
| Rename Parameter realValue : int to expectValue : int in method public verifyNumberOfAllocations(json JSONObject, expectValue int) : void in class org.apache.hadoop.yarn.server.resourcemanager.webapp.ActivitiesTestUtils | From | To | |
| Rename Parameter priority : Priority to requestKey : SchedulerRequestKey in method public recordSkippedAppActivityWithoutAllocation(activitiesManager ActivitiesManager, node SchedulerNode, application SchedulerApplicationAttempt, requestKey SchedulerRequestKey, diagnostic String) : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.activities.ActivitiesLogger.APP | From | To |