13fa2d4e3e55a849dcd7e472750f3e0422cc2ac9
Files Diff
- Added: 3
- Removed: 2
- Renamed: 0
- Modified: 7
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 1 | ||
Rename Method private updateQuotas(userLimit int, userLimitFactor float, maxAppsForReservation int, maxAppsPerUserForReservation int) : void renamed to private updateApplicationAndUserLimits(userLimit int, userLimitFactor float, maxAppsForAutoCreatedQueues int, maxAppsPerUserForAutoCreatedQueues int) : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AutoCreatedLeafQueue | From | To | |
Pull Up Method | 4 | ||
Pull Up Method protected sumOfChildCapacities() : float from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.PlanQueue to protected sumOfChildCapacities() : float from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.ParentQueue | From | To | |
Pull Up Method public getUserLimitFactor() : float from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.PlanQueue to public getUserLimitFactor() : float from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractManagedParentQueue | From | To | |
Pull Up Method package addChildQueue(newQueue CSQueue) : void from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.PlanQueue to public addChildQueue(childQueue CSQueue) : void from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractManagedParentQueue | From | To | |
Pull Up Method package removeChildQueue(remQueue CSQueue) : void from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.PlanQueue to public removeChildQueue(childQueue CSQueue) : void from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractManagedParentQueue | From | To | |
Move And Rename Method | 1 | ||
Move And Rename Method public getUserLimitForReservation() : int from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.PlanQueue to public getUserLimitForAutoCreatedQueues() : int from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractManagedParentQueue | From | To | |
Change Parameter Type | 1 | ||
Change Parameter Type parent : PlanQueue to parent : AbstractManagedParentQueue in method public AutoCreatedLeafQueue(cs CapacitySchedulerContext, queueName String, parent AbstractManagedParentQueue) in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AutoCreatedLeafQueue | From | To | |
Pull Up Attribute | 2 | ||
Pull Up Attribute private userLimit : int from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.PlanQueue to private userLimit : int from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractManagedParentQueue | From | To | |
Pull Up Attribute private userLimitFactor : float from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.PlanQueue to private userLimitFactor : float from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractManagedParentQueue | From | To | |
Rename Class | 2 | ||
Rename Class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.ReservationQueue renamed to org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AutoCreatedLeafQueue | From | To | |
Rename Class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestReservationQueue renamed to org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestAutoCreatedLeafQueue | From | To | |
Extract Superclass | 1 | ||
Extract Superclass org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractManagedParentQueue from classes [org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.PlanQueue] | From | To | |
Rename Attribute | 1 | ||
Rename Attribute reservationQueue : ReservationQueue to autoCreatedLeafQueue : AutoCreatedLeafQueue in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestAutoCreatedLeafQueue | From | To | |
Change Variable Type | 14 | ||
Change Variable Type resQueue : ReservationQueue to resQueue : AutoCreatedLeafQueue in method package parseQueue(csContext CapacitySchedulerContext, conf CapacitySchedulerConfiguration, parent CSQueue, queueName String, queues Map<String,CSQueue>, oldQueues Map<String,CSQueue>, hook QueueHook) : CSQueue in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacitySchedulerQueueManager | From | To | |
Change Variable Type a1 : ReservationQueue to a1 : AutoCreatedLeafQueue in method public testRemoveQueue() : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerDynamicBehavior | From | To | |
Change Variable Type resQueue : ReservationQueue to resQueue : AutoCreatedLeafQueue in method protected addReservationQueue(planQueueName String, queue Queue, currResId String) : void in class org.apache.hadoop.yarn.server.resourcemanager.reservation.CapacitySchedulerPlanFollower | From | To | |
Change Variable Type newQueue : ReservationQueue to newQueue : AutoCreatedLeafQueue in method public addQueue(queue Queue) : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler | From | To | |
Change Variable Type disposableLeafQueue : ReservationQueue to disposableLeafQueue : AutoCreatedLeafQueue in method public removeQueue(queueName String) : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler | From | To | |
Change Variable Type defQ : ReservationQueue to defQ : AutoCreatedLeafQueue in method public testMoveAppToPlanQueue() : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerDynamicBehavior | From | To | |
Change Variable Type a2 : ReservationQueue to a2 : AutoCreatedLeafQueue in method public testRefreshQueuesWithReservations() : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerDynamicBehavior | From | To | |
Change Variable Type parentPlan : PlanQueue to parentPlan : AbstractManagedParentQueue in method public addQueue(queue Queue) : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler | From | To | |
Change Variable Type newQueue : ReservationQueue to newQueue : AutoCreatedLeafQueue in method public setEntitlement(inQueue String, entitlement QueueEntitlement) : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler | From | To | |
Change Variable Type a2 : ReservationQueue to a2 : AutoCreatedLeafQueue in method public testAddQueueFailCases() : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerDynamicBehavior | From | To | |
Change Variable Type a1 : ReservationQueue to a1 : AutoCreatedLeafQueue in method public testRefreshQueuesWithReservations() : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerDynamicBehavior | From | To | |
Change Variable Type defQueue : ReservationQueue to defQueue : AutoCreatedLeafQueue in method protected createDefaultReservationQueue(planQueueName String, queue Queue, defReservationId String) : void in class org.apache.hadoop.yarn.server.resourcemanager.reservation.CapacitySchedulerPlanFollower | From | To | |
Change Variable Type a1 : ReservationQueue to a1 : AutoCreatedLeafQueue in method public testAddQueueFailCases() : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerDynamicBehavior | From | To | |
Change Attribute Type | 2 | ||
Change Attribute Type parent : PlanQueue to parent : AbstractManagedParentQueue in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AutoCreatedLeafQueue | From | To | |
Change Attribute Type reservationQueue : ReservationQueue to autoCreatedLeafQueue : AutoCreatedLeafQueue in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestAutoCreatedLeafQueue | From | To | |
Extract Method | 2 | ||
Extract Method private validate(newlyParsedQueue CSQueue) : void extracted from public reinitialize(newlyParsedQueue CSQueue, clusterResource Resource) : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AutoCreatedLeafQueue | From | To | |
Extract Method private validate(newlyParsedQueue CSQueue) : void extracted from public reinitialize(newlyParsedQueue CSQueue, clusterResource Resource) : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.PlanQueue | From | To | |
Rename Parameter | 3 | ||
Rename Parameter remQueue : CSQueue to childQueue : CSQueue in method public removeChildQueue(childQueue CSQueue) : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractManagedParentQueue | From | To | |
Rename Parameter maxAppsForReservation : int to maxAppsForAutoCreatedQueues : int in method private updateApplicationAndUserLimits(userLimit int, userLimitFactor float, maxAppsForAutoCreatedQueues int, maxAppsPerUserForAutoCreatedQueues int) : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AutoCreatedLeafQueue | From | To | |
Rename Parameter newQueue : CSQueue to childQueue : CSQueue in method public addChildQueue(childQueue CSQueue) : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractManagedParentQueue | From | To |