1afba83f2cd74ae54b558101d235f237ccf454c0
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 12
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method package getLastSuccessfulFlushIndex() : int renamed to package getWrittenDataLength() : long in class org.apache.hadoop.ozone.client.io.ChunkGroupOutputStream.ChunkOutputStreamEntry | From | To | |
| Change Parameter Type | 5 | ||
| Change Parameter Type len : int to len : long in method public writeOnRetry(len long) : void in class org.apache.hadoop.hdds.scm.storage.ChunkOutputStream | From | To | |
| Change Parameter Type len : int to len : long in method package writeOnRetry(len long) : void in class org.apache.hadoop.ozone.client.io.ChunkGroupOutputStream.ChunkOutputStreamEntry | From | To | |
| Change Parameter Type buffer : ByteBuffer to bufferList : List<ByteBuffer> in method public ChunkOutputStream(blockID BlockID, key String, xceiverClientManager XceiverClientManager, xceiverClient XceiverClientSpi, traceID String, chunkSize int, streamBufferFlushSize long, streamBufferMaxSize long, watchTimeout long, bufferList List<ByteBuffer>, checksum Checksum) in class org.apache.hadoop.hdds.scm.storage.ChunkOutputStream | From | To | |
| Change Parameter Type len : int to len : long in method private handleWrite(b byte[], off int, len long, retry boolean) : void in class org.apache.hadoop.ozone.client.io.ChunkGroupOutputStream | From | To | |
| Change Parameter Type buffer : ByteBuffer to bufferList : List<ByteBuffer> in method package ChunkOutputStreamEntry(blockID BlockID, key String, xceiverClientManager XceiverClientManager, xceiverClient XceiverClientSpi, requestId String, chunkSize int, length long, streamBufferFlushSize long, streamBufferMaxSize long, watchTimeout long, bufferList List<ByteBuffer>, checksum Checksum) in class org.apache.hadoop.ozone.client.io.ChunkGroupOutputStream.ChunkOutputStreamEntry | From | To | |
| Change Return Type | 3 | ||
| Change Return Type int to long in method package getWrittenDataLength() : long in class org.apache.hadoop.ozone.client.io.ChunkGroupOutputStream.ChunkOutputStreamEntry | From | To | |
| Change Return Type void to long in method public abstract watchForCommit(index long, timeout long) : long in class org.apache.hadoop.hdds.scm.XceiverClientSpi | From | To | |
| Change Return Type void to long in method public watchForCommit(index long, timeout long) : long in class org.apache.hadoop.hdds.scm.XceiverClientRatis | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable sce : StorageContainerException to e : Exception in method private setIoException(e Exception) : void in class org.apache.hadoop.hdds.scm.storage.ChunkOutputStream | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute raftClient : RaftClient to watchClient : RaftClient in method public watchForCommit(index long, timeout long) : long in class org.apache.hadoop.hdds.scm.XceiverClientRatis | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute buffer : ByteBuffer to bufferList : List<ByteBuffer> in class org.apache.hadoop.ozone.client.io.ChunkGroupOutputStream | From | To | |
| Rename Attribute buffer : ByteBuffer to bufferList : List<ByteBuffer> in class org.apache.hadoop.ozone.client.io.ChunkGroupOutputStream.ChunkOutputStreamEntry | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type writeLen : int to writeLen : long in method public writeOnRetry(len long) : void in class org.apache.hadoop.hdds.scm.storage.ChunkOutputStream | From | To | |
| Change Variable Type sce : StorageContainerException to e : Exception in method private setIoException(e Exception) : void in class org.apache.hadoop.hdds.scm.storage.ChunkOutputStream | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type buffer : ByteBuffer to bufferList : List<ByteBuffer> in class org.apache.hadoop.ozone.client.io.ChunkGroupOutputStream | From | To | |
| Change Attribute Type buffer : ByteBuffer to bufferList : List<ByteBuffer> in class org.apache.hadoop.ozone.client.io.ChunkGroupOutputStream.ChunkOutputStreamEntry | From | To | |
| Extract Method | 4 | ||
| Extract Method private allocateBuffer() : void extracted from public write(b byte[], off int, len int) : void in class org.apache.hadoop.hdds.scm.storage.ChunkOutputStream | From | To | |
| Extract Method private waitOnFlushFutures() : void extracted from public close() : void in class org.apache.hadoop.hdds.scm.storage.ChunkOutputStream | From | To | |
| Extract Method private waitOnFlushFutures() : void extracted from public flush() : void in class org.apache.hadoop.hdds.scm.storage.ChunkOutputStream | From | To | |
| Extract Method private setIoException(e Exception) : void extracted from private validateResponse(responseProto ContainerProtos.ContainerCommandResponseProto) : void in class org.apache.hadoop.hdds.scm.storage.ChunkOutputStream | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter buffer : ByteBuffer to bufferList : List<ByteBuffer> in method public ChunkOutputStream(blockID BlockID, key String, xceiverClientManager XceiverClientManager, xceiverClient XceiverClientSpi, traceID String, chunkSize int, streamBufferFlushSize long, streamBufferMaxSize long, watchTimeout long, bufferList List<ByteBuffer>, checksum Checksum) in class org.apache.hadoop.hdds.scm.storage.ChunkOutputStream | From | To | |
| Rename Parameter buffer : ByteBuffer to bufferList : List<ByteBuffer> in method package ChunkOutputStreamEntry(blockID BlockID, key String, xceiverClientManager XceiverClientManager, xceiverClient XceiverClientSpi, requestId String, chunkSize int, length long, streamBufferFlushSize long, streamBufferMaxSize long, watchTimeout long, bufferList List<ByteBuffer>, checksum Checksum) in class org.apache.hadoop.ozone.client.io.ChunkGroupOutputStream.ChunkOutputStreamEntry | From | To |