1e1e93040748231dc913190aec1e031c379d8271
Files Diff
- Added: 1
- Removed: 1
- Renamed: 0
- Modified: 16
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 6 | ||
| Rename Method public getLastAllocatedBlockId() : long renamed to public getLastAllocatedContiguousBlockId() : long in class org.apache.hadoop.hdfs.server.blockmanagement.BlockIdManager | From | To | |
| Rename Method package addBlock(newblock BlockInfoContiguous) : void renamed to private addContiguousBlock(newblock BlockInfoContiguous) : void in class org.apache.hadoop.hdfs.server.namenode.INodeFile | From | To | |
| Rename Method public nextBlockId() : long renamed to public nextContiguousBlockId() : long in class org.apache.hadoop.hdfs.server.blockmanagement.BlockIdManager | From | To | |
| Rename Method public nextBlockGroupId() : long renamed to public nextStripedBlockId() : long in class org.apache.hadoop.hdfs.server.blockmanagement.BlockIdManager | From | To | |
| Rename Method public setLastAllocatedBlockId(blockId long) : void renamed to public setLastAllocatedContiguousBlockId(blockId long) : void in class org.apache.hadoop.hdfs.server.blockmanagement.BlockIdManager | From | To | |
| Rename Method public convertToGroupID(id long) : long renamed to public convertToStripedID(id long) : long in class org.apache.hadoop.hdfs.server.blockmanagement.BlockIdManager | From | To | |
| Rename Variable | 2 | ||
| Rename Variable penultimateBlockMinReplication : boolean to penultimateBlockMinStorage : boolean in method package internalReleaseLease(lease Lease, src String, iip INodesInPath, recoveryLeaseHolder String) : boolean in class org.apache.hadoop.hdfs.server.namenode.FSNamesystem | From | To | |
| Rename Variable newBI : BlockInfoContiguous to newBlockInfo : BlockInfo in method private addNewBlock(op AddBlockOp, file INodeFile, isStriped boolean) : void in class org.apache.hadoop.hdfs.server.namenode.FSEditLogLoader | From | To | |
| Parameterize Variable | 3 | ||
| Parameterize Variable lastBlock : BlockInfo to block : BlockInfo in method public checkMinStorage(block BlockInfo) : boolean in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager | From | To | |
| Parameterize Variable numCurrentReplica : int to liveNum : int in method public checkMinStorage(block BlockInfo, liveNum int) : boolean in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager | From | To | |
| Parameterize Variable numLiveReplicas : int to liveNum : int in method public checkMinStorage(block BlockInfo, liveNum int) : boolean in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type block : BlockInfoContiguous to block : BlockInfo in method private processBlocksForDecomInternal(datanode DatanodeDescriptor, it Iterator<BlockInfoContiguous>, insufficientlyReplicated List<BlockInfoContiguous>, pruneSufficientlyReplicated boolean) : void in class org.apache.hadoop.hdfs.server.blockmanagement.DecommissionManager.Monitor | From | To | |
| Change Variable Type newBI : BlockInfoContiguous to newBlockInfo : BlockInfo in method private addNewBlock(op AddBlockOp, file INodeFile, isStriped boolean) : void in class org.apache.hadoop.hdfs.server.namenode.FSEditLogLoader | From | To | |
| Change Variable Type oldLastBlock : Block to oldLastBlock : BlockInfo in method private addNewBlock(op AddBlockOp, file INodeFile, isStriped boolean) : void in class org.apache.hadoop.hdfs.server.namenode.FSEditLogLoader | From | To | |
| Extract Variable | 1 | ||
| Extract Variable size : int in method package removeBlock(block Block) : void from class org.apache.hadoop.hdfs.server.blockmanagement.BlocksMap | From | To | |
| Extract Method | 4 | ||
| Extract Method public checkMinStorage(block BlockInfo, liveNum int) : boolean extracted from private addStoredBlockImmediate(storedBlock BlockInfo, reported Block, storageInfo DatanodeStorageInfo) : void in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager | From | To | |
| Extract Method public checkMinStorage(block BlockInfo, liveNum int) : boolean extracted from private markBlockAsCorrupt(b BlockToMarkCorrupt, storageInfo DatanodeStorageInfo, node DatanodeDescriptor) : void in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager | From | To | |
| Extract Method public checkMinStorage(block BlockInfo) : boolean extracted from public commitOrCompleteLastBlock(bc BlockCollection, commitBlock Block) : boolean in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager | From | To | |
| Extract Method public checkMinStorage(block BlockInfo, liveNum int) : boolean extracted from private addStoredBlock(block BlockInfo, reportedBlock Block, storageInfo DatanodeStorageInfo, delNodeHint DatanodeDescriptor, logEveryBlock boolean) : Block in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager | From | To | |
| Extract And Move Method | 3 | ||
| Extract And Move Method public checkMinStorage(block BlockInfo, liveNum int) : boolean extracted from package removeBlocksAndUpdateSafemodeTotal(blocks BlocksMapUpdateInfo) : void in class org.apache.hadoop.hdfs.server.namenode.FSNamesystem & moved to class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter storedBlock : BlockInfo to block : BlockInfo in method public checkMinStorage(block BlockInfo, liveNum int) : boolean in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager | From | To |