hadoop 2191f5b533c6b4763f5d443d21127f1f8552ce64

2191f5b533c6b4763f5d443d21127f1f8552ce64

Files Diff

Added: 95
Removed: 435
Renamed: 0
Modified: 57

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	4
Rename Method private getAppIdFromPersistedApp(appName String) : ApplicationId renamed to private getAppId(appName String) : ApplicationId in class org.apache.hadoop.yarn.service.client.ServiceClient	From	To
Rename Method public getSliderVersion() : Response renamed to public getVersion() : Response in class org.apache.hadoop.yarn.service.webapp.ApplicationApiService	From	To
Rename Method private publishConfigurations(iterator Iterator<Entry<String,String>>, entityId String, entityType String) : void renamed to private populateTimelineEntity(iterator Iterator<Entry<String,String>>, entityId String, entityType String) : void in class org.apache.hadoop.yarn.service.timelineservice.ServiceTimelinePublisher	From	To
Rename Method private createMockAppState() : AppState renamed to private createMockApplication() : Application in class org.apache.hadoop.yarn.service.timelineservice.TestServiceTimelinePublisher	From	To
Change Parameter Type	4
Change Parameter Type conf : org.apache.slider.api.resource.Configuration to conf : org.apache.hadoop.yarn.service.api.records.Configuration in method public buildEnvMap(conf org.apache.hadoop.yarn.service.api.records.Configuration, tokenMap Map<String,String>) : Map<String,String> in class org.apache.hadoop.yarn.service.utils.SliderUtils	From	To
Change Parameter Type component : org.apache.slider.api.resource.Component to component : org.apache.hadoop.yarn.service.api.records.Component in method public Component(component org.apache.hadoop.yarn.service.api.records.Component, allocateId long, context ServiceContext) in class org.apache.hadoop.yarn.service.component.Component	From	To
Change Parameter Type launcher : ContainerLauncher to launcher : AbstractLauncher in method public localizeServiceKeytabs(launcher AbstractLauncher, fileSystem SliderFileSystem, application Application) : void in class org.apache.hadoop.yarn.service.provider.ProviderUtils	From	To
Change Parameter Type conf : org.apache.slider.api.resource.Configuration to conf : org.apache.hadoop.yarn.service.api.records.Configuration in method private setUserProvidedServiceRecordAttributes(conf org.apache.hadoop.yarn.service.api.records.Configuration, record ServiceRecord) : void in class org.apache.hadoop.yarn.service.ServiceScheduler	From	To
Rename Variable	4
Rename Variable hasSliderAMLog4j : boolean to hasAMLog4j : boolean in method private addAMLog4jResource(appName String, conf Configuration, localResources Map<String,LocalResource>) : boolean in class org.apache.hadoop.yarn.service.client.ServiceClient	From	To
Rename Variable appState : AppState to context : ServiceContext in method public testServiceAttemptEntity() : void in class org.apache.hadoop.yarn.service.timelineservice.TestServiceTimelinePublisher	From	To
Rename Variable proxy : ClientAMProtocol to amProxy : ClientAMProtocol in method public getStatus(appName String) : Application in class org.apache.hadoop.yarn.service.client.ServiceClient	From	To
Rename Variable hasSliderAMLog4j : boolean to hasAMLog4j : boolean in method private submitApp(app Application) : ApplicationId in class org.apache.hadoop.yarn.service.client.ServiceClient	From	To
Change Return Type	3
Change Return Type AppState to Application in method private createMockApplication() : Application in class org.apache.hadoop.yarn.service.timelineservice.TestServiceTimelinePublisher	From	To
Change Return Type org.apache.slider.api.resource.Component to org.apache.hadoop.yarn.service.api.records.Component in method public getComponentSpec() : org.apache.hadoop.yarn.service.api.records.Component in class org.apache.hadoop.yarn.service.component.Component	From	To
Change Return Type org.apache.slider.api.resource.Component to org.apache.hadoop.yarn.service.api.records.Component in method public getCompSpec() : org.apache.hadoop.yarn.service.api.records.Component in class org.apache.hadoop.yarn.service.compinstance.ComponentInstance	From	To
Move Attribute	5
Move Attribute public KEY_HDFS_KEYTAB_DIR : String from class org.apache.hadoop.yarn.service.conf.SliderXmlConfKeys to public KEY_HDFS_KEYTAB_DIR : String from class org.apache.hadoop.yarn.service.conf.YarnServiceConf	From	To
Move Attribute public KEY_AM_KEYTAB_LOCAL_PATH : String from class org.apache.hadoop.yarn.service.conf.SliderXmlConfKeys to public KEY_AM_KEYTAB_LOCAL_PATH : String from class org.apache.hadoop.yarn.service.conf.YarnServiceConf	From	To
Move Attribute public DEFAULT_KEY_AM_RESOURCE_MEM : long from class org.apache.hadoop.yarn.service.conf.SliderXmlConfKeys to public DEFAULT_KEY_AM_RESOURCE_MEM : long from class org.apache.hadoop.yarn.service.conf.YarnServiceConf	From	To
Move Attribute public KEY_AM_LOGIN_KEYTAB_REQUIRED : String from class org.apache.hadoop.yarn.service.conf.SliderXmlConfKeys to public KEY_AM_LOGIN_KEYTAB_REQUIRED : String from class org.apache.hadoop.yarn.service.conf.YarnServiceConf	From	To
Move Attribute public KEY_AM_LOGIN_KEYTAB_NAME : String from class org.apache.hadoop.yarn.service.conf.SliderXmlConfKeys to public KEY_AM_LOGIN_KEYTAB_NAME : String from class org.apache.hadoop.yarn.service.conf.YarnServiceConf	From	To
Move Class	89
Move Class org.apache.slider.api.resource.ReadinessCheck moved to org.apache.hadoop.yarn.service.api.records.ReadinessCheck	From	To
Move Class org.apache.slider.common.tools.PortScanner moved to org.apache.hadoop.yarn.service.utils.PortScanner	From	To
Move Class org.apache.hadoop.yarn.service.ContainerLaunchService moved to org.apache.hadoop.yarn.service.containerlaunch.ContainerLaunchService	From	To
Move Class org.apache.slider.common.params.ActionListArgs moved to org.apache.hadoop.yarn.service.client.params.ActionListArgs	From	To
Move Class org.apache.slider.common.params.ActionTokensArgs moved to org.apache.hadoop.yarn.service.client.params.ActionTokensArgs	From	To
Move Class org.apache.slider.api.resource.Artifact moved to org.apache.hadoop.yarn.service.api.records.Artifact	From	To
Move Class org.apache.hadoop.yarn.services.webapp.ApplicationApiWebApp moved to org.apache.hadoop.yarn.service.webapp.ApplicationApiWebApp	From	To
Move Class org.apache.slider.server.servicemonitor.ProbeStatus moved to org.apache.hadoop.yarn.service.servicemonitor.probe.ProbeStatus	From	To
Move Class org.apache.slider.common.tools.SliderUtils moved to org.apache.hadoop.yarn.service.utils.SliderUtils	From	To
Move Class org.apache.slider.core.exceptions.ErrorStrings moved to org.apache.hadoop.yarn.service.exceptions.ErrorStrings	From	To
Move Class org.apache.slider.common.params.AbstractArgsDelegate moved to org.apache.hadoop.yarn.service.client.params.AbstractArgsDelegate	From	To
Move Class org.apache.slider.core.persist.JsonSerDeser moved to org.apache.hadoop.yarn.service.utils.JsonSerDeser	From	To
Move Class org.apache.slider.core.registry.info.CustomRegistryConstants moved to org.apache.hadoop.yarn.service.registry.CustomRegistryConstants	From	To
Move Class org.apache.slider.core.exceptions.ExceptionConverter moved to org.apache.hadoop.yarn.service.rest.ExceptionConverter	From	To
Move Class org.apache.hadoop.yarn.services.api.impl.ApplicationApiService moved to org.apache.hadoop.yarn.service.webapp.ApplicationApiService	From	To
Move Class org.apache.slider.common.params.ActionStatusArgs moved to org.apache.hadoop.yarn.service.client.params.ActionStatusArgs	From	To
Move Class org.apache.slider.common.params.ActionKDiagArgs moved to org.apache.hadoop.yarn.service.client.params.ActionKDiagArgs	From	To
Move Class org.apache.slider.core.launch.ClasspathConstructor moved to org.apache.hadoop.yarn.service.containerlaunch.ClasspathConstructor	From	To
Move Class org.apache.slider.core.exceptions.SliderException moved to org.apache.hadoop.yarn.service.exceptions.SliderException	From	To
Move Class org.apache.slider.api.resource.Container moved to org.apache.hadoop.yarn.service.api.records.Container	From	To
Move Class org.apache.slider.core.persist.ApplicationReportSerDeser moved to org.apache.hadoop.yarn.service.utils.ApplicationReportSerDeser	From	To
Move Class org.apache.slider.server.servicemonitor.PortProbe moved to org.apache.hadoop.yarn.service.servicemonitor.probe.PortProbe	From	To
Move Class org.apache.slider.api.resource.PlacementPolicy moved to org.apache.hadoop.yarn.service.api.records.PlacementPolicy	From	To
Move Class org.apache.slider.core.launch.AbstractLauncher moved to org.apache.hadoop.yarn.service.containerlaunch.AbstractLauncher	From	To
Move Class org.apache.slider.core.exceptions.BadCommandArgumentsException moved to org.apache.hadoop.yarn.service.exceptions.BadCommandArgumentsException	From	To
Move Class org.apache.slider.core.restclient.UgiJerseyBinding moved to org.apache.hadoop.yarn.service.rest.UgiJerseyBinding	From	To
Move Class org.apache.slider.common.tools.Comparators moved to org.apache.hadoop.yarn.service.utils.Comparators	From	To
Move Class org.apache.slider.common.params.ActionRegistryArgs moved to org.apache.hadoop.yarn.service.client.params.ActionRegistryArgs	From	To
Move Class org.apache.slider.core.exceptions.BadClusterStateException moved to org.apache.hadoop.yarn.service.exceptions.BadClusterStateException	From	To
Move Class org.apache.slider.core.registry.docstore.PublishedConfiguration moved to org.apache.hadoop.yarn.service.utils.PublishedConfiguration	From	To
Move Class org.apache.slider.core.zk.ZookeeperUtils moved to org.apache.hadoop.yarn.service.utils.ZookeeperUtils	From	To
Move Class org.apache.slider.core.launch.CommandLineBuilder moved to org.apache.hadoop.yarn.service.containerlaunch.CommandLineBuilder	From	To
Move Class org.apache.slider.core.restclient.SliderURLConnectionFactory moved to org.apache.hadoop.yarn.service.rest.SliderURLConnectionFactory	From	To
Move Class org.apache.slider.api.resource.BaseResource moved to org.apache.hadoop.yarn.service.api.records.BaseResource	From	To
Move Class org.apache.slider.util.RestApiErrorMessages moved to org.apache.hadoop.yarn.service.exceptions.RestApiErrorMessages	From	To
Move Class org.apache.slider.common.params.WaitArgsDelegate moved to org.apache.hadoop.yarn.service.client.params.WaitArgsDelegate	From	To
Move Class org.apache.slider.api.resource.ContainerState moved to org.apache.hadoop.yarn.service.api.records.ContainerState	From	To
Move Class org.apache.slider.core.exceptions.BadConfigException moved to org.apache.hadoop.yarn.service.exceptions.BadConfigException	From	To
Move Class org.apache.slider.common.params.ActionFreezeArgs moved to org.apache.hadoop.yarn.service.client.params.ActionFreezeArgs	From	To
Move Class org.apache.slider.core.restclient.HttpVerb moved to org.apache.hadoop.yarn.service.rest.HttpVerb	From	To
Move Class org.apache.slider.core.launch.CredentialUtils moved to org.apache.hadoop.yarn.service.containerlaunch.CredentialUtils	From	To
Move Class org.apache.slider.client.rest.BaseRestClient moved to org.apache.hadoop.yarn.service.rest.BaseRestClient	From	To
Move Class org.apache.slider.api.resource.Component moved to org.apache.hadoop.yarn.service.api.records.Component	From	To
Move Class org.apache.slider.server.servicemonitor.HttpProbe moved to org.apache.hadoop.yarn.service.servicemonitor.probe.HttpProbe	From	To
Move Class org.apache.slider.common.tools.CoreFileSystem moved to org.apache.hadoop.yarn.service.utils.CoreFileSystem	From	To
Move Class org.apache.slider.common.params.ActionExistsArgs moved to org.apache.hadoop.yarn.service.client.params.ActionExistsArgs	From	To
Move Class org.apache.slider.client.ClientRegistryBinder moved to org.apache.hadoop.yarn.service.utils.ClientRegistryBinder	From	To
Move Class org.apache.slider.common.tools.SliderFileSystem moved to org.apache.hadoop.yarn.service.utils.SliderFileSystem	From	To
Move Class org.apache.slider.api.resource.Resource moved to org.apache.hadoop.yarn.service.api.records.Resource	From	To
Move Class org.apache.slider.common.params.LaunchArgsDelegate moved to org.apache.hadoop.yarn.service.client.params.LaunchArgsDelegate	From	To
Move Class org.apache.slider.common.params.ActionResolveArgs moved to org.apache.hadoop.yarn.service.client.params.ActionResolveArgs	From	To
Move Class org.apache.slider.common.params.PathArgumentConverter moved to org.apache.hadoop.yarn.service.client.params.PathArgumentConverter	From	To
Move Class org.apache.slider.api.resource.Application moved to org.apache.hadoop.yarn.service.api.records.Application	From	To
Move Class org.apache.slider.api.resource.Configuration moved to org.apache.hadoop.yarn.service.api.records.Configuration	From	To
Move Class org.apache.slider.core.registry.docstore.ConfigFormat moved to org.apache.hadoop.yarn.service.api.records.ConfigFormat	From	To
Move Class org.apache.slider.server.servicemonitor.Probe moved to org.apache.hadoop.yarn.service.servicemonitor.probe.Probe	From	To
Move Class org.apache.slider.common.tools.Duration moved to org.apache.hadoop.yarn.service.utils.Duration	From	To
Move Class org.apache.slider.common.tools.ConfigHelper moved to org.apache.hadoop.yarn.service.utils.ConfigHelper	From	To
Move Class org.apache.slider.api.resource.ConfigFile moved to org.apache.hadoop.yarn.service.api.records.ConfigFile	From	To
Move Class org.apache.slider.common.params.DontSplitArguments moved to org.apache.hadoop.yarn.service.client.params.DontSplitArguments	From	To
Move Class org.apache.slider.common.params.ActionThawArgs moved to org.apache.hadoop.yarn.service.client.params.ActionThawArgs	From	To
Move Class org.apache.slider.common.params.ActionClientArgs moved to org.apache.hadoop.yarn.service.client.params.ActionClientArgs	From	To
Move Class org.apache.slider.common.params.ActionHelpArgs moved to org.apache.hadoop.yarn.service.client.params.ActionHelpArgs	From	To
Move Class org.apache.slider.core.launch.JavaCommandLineBuilder moved to org.apache.hadoop.yarn.service.containerlaunch.JavaCommandLineBuilder	From	To
Move Class org.apache.slider.server.services.yarnregistry.YarnRegistryViewForProviders moved to org.apache.hadoop.yarn.service.registry.YarnRegistryViewForProviders	From	To
Move Class org.apache.slider.common.params.ActionKeytabArgs moved to org.apache.hadoop.yarn.service.client.params.ActionKeytabArgs	From	To
Move Class org.apache.slider.core.main.ExitCodeProvider moved to org.apache.hadoop.yarn.service.exceptions.ExitCodeProvider	From	To
Move Class org.apache.slider.core.registry.docstore.ConfigUtils moved to org.apache.hadoop.yarn.service.utils.ConfigUtils	From	To
Move Class org.apache.slider.api.resource.ApplicationState moved to org.apache.hadoop.yarn.service.api.records.ApplicationState	From	To
Move Class org.apache.slider.core.registry.docstore.PublishedConfigurationOutputter moved to org.apache.hadoop.yarn.service.utils.PublishedConfigurationOutputter	From	To
Move Class org.apache.slider.api.resource.ApplicationStatus moved to org.apache.hadoop.yarn.service.api.records.ApplicationStatus	From	To
Move Class org.apache.slider.core.launch.SerializedApplicationReport moved to org.apache.hadoop.yarn.service.utils.SerializedApplicationReport	From	To
Move Class org.apache.slider.api.ServiceApiConstants moved to org.apache.hadoop.yarn.service.api.constants.ServiceApiConstants	From	To
Move Class org.apache.slider.api.resource.Error moved to org.apache.hadoop.yarn.service.api.records.Error	From	To
Move Class org.apache.slider.common.params.ActionUpdateArgs moved to org.apache.hadoop.yarn.service.client.params.ActionUpdateArgs	From	To
Move Class org.apache.slider.server.services.utility.PatternValidator moved to org.apache.hadoop.yarn.service.utils.PatternValidator	From	To
Move Class org.apache.slider.core.main.ServiceLaunchException moved to org.apache.hadoop.yarn.service.exceptions.ServiceLaunchException	From	To
Move Class org.apache.slider.server.servicemonitor.MonitorKeys moved to org.apache.hadoop.yarn.service.servicemonitor.probe.MonitorKeys	From	To
Move Class org.apache.slider.common.params.ActionResourceArgs moved to org.apache.hadoop.yarn.service.client.params.ActionResourceArgs	From	To
Move Class org.apache.slider.core.restclient.UrlConnectionOperations moved to org.apache.hadoop.yarn.service.rest.UrlConnectionOperations	From	To
Move Class org.apache.slider.common.params.OptionArgsDelegate moved to org.apache.hadoop.yarn.service.client.params.OptionArgsDelegate	From	To
Move Class org.apache.slider.core.exceptions.UsageException moved to org.apache.hadoop.yarn.service.exceptions.UsageException	From	To
Move Class org.apache.slider.common.params.WaitTimeAccessor moved to org.apache.hadoop.yarn.service.client.params.WaitTimeAccessor	From	To
Move Class org.apache.slider.common.params.LaunchArgsAccessor moved to org.apache.hadoop.yarn.service.client.params.LaunchArgsAccessor	From	To
Move Class org.apache.hadoop.security.KerberosDiags moved to org.apache.hadoop.yarn.service.utils.KerberosDiags	From	To
Move Class org.apache.slider.server.servicemonitor.LogEntryBuilder moved to org.apache.hadoop.yarn.service.servicemonitor.probe.LogEntryBuilder	From	To
Move Class org.apache.slider.core.main.LauncherExitCodes moved to org.apache.hadoop.yarn.service.exceptions.LauncherExitCodes	From	To
Move Class org.apache.slider.server.servicemonitor.MonitorUtils moved to org.apache.hadoop.yarn.service.servicemonitor.probe.MonitorUtils	From	To
Move Class org.apache.hadoop.yarn.service.ServiceMonitor moved to org.apache.hadoop.yarn.service.servicemonitor.ServiceMonitor	From	To
Merge Variable	1
Merge Variable [exitCode : int, message : String] to exitDiags : String in method public testServiceAttemptEntity() : void in class org.apache.hadoop.yarn.service.timelineservice.TestServiceTimelinePublisher	From	To
Change Variable Type	6
Change Variable Type compSpec : org.apache.slider.api.resource.Component to compSpec : Component in method public run() : void in class org.apache.hadoop.yarn.service.containerlaunch.ContainerLaunchService.ContainerLauncher	From	To
Change Variable Type container : org.apache.slider.api.resource.Container to container : org.apache.hadoop.yarn.service.api.records.Container in method public transition(compInstance ComponentInstance, event ComponentInstanceEvent) : void in class org.apache.hadoop.yarn.service.compinstance.ComponentInstance.ContainerStartedTransition	From	To
Change Variable Type component : org.apache.slider.api.resource.Component to component : org.apache.hadoop.yarn.service.api.records.Component in method public getProgress() : float in class org.apache.hadoop.yarn.service.ServiceScheduler.AMRMClientCallback	From	To
Change Variable Type container : org.apache.slider.api.resource.Container to container : org.apache.hadoop.yarn.service.api.records.Container in method public updateContainerStatus(status ContainerStatus) : void in class org.apache.hadoop.yarn.service.compinstance.ComponentInstance	From	To
Change Variable Type appState : AppState to context : ServiceContext in method public testServiceAttemptEntity() : void in class org.apache.hadoop.yarn.service.timelineservice.TestServiceTimelinePublisher	From	To
Change Variable Type compSpec : org.apache.slider.api.resource.Component to compSpec : org.apache.hadoop.yarn.service.api.records.Component in method private createAllComponents() : void in class org.apache.hadoop.yarn.service.ServiceScheduler	From	To
Change Package	10
Change Package org.apache.slider.api.resource to org.apache.hadoop.yarn.service.api.records	From	To
Change Package org.apache.slider.core.restclient to org.apache.hadoop.yarn.service.rest	From	To
Change Package org.apache.slider.core.registry.docstore to org.apache.hadoop.yarn.service.utils	From	To
Change Package org.apache.slider.core.main to org.apache.hadoop.yarn.service.exceptions	From	To
Change Package org.apache.slider.core.persist to org.apache.hadoop.yarn.service.utils	From	To
Change Package org.apache.slider.server.servicemonitor to org.apache.hadoop.yarn.service.servicemonitor.probe	From	To
Change Package org.apache.slider.core to org.apache.hadoop.yarn.service	From	To
Change Package org.apache.slider.common.tools to org.apache.hadoop.yarn.service.utils	From	To
Change Package org.apache.slider.core.launch to org.apache.hadoop.yarn.service.containerlaunch	From	To
Change Package org.apache.slider.common to org.apache.hadoop.yarn.service.client	From	To
Extract Interface	1
Extract Interface org.apache.hadoop.yarn.service.conf.YarnServiceConstants from classes [org.apache.hadoop.yarn.service.client.ServiceClient, org.apache.hadoop.yarn.service.provider.AbstractProviderService, org.apache.hadoop.yarn.service.provider.ProviderUtils, org.apache.hadoop.yarn.service.provider.docker.DockerClientProvider, org.apache.hadoop.yarn.service.provider.tarball.TarballClientProvider]	From	To
Change Attribute Type	2
Change Attribute Type componentSpec : org.apache.slider.api.resource.Component to componentSpec : org.apache.hadoop.yarn.service.api.records.Component in class org.apache.hadoop.yarn.service.component.Component	From	To
Change Attribute Type containerSpec : org.apache.slider.api.resource.Container to containerSpec : org.apache.hadoop.yarn.service.api.records.Container in class org.apache.hadoop.yarn.service.compinstance.ComponentInstance	From	To

2191f5b533c6b4763f5d443d21127f1f8552ce64

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: