220ca960bce970d5969b9af570a3ce43360b7e2b
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 9
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method private clearCellBuffers() : void from class org.apache.hadoop.hdfs.DFSStripedOutputStream to private clear() : void from class org.apache.hadoop.hdfs.DFSStripedOutputStream.CellBuffers | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type stripedBlocks : List<BlockingQueue<LocatedBlock>> to coordinator : Coordinator in method package StripedDataStreamer(stat HdfsFileStatus, dfsClient DFSClient, src String, progress Progressable, checksum DataChecksum, cachingStrategy AtomicReference<CachingStrategy>, byteArrayManage ByteArrayManager, favoredNodes String[], index short, coordinator Coordinator) in class org.apache.hadoop.hdfs.StripedDataStreamer | From | To | |
| Rename Variable | 2 | ||
| Rename Variable lb : LocatedBlock to lsb : LocatedStripedBlock in method protected locateFollowingBlock(excludedNodes DatanodeInfo[]) : LocatedBlock in class org.apache.hadoop.hdfs.StripedDataStreamer | From | To | |
| Rename Variable firstCellSize : long to newBytes : long in method package writeParity(index int, buffer ByteBuffer, checksumBuf byte[]) : void in class org.apache.hadoop.hdfs.DFSStripedOutputStream | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private stripedBlocks : List<BlockingQueue<LocatedBlock>> from class org.apache.hadoop.hdfs.StripedDataStreamer to private stripedBlocks : List<BlockingQueue<LocatedBlock>> from class org.apache.hadoop.hdfs.DFSStripedOutputStream.Coordinator | From | To | |
| Extract Class | 1 | ||
| Extract Class org.apache.hadoop.hdfs.DFSStripedOutputStream.Coordinator from class org.apache.hadoop.hdfs.StripedDataStreamer | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute stripedBlocks : List<BlockingQueue<LocatedBlock>> to coordinator : Coordinator in class org.apache.hadoop.hdfs.StripedDataStreamer | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type parityCellSize : long to parityCellSize : int in method private writeParityCellsForLastStripe() : void in class org.apache.hadoop.hdfs.DFSStripedOutputStream | From | To | |
| Change Variable Type lb : LocatedBlock to lsb : LocatedStripedBlock in method protected locateFollowingBlock(excludedNodes DatanodeInfo[]) : LocatedBlock in class org.apache.hadoop.hdfs.StripedDataStreamer | From | To | |
| Extract Variable | 2 | ||
| Extract Variable oldBytes : long in method package writeParity(index int, buffer ByteBuffer, checksumBuf byte[]) : void from class org.apache.hadoop.hdfs.DFSStripedOutputStream | From | To | |
| Extract Variable schema : ECSchema in method package DFSStripedOutputStream(dfsClient DFSClient, src String, stat HdfsFileStatus, flag EnumSet<CreateFlag>, progress Progressable, checksum DataChecksum, favoredNodes String[]) from class org.apache.hadoop.hdfs.DFSStripedOutputStream | From | To | |
| Change Attribute Type | 5 | ||
| Change Attribute Type cellBuffers : ByteBuffer[] to cellBuffers : CellBuffers in class org.apache.hadoop.hdfs.DFSStripedOutputStream | From | To | |
| Change Attribute Type stripedBlocks : List<BlockingQueue<LocatedBlock>> to coordinator : Coordinator in class org.apache.hadoop.hdfs.StripedDataStreamer | From | To | |
| Change Attribute Type numDataBlocks : short to numDataBlocks : int in class org.apache.hadoop.hdfs.DFSStripedOutputStream | From | To | |
| Change Attribute Type numAllBlocks : short to numAllBlocks : int in class org.apache.hadoop.hdfs.DFSStripedOutputStream | From | To | |
| Change Attribute Type index : short to index : int in class org.apache.hadoop.hdfs.StripedDataStreamer | From | To | |
| Extract Method | 19 | ||
| Extract Method package writeParityCells() : void extracted from protected writeChunk(b byte[], offset int, len int, checksum byte[], ckoff int, cklen int) : void in class org.apache.hadoop.hdfs.DFSStripedOutputStream | From | To | |
| Extract Method private setCurrentStreamer(i int) : StripedDataStreamer extracted from package DFSStripedOutputStream(dfsClient DFSClient, src String, stat HdfsFileStatus, flag EnumSet<CreateFlag>, progress Progressable, checksum DataChecksum, favoredNodes String[]) in class org.apache.hadoop.hdfs.DFSStripedOutputStream | From | To | |
| Extract Method package enqueueCurrentPacket() : void extracted from protected closeImpl() : void in class org.apache.hadoop.hdfs.DFSOutputStream | From | To | |
| Extract Method package writeParity(index int, buffer ByteBuffer, checksumBuf byte[]) : void extracted from protected writeChunk(b byte[], offset int, len int, checksum byte[], ckoff int, cklen int) : void in class org.apache.hadoop.hdfs.DFSStripedOutputStream | From | To | |
| Extract Method package enqueueCurrentPacket() : void extracted from protected writeChunk(b byte[], offset int, len int, checksum byte[], ckoff int, cklen int) : void in class org.apache.hadoop.hdfs.DFSOutputStream | From | To | |
| Extract Method private handleStreamerFailure(err String, e Exception) : void extracted from protected closeImpl() : void in class org.apache.hadoop.hdfs.DFSStripedOutputStream | From | To | |
| Extract Method private handleStreamerFailure(err String, e Exception) : void extracted from protected writeChunk(b byte[], offset int, len int, checksum byte[], ckoff int, cklen int) : void in class org.apache.hadoop.hdfs.DFSStripedOutputStream | From | To | |
| Extract Method package setCurrentPacket2Empty() : void extracted from protected endBlock() : void in class org.apache.hadoop.hdfs.DFSOutputStream | From | To | |
| Extract Method package verifyParity(size long, cellSize int, dataBytes byte[][], parityBytes byte[][], killedDnIndex int) : void extracted from package verifyParity(size long, cellSize int, dataBytes byte[][], parityBytes byte[][]) : void in class org.apache.hadoop.hdfs.TestDFSStripedOutputStream | From | To | |
| Extract Method private setCurrentStreamer(i int) : StripedDataStreamer extracted from private writeParityCellsForLastStripe() : void in class org.apache.hadoop.hdfs.DFSStripedOutputStream | From | To | |
| Extract Method package enqueueCurrentPacket() : void extracted from protected endBlock() : void in class org.apache.hadoop.hdfs.DFSOutputStream | From | To | |
| Extract Method package getCurrentStreamer() : StripedDataStreamer extracted from package DFSStripedOutputStream(dfsClient DFSClient, src String, stat HdfsFileStatus, flag EnumSet<CreateFlag>, progress Progressable, checksum DataChecksum, favoredNodes String[]) in class org.apache.hadoop.hdfs.DFSStripedOutputStream | From | To | |
| Extract Method private handleStreamerFailure(err String, e Exception) : void extracted from private writeParityCellsForLastStripe() : void in class org.apache.hadoop.hdfs.DFSStripedOutputStream | From | To | |
| Extract Method package writeParity(index int, buffer ByteBuffer, checksumBuf byte[]) : void extracted from private writeParityCellsForLastStripe() : void in class org.apache.hadoop.hdfs.DFSStripedOutputStream | From | To | |
| Extract Method package setCurrentPacket2Empty() : void extracted from protected closeImpl() : void in class org.apache.hadoop.hdfs.DFSOutputStream | From | To | |
| Extract Method package enqueueCurrentPacketFull() : void extracted from protected writeChunk(b byte[], offset int, len int, checksum byte[], ckoff int, cklen int) : void in class org.apache.hadoop.hdfs.DFSOutputStream | From | To | |
| Extract Method package writeParityCells() : void extracted from private writeParityCellsForLastStripe() : void in class org.apache.hadoop.hdfs.DFSStripedOutputStream | From | To | |
| Extract Method package enqueueCurrentPacket() : void extracted from private flushOrSync(isSync boolean, syncFlags EnumSet<SyncFlag>) : void in class org.apache.hadoop.hdfs.DFSOutputStream | From | To | |
| Extract And Move Method | 4 | ||
| Extract And Move Method package enqueueCurrentPacket() : void extracted from protected closeImpl() : void in class org.apache.hadoop.hdfs.DFSStripedOutputStream & moved to class org.apache.hadoop.hdfs.DFSOutputStream | From | To | |
| Extract And Move Method package enqueueCurrentPacketFull() : void extracted from protected writeChunk(b byte[], offset int, len int, checksum byte[], ckoff int, cklen int) : void in class org.apache.hadoop.hdfs.DFSStripedOutputStream & moved to class org.apache.hadoop.hdfs.DFSOutputStream | From | To | |
| Extract And Move Method public toInterruptedIOException(message String, e InterruptedException) : InterruptedIOException extracted from package DFSStripedOutputStream(dfsClient DFSClient, src String, stat HdfsFileStatus, flag EnumSet<CreateFlag>, progress Progressable, checksum DataChecksum, favoredNodes String[]) in class org.apache.hadoop.hdfs.DFSStripedOutputStream & moved to class org.apache.hadoop.hdfs.DFSUtil | From | To | |
| Extract And Move Method package setCurrentPacket2Empty() : void extracted from protected closeImpl() : void in class org.apache.hadoop.hdfs.DFSStripedOutputStream & moved to class org.apache.hadoop.hdfs.DFSOutputStream | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter b : byte[] to bytes : byte[] in method protected writeChunk(bytes byte[], offset int, len int, checksum byte[], ckoff int, cklen int) : void in class org.apache.hadoop.hdfs.DFSStripedOutputStream | From | To | |
| Rename Parameter stripedBlocks : List<BlockingQueue<LocatedBlock>> to coordinator : Coordinator in method package StripedDataStreamer(stat HdfsFileStatus, dfsClient DFSClient, src String, progress Progressable, checksum DataChecksum, cachingStrategy AtomicReference<CachingStrategy>, byteArrayManage ByteArrayManager, favoredNodes String[], index short, coordinator Coordinator) in class org.apache.hadoop.hdfs.StripedDataStreamer | From | To |