2848db814a98b83e7546f65a2751e56fb5b2dbe0
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 42
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method package getBlockDiskspace() : long renamed to package getPreferredBlockDiskspace() : long in class org.apache.hadoop.hdfs.server.namenode.INodeFile | From | To | |
| Rename Method package prepareFileForWrite(src String, iip INodesInPath, leaseHolder String, clientMachine String, writeToEditLog boolean, logRetryCache boolean) : LocatedBlock renamed to package prepareFileForAppend(src String, iip INodesInPath, leaseHolder String, clientMachine String, newBlock boolean, writeToEditLog boolean, logRetryCache boolean) : LocatedBlock in class org.apache.hadoop.hdfs.server.namenode.FSNamesystem | From | To | |
| Rename Variable | 5 | ||
| Rename Variable reopen : InotifyProtos.AppendEventProto to append : InotifyProtos.AppendEventProto in method public convert(resp GetEditsFromTxidResponseProto) : EventBatchList in class org.apache.hadoop.hdfs.protocolPB.PBHelper | From | To | |
| Rename Variable lastBlockWithStatus : LastBlockWithStatus to blkWithStatus : LastBlockWithStatus in method private callAppend(src String, buffersize int, flag EnumSet<CreateFlag>, progress Progressable) : DFSOutputStream in class org.apache.hadoop.hdfs.DFSClient | From | To | |
| Rename Variable srcInode : INodeFile to srcINodeFile : INodeFile in method private verifySrcFiles(fsd FSDirectory, srcs String[], targetIIP INodesInPath, pc FSPermissionChecker) : INodeFile[] in class org.apache.hadoop.hdfs.server.namenode.FSDirConcatOp | From | To | |
| Rename Variable srcIip : INodesInPath to iip : INodesInPath in method private verifySrcFiles(fsd FSDirectory, srcs String[], targetIIP INodesInPath, pc FSPermissionChecker) : INodeFile[] in class org.apache.hadoop.hdfs.server.namenode.FSDirConcatOp | From | To | |
| Rename Variable trgInode : INodeFile to targetINode : INodeFile in method private verifyTargetFile(fsd FSDirectory, target String, targetIIP INodesInPath) : void in class org.apache.hadoop.hdfs.server.namenode.FSDirConcatOp | From | To | |
| Parameterize Variable | 3 | ||
| Parameterize Variable trgIIP : INodesInPath to targetIIP : INodesInPath in method package unprotectedConcat(fsd FSDirectory, targetIIP INodesInPath, srcList INodeFile[], timestamp long) : void in class org.apache.hadoop.hdfs.server.namenode.FSDirConcatOp | From | To | |
| Parameterize Variable allSrcInodes : INodeFile[] to srcList : INodeFile[] in method package unprotectedConcat(fsd FSDirectory, targetIIP INodesInPath, srcList INodeFile[], timestamp long) : void in class org.apache.hadoop.hdfs.server.namenode.FSDirConcatOp | From | To | |
| Parameterize Variable trgIip : INodesInPath to targetIIP : INodesInPath in method private verifyTargetFile(fsd FSDirectory, target String, targetIIP INodesInPath) : void in class org.apache.hadoop.hdfs.server.namenode.FSDirConcatOp | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type si : Set<INode> to si : Set<INodeFile> in method private verifySrcFiles(fsd FSDirectory, srcs String[], targetIIP INodesInPath, pc FSPermissionChecker) : INodeFile[] in class org.apache.hadoop.hdfs.server.namenode.FSDirConcatOp | From | To | |
| Change Variable Type fs : FileSystem to fs : DistributedFileSystem in method public run() : void in class org.apache.hadoop.hdfs.TestFileAppend2.Workload | From | To | |
| Inline Variable | 1 | ||
| Inline Variable inode : INode in method package unprotectedConcat(fsd FSDirectory, target String, srcs String[], timestamp long) : void from class org.apache.hadoop.hdfs.server.namenode.FSDirConcatOp | From | To | |
| Extract Method | 8 | ||
| Extract Method private verifyTargetFile(fsd FSDirectory, target String, targetIIP INodesInPath) : void extracted from package concat(fsd FSDirectory, target String, srcs String[], logRetryCache boolean) : HdfsFileStatus in class org.apache.hadoop.hdfs.server.namenode.FSDirConcatOp | From | To | |
| Extract Method private testTC11(appendToNewBlock boolean) : void extracted from public testTC11() : void in class org.apache.hadoop.hdfs.TestFileAppend3 | From | To | |
| Extract Method private verifySrcFiles(fsd FSDirectory, srcs String[], targetIIP INodesInPath, pc FSPermissionChecker) : INodeFile[] extracted from package concat(fsd FSDirectory, target String, srcs String[], logRetryCache boolean) : HdfsFileStatus in class org.apache.hadoop.hdfs.server.namenode.FSDirConcatOp | From | To | |
| Extract Method private testComplexAppend(appendToNewBlock boolean) : void extracted from public testComplexAppend() : void in class org.apache.hadoop.hdfs.TestFileAppend2 | From | To | |
| Extract Method private testAppendToPartialChunk(appendToNewBlock boolean) : void extracted from public testAppendToPartialChunk() : void in class org.apache.hadoop.hdfs.TestFileAppend3 | From | To | |
| Extract Method public append(f Path, flag EnumSet<CreateFlag>, bufferSize int, progress Progressable) : FSDataOutputStream extracted from public append(f Path, bufferSize int, progress Progressable) : FSDataOutputStream in class org.apache.hadoop.hdfs.DistributedFileSystem | From | To | |
| Extract Method private testTC7(appendToNewBlock boolean) : void extracted from public testTC7() : void in class org.apache.hadoop.hdfs.TestFileAppend3 | From | To | |
| Extract Method private testTC12(appendToNewBlock boolean) : void extracted from public testTC12() : void in class org.apache.hadoop.hdfs.TestFileAppend3 | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter buffersize : int to bufferSize : int in method package newStreamForAppend(dfsClient DFSClient, src String, toNewBlock boolean, bufferSize int, progress Progressable, lastBlock LocatedBlock, stat HdfsFileStatus, checksum DataChecksum) : DFSOutputStream in class org.apache.hadoop.hdfs.DFSOutputStream | From | To |