hadoop 2acc50b826fa8b00f2b09d9546c4b3215b89d46d

2acc50b826fa8b00f2b09d9546c4b3215b89d46d

Files Diff

Added: 1
Removed: 0
Renamed: 0
Modified: 41

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Extract Subclass	1
Extract Subclass org.apache.hadoop.hdfs.server.datanode.SimpleBlocksMovementsStatusHandler from class org.apache.hadoop.hdfs.server.common.sps.BlocksMovementsStatusHandler	From	To
Change Parameter Type	7
Change Parameter Type itemInfo : AttemptedItemInfo<T> to monotonicNow : long in method public add(startPath T, file T, monotonicNow long, assignedBlocks Map<Block,Set<StorageTypeNodePair>>, retryCount int) : void in class org.apache.hadoop.hdfs.server.namenode.sps.BlockStorageMovementAttemptedItems	From	To
Change Parameter Type worker : StoragePolicySatisfyWorker to handler : SimpleBlocksMovementsStatusHandler in method private waitForBlockMovementCompletion(handler SimpleBlocksMovementsStatusHandler, expectedFinishedItemsCount int, timeout int) : void in class org.apache.hadoop.hdfs.server.datanode.TestStoragePolicySatisfyWorker	From	To
Change Parameter Type itemInfo : AttemptedItemInfo<T> to file : T in method public add(startPath T, file T, monotonicNow long, assignedBlocks Map<Block,Set<StorageTypeNodePair>>, retryCount int) : void in class org.apache.hadoop.hdfs.server.namenode.sps.BlockStorageMovementAttemptedItems	From	To
Change Parameter Type blocks : List<Block> to blocks : Set<Block> in method package AttemptedItemInfo(rootId T, trackId T, lastAttemptedOrReportedTime long, blocks Set<Block>, retryCount int) in class org.apache.hadoop.hdfs.server.namenode.sps.StoragePolicySatisfier.AttemptedItemInfo	From	To
Change Parameter Type blockMovingInfo : List<Block> to assignedBlocks : Map<Block,Set<StorageTypeNodePair>> in method package BlocksMovingAnalysis(status Status, assignedBlocks Map<Block,Set<StorageTypeNodePair>>) in class org.apache.hadoop.hdfs.server.namenode.sps.StoragePolicySatisfier.BlocksMovingAnalysis	From	To
Change Parameter Type itemInfo : AttemptedItemInfo<T> to startPath : T in method public add(startPath T, file T, monotonicNow long, assignedBlocks Map<Block,Set<StorageTypeNodePair>>, retryCount int) : void in class org.apache.hadoop.hdfs.server.namenode.sps.BlockStorageMovementAttemptedItems	From	To
Change Parameter Type itemInfo : AttemptedItemInfo<T> to retryCount : int in method public add(startPath T, file T, monotonicNow long, assignedBlocks Map<Block,Set<StorageTypeNodePair>>, retryCount int) : void in class org.apache.hadoop.hdfs.server.namenode.sps.BlockStorageMovementAttemptedItems	From	To
Move Method	1
Move Method public removeAll() : void from class org.apache.hadoop.hdfs.server.common.sps.BlockStorageMovementTracker to public removeAll() : void from class org.apache.hadoop.hdfs.server.datanode.SimpleBlocksMovementsStatusHandler	From	To
Push Down Attribute	1
Push Down Attribute private blockIdVsMovementStatus : List<Block> from class org.apache.hadoop.hdfs.server.common.sps.BlocksMovementsStatusHandler to private blockIdVsMovementStatus : List<Block> from class org.apache.hadoop.hdfs.server.datanode.SimpleBlocksMovementsStatusHandler	From	To
Change Variable Type	8
Change Variable Type blocks : List<Block> to blocksMap : Map<Block,Set<StorageTypeNodePair>> in method public testAddReportedMoveAttemptFinishedBlocks() : void in class org.apache.hadoop.hdfs.server.namenode.sps.TestBlockStorageMovementAttemptedItems	From	To
Change Variable Type isSPSRunning : boolean to spsMgr : StoragePolicySatisfyManager in method public isInternalSatisfierRunning() : boolean in class org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer	From	To
Change Variable Type blksMovementReport : Block[] to block : Block in method public testPartialBlockMovementShouldBeRetried2() : void in class org.apache.hadoop.hdfs.server.namenode.sps.TestBlockStorageMovementAttemptedItems	From	To
Change Variable Type blocks : List<Block> to blocksMap : Map<Block,Set<StorageTypeNodePair>> in method public testNoBlockMovementAttemptFinishedReportAdded() : void in class org.apache.hadoop.hdfs.server.namenode.sps.TestBlockStorageMovementAttemptedItems	From	To
Change Variable Type blockArray : Block[] to block : Block in method public testAddReportedMoveAttemptFinishedBlocks() : void in class org.apache.hadoop.hdfs.server.namenode.sps.TestBlockStorageMovementAttemptedItems	From	To
Change Variable Type blksMovementReport : Block[] to block : Block in method public testPartialBlockMovementWithEmptyAttemptedQueue() : void in class org.apache.hadoop.hdfs.server.namenode.sps.TestBlockStorageMovementAttemptedItems	From	To
Change Variable Type sps : StoragePolicySatisfier<Long> to blkMoveListener : ExternalBlockMovementListener in method private waitForBlocksMovementAttemptReport(cluster MiniDFSCluster, expectedMoveFinishedBlks long, timeout int) : void in class org.apache.hadoop.hdfs.server.namenode.sps.TestStoragePolicySatisfierWithStripedFile	From	To
Change Variable Type blksMovementReport : Block[] to block1 : Block in method public testPartialBlockMovementShouldBeRetried1() : void in class org.apache.hadoop.hdfs.server.namenode.sps.TestBlockStorageMovementAttemptedItems	From	To
Extract Variable	4
Extract Variable spsManager : StoragePolicySatisfyManager in method package unprotectedRemoveXAttrs(fsd FSDirectory, iip INodesInPath, toRemove List<XAttr>) : List<XAttr> from class org.apache.hadoop.hdfs.server.namenode.FSDirXAttrOp	From	To
Extract Variable spsManager : StoragePolicySatisfyManager in method package satisfyStoragePolicy(fsd FSDirectory, bm BlockManager, src String, logRetryCache boolean) : FileStatus from class org.apache.hadoop.hdfs.server.namenode.FSDirSatisfyStoragePolicyOp	From	To
Extract Variable spsMgr : StoragePolicySatisfyManager in method public getNextSPSPath() : String from class org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer	From	To
Extract Variable spsManager : StoragePolicySatisfyManager in method package unprotectedSatisfyStoragePolicy(inode INode, fsd FSDirectory) : boolean from class org.apache.hadoop.hdfs.server.namenode.FSDirSatisfyStoragePolicyOp	From	To
Extract Method	1
Extract Method private createSPSManager(conf Configuration) : boolean extracted from public BlockManager(namesystem Namesystem, haEnabled boolean, conf Configuration) in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager	From	To
Rename Method	1
Rename Method public init() : void renamed to private startMovementTracker() : void in class org.apache.hadoop.hdfs.server.sps.ExternalSPSBlockMoveTaskHandler	From	To
Push Down Method	3
Push Down Method public removeAll() : void from class org.apache.hadoop.hdfs.server.common.sps.BlocksMovementsStatusHandler to public removeAll() : void from class org.apache.hadoop.hdfs.server.datanode.SimpleBlocksMovementsStatusHandler	From	To
Push Down Method public remove(moveAttemptFinishedBlks List<Block>) : void from class org.apache.hadoop.hdfs.server.common.sps.BlocksMovementsStatusHandler to public remove(moveAttemptFinishedBlks List<Block>) : void from class org.apache.hadoop.hdfs.server.datanode.SimpleBlocksMovementsStatusHandler	From	To
Push Down Method public getMoveAttemptFinishedBlocks() : List<Block> from class org.apache.hadoop.hdfs.server.common.sps.BlocksMovementsStatusHandler to public getMoveAttemptFinishedBlocks() : List<Block> from class org.apache.hadoop.hdfs.server.datanode.SimpleBlocksMovementsStatusHandler	From	To
Rename Variable	7
Rename Variable blksMovementReport : Block[] to block1 : Block in method public testPartialBlockMovementShouldBeRetried1() : void in class org.apache.hadoop.hdfs.server.namenode.sps.TestBlockStorageMovementAttemptedItems	From	To
Rename Variable blocks : List<Block> to blocksMap : Map<Block,Set<StorageTypeNodePair>> in method public testAddReportedMoveAttemptFinishedBlocks() : void in class org.apache.hadoop.hdfs.server.namenode.sps.TestBlockStorageMovementAttemptedItems	From	To
Rename Variable isSPSRunning : boolean to spsMgr : StoragePolicySatisfyManager in method public isInternalSatisfierRunning() : boolean in class org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer	From	To
Rename Variable blksMovementReport : Block[] to block : Block in method public testPartialBlockMovementShouldBeRetried2() : void in class org.apache.hadoop.hdfs.server.namenode.sps.TestBlockStorageMovementAttemptedItems	From	To
Rename Variable blockArray : Block[] to block : Block in method public testAddReportedMoveAttemptFinishedBlocks() : void in class org.apache.hadoop.hdfs.server.namenode.sps.TestBlockStorageMovementAttemptedItems	From	To
Rename Variable blocks : List<Block> to blocksMap : Map<Block,Set<StorageTypeNodePair>> in method public testNoBlockMovementAttemptFinishedReportAdded() : void in class org.apache.hadoop.hdfs.server.namenode.sps.TestBlockStorageMovementAttemptedItems	From	To
Rename Variable blksMovementReport : Block[] to block : Block in method public testPartialBlockMovementWithEmptyAttemptedQueue() : void in class org.apache.hadoop.hdfs.server.namenode.sps.TestBlockStorageMovementAttemptedItems	From	To
Change Return Type	1
Change Return Type List<Block> to Set<Block> in method package getBlocks() : Set<Block> in class org.apache.hadoop.hdfs.server.namenode.sps.StoragePolicySatisfier.AttemptedItemInfo	From	To
Replace Variable With Attribute	1
Replace Variable With Attribute sps : StoragePolicySatisfier<Long> to blkMoveListener : ExternalBlockMovementListener in method private waitForBlocksMovementAttemptReport(cluster MiniDFSCluster, expectedMoveFinishedBlks long, timeout int) : void in class org.apache.hadoop.hdfs.server.namenode.sps.TestStoragePolicySatisfierWithStripedFile	From	To
Change Attribute Type	3
Change Attribute Type movementFinishedBlocks : List<Block> to movementFinishedBlocks : BlockingQueue<Block> in class org.apache.hadoop.hdfs.server.namenode.sps.BlockStorageMovementAttemptedItems	From	To
Change Attribute Type blocks : List<Block> to blocks : Set<Block> in class org.apache.hadoop.hdfs.server.namenode.sps.StoragePolicySatisfier.AttemptedItemInfo	From	To
Change Attribute Type assignedBlocks : List<Block> to assignedBlocks : Map<Block,Set<StorageTypeNodePair>> in class org.apache.hadoop.hdfs.server.namenode.sps.StoragePolicySatisfier.BlocksMovingAnalysis	From	To
Extract And Move Method	1
Extract And Move Method public toString() : String extracted from public start(reconfigStart boolean, serviceMode StoragePolicySatisfierMode) : void in class org.apache.hadoop.hdfs.server.namenode.sps.StoragePolicySatisfier & moved to class org.apache.hadoop.hdfs.server.namenode.sps.StoragePolicySatisfier.StorageTypeNodePair	From	To
Rename Parameter	6
Rename Parameter itemInfo : AttemptedItemInfo<T> to monotonicNow : long in method public add(startPath T, file T, monotonicNow long, assignedBlocks Map<Block,Set<StorageTypeNodePair>>, retryCount int) : void in class org.apache.hadoop.hdfs.server.namenode.sps.BlockStorageMovementAttemptedItems	From	To
Rename Parameter itemInfo : AttemptedItemInfo<T> to file : T in method public add(startPath T, file T, monotonicNow long, assignedBlocks Map<Block,Set<StorageTypeNodePair>>, retryCount int) : void in class org.apache.hadoop.hdfs.server.namenode.sps.BlockStorageMovementAttemptedItems	From	To
Rename Parameter worker : StoragePolicySatisfyWorker to handler : SimpleBlocksMovementsStatusHandler in method private waitForBlockMovementCompletion(handler SimpleBlocksMovementsStatusHandler, expectedFinishedItemsCount int, timeout int) : void in class org.apache.hadoop.hdfs.server.datanode.TestStoragePolicySatisfyWorker	From	To
Rename Parameter blockMovingInfo : List<Block> to assignedBlocks : Map<Block,Set<StorageTypeNodePair>> in method package BlocksMovingAnalysis(status Status, assignedBlocks Map<Block,Set<StorageTypeNodePair>>) in class org.apache.hadoop.hdfs.server.namenode.sps.StoragePolicySatisfier.BlocksMovingAnalysis	From	To
Rename Parameter itemInfo : AttemptedItemInfo<T> to startPath : T in method public add(startPath T, file T, monotonicNow long, assignedBlocks Map<Block,Set<StorageTypeNodePair>>, retryCount int) : void in class org.apache.hadoop.hdfs.server.namenode.sps.BlockStorageMovementAttemptedItems	From	To
Rename Parameter itemInfo : AttemptedItemInfo<T> to retryCount : int in method public add(startPath T, file T, monotonicNow long, assignedBlocks Map<Block,Set<StorageTypeNodePair>>, retryCount int) : void in class org.apache.hadoop.hdfs.server.namenode.sps.BlockStorageMovementAttemptedItems	From	To

2acc50b826fa8b00f2b09d9546c4b3215b89d46d

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: