hadoop 2cc9514ad643ae49d30524743420ee9744e571bd

2cc9514ad643ae49d30524743420ee9744e571bd

Files Diff

Added: 1
Removed: 0
Renamed: 0
Modified: 23

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Change Parameter Type	9
Change Parameter Type conf : DFSClient.Conf to conf : ShortCircuitConf in method public getPathInfo(addr InetSocketAddress, conf ShortCircuitConf) : PathInfo in class org.apache.hadoop.hdfs.shortcircuit.DomainSocketFactory	From	To
Change Parameter Type conf : Conf to conf : DfsClientConf in method private ClientContext(name String, conf DfsClientConf) in class org.apache.hadoop.hdfs.ClientContext	From	To
Change Parameter Type conf : DFSClient.Conf to conf : DfsClientConf in method public BlockReaderFactory(conf DfsClientConf) in class org.apache.hadoop.hdfs.BlockReaderFactory	From	To
Change Parameter Type conf : Conf to conf : ShortCircuitConf in method public Builder(conf ShortCircuitConf) in class org.apache.hadoop.hdfs.BlockReaderLocal.Builder	From	To
Change Parameter Type conf : DFSClient.Conf to conf : ShortCircuitConf in method private BlockReaderLocalLegacy(conf ShortCircuitConf, hdfsfile String, block ExtendedBlock, token Token<BlockTokenIdentifier>, startOffset long, length long, pathinfo BlockLocalPathInfo, checksum DataChecksum, verifyChecksum boolean, dataIn FileInputStream, firstChunkOffset long, checksumIn FileInputStream) in class org.apache.hadoop.hdfs.BlockReaderLocalLegacy	From	To
Change Parameter Type conf : Conf to conf : ShortCircuitConf in method public DomainSocketFactory(conf ShortCircuitConf) in class org.apache.hadoop.hdfs.shortcircuit.DomainSocketFactory	From	To
Change Parameter Type conf : Conf to conf : DfsClientConf in method private printConfWarningIfNeeded(conf DfsClientConf) : void in class org.apache.hadoop.hdfs.ClientContext	From	To
Change Parameter Type conf : Conf to conf : DfsClientConf in method public get(name String, conf DfsClientConf) : ClientContext in class org.apache.hadoop.hdfs.ClientContext	From	To
Change Parameter Type conf : DFSClient.Conf to conf : ShortCircuitConf in method private BlockReaderLocalLegacy(conf ShortCircuitConf, hdfsfile String, block ExtendedBlock, token Token<BlockTokenIdentifier>, startOffset long, length long, pathinfo BlockLocalPathInfo, dataIn FileInputStream) in class org.apache.hadoop.hdfs.BlockReaderLocalLegacy	From	To
Move Method	2
Move Method public isDomainSocketDataTraffic() : boolean from class org.apache.hadoop.hdfs.DFSClient.Conf to public isDomainSocketDataTraffic() : boolean from class org.apache.hadoop.hdfs.client.impl.DfsClientConf.ShortCircuitConf	From	To
Move Method public confAsString(conf Conf) : String from class org.apache.hadoop.hdfs.ClientContext to public confAsString() : String from class org.apache.hadoop.hdfs.client.impl.DfsClientConf.ShortCircuitConf	From	To
Move Attribute	19
Move Attribute package socketCacheExpiry : long from class org.apache.hadoop.hdfs.DFSClient.Conf to private socketCacheExpiry : long from class org.apache.hadoop.hdfs.client.impl.DfsClientConf.ShortCircuitConf	From	To
Move Attribute package shortCircuitStreamsCacheExpiryMs : long from class org.apache.hadoop.hdfs.DFSClient.Conf to private shortCircuitStreamsCacheExpiryMs : long from class org.apache.hadoop.hdfs.client.impl.DfsClientConf.ShortCircuitConf	From	To
Move Attribute package shortCircuitMmapCacheSize : int from class org.apache.hadoop.hdfs.DFSClient.Conf to private shortCircuitMmapCacheSize : int from class org.apache.hadoop.hdfs.client.impl.DfsClientConf.ShortCircuitConf	From	To
Move Attribute package shortCircuitMmapCacheRetryTimeout : long from class org.apache.hadoop.hdfs.DFSClient.Conf to private shortCircuitMmapCacheRetryTimeout : long from class org.apache.hadoop.hdfs.client.impl.DfsClientConf.ShortCircuitConf	From	To
Move Attribute package keyProviderCacheExpiryMs : long from class org.apache.hadoop.hdfs.DFSClient.Conf to private keyProviderCacheExpiryMs : long from class org.apache.hadoop.hdfs.client.impl.DfsClientConf.ShortCircuitConf	From	To
Move Attribute package domainSocketDataTraffic : boolean from class org.apache.hadoop.hdfs.DFSClient.Conf to private domainSocketDataTraffic : boolean from class org.apache.hadoop.hdfs.client.impl.DfsClientConf.ShortCircuitConf	From	To
Move Attribute package useLegacyBlockReaderLocal : boolean from class org.apache.hadoop.hdfs.DFSClient.Conf to private useLegacyBlockReaderLocal : boolean from class org.apache.hadoop.hdfs.client.impl.DfsClientConf.ShortCircuitConf	From	To
Move Attribute package shortCircuitLocalReads : boolean from class org.apache.hadoop.hdfs.DFSClient.Conf to private shortCircuitLocalReads : boolean from class org.apache.hadoop.hdfs.client.impl.DfsClientConf.ShortCircuitConf	From	To
Move Attribute package useLegacyBlockReader : boolean from class org.apache.hadoop.hdfs.DFSClient.Conf to private useLegacyBlockReader : boolean from class org.apache.hadoop.hdfs.client.impl.DfsClientConf.ShortCircuitConf	From	To
Move Attribute package shortCircuitMmapEnabled : boolean from class org.apache.hadoop.hdfs.DFSClient.Conf to private shortCircuitMmapEnabled : boolean from class org.apache.hadoop.hdfs.client.impl.DfsClientConf.ShortCircuitConf	From	To
Move Attribute package socketCacheCapacity : int from class org.apache.hadoop.hdfs.DFSClient.Conf to private socketCacheCapacity : int from class org.apache.hadoop.hdfs.client.impl.DfsClientConf.ShortCircuitConf	From	To
Move Attribute package shortCircuitStreamsCacheSize : int from class org.apache.hadoop.hdfs.DFSClient.Conf to private shortCircuitStreamsCacheSize : int from class org.apache.hadoop.hdfs.client.impl.DfsClientConf.ShortCircuitConf	From	To
Move Attribute package domainSocketPath : String from class org.apache.hadoop.hdfs.DFSClient.Conf to private domainSocketPath : String from class org.apache.hadoop.hdfs.client.impl.DfsClientConf.ShortCircuitConf	From	To
Move Attribute package shortCircuitSharedMemoryWatcherInterruptCheckMs : int from class org.apache.hadoop.hdfs.DFSClient.Conf to private shortCircuitSharedMemoryWatcherInterruptCheckMs : int from class org.apache.hadoop.hdfs.client.impl.DfsClientConf.ShortCircuitConf	From	To
Move Attribute package shortCircuitCacheStaleThresholdMs : long from class org.apache.hadoop.hdfs.DFSClient.Conf to private shortCircuitCacheStaleThresholdMs : long from class org.apache.hadoop.hdfs.client.impl.DfsClientConf.ShortCircuitConf	From	To
Move Attribute package skipShortCircuitChecksums : boolean from class org.apache.hadoop.hdfs.DFSClient.Conf to private skipShortCircuitChecksums : boolean from class org.apache.hadoop.hdfs.client.impl.DfsClientConf.ShortCircuitConf	From	To
Move Attribute package shortCircuitMmapCacheExpiryMs : long from class org.apache.hadoop.hdfs.DFSClient.Conf to private shortCircuitMmapCacheExpiryMs : long from class org.apache.hadoop.hdfs.client.impl.DfsClientConf.ShortCircuitConf	From	To
Move Attribute package shortCircuitBufferSize : int from class org.apache.hadoop.hdfs.DFSClient.Conf to private shortCircuitBufferSize : int from class org.apache.hadoop.hdfs.client.impl.DfsClientConf.ShortCircuitConf	From	To
Move Attribute public brfFailureInjector : BlockReaderFactory.FailureInjector from class org.apache.hadoop.hdfs.DFSClient.Conf to public brfFailureInjector : BlockReaderFactory.FailureInjector from class org.apache.hadoop.hdfs.client.impl.DfsClientConf.ShortCircuitConf	From	To
Extract Class	1
Extract Class org.apache.hadoop.hdfs.client.impl.DfsClientConf.ShortCircuitConf from class org.apache.hadoop.hdfs.DFSClient.Conf	From	To
Move And Rename Class	1
Move And Rename Class org.apache.hadoop.hdfs.DFSClient.Conf moved and renamed to org.apache.hadoop.hdfs.client.impl.DfsClientConf	From	To
Extract Variable	2
Extract Variable hdfsTimeout : int in method private addClient(dfsc DFSClient) : void from class org.apache.hadoop.hdfs.LeaseRenewer	From	To
Extract Variable conf : DfsClientConf in method private readBlockLength(locatedblock LocatedBlock) : long from class org.apache.hadoop.hdfs.DFSInputStream	From	To
Change Variable Type	4
Change Variable Type dfsClientConf : DFSClient.Conf to dfsClientConf : DfsClientConf in method public testCongestionBackoff() : void in class org.apache.hadoop.hdfs.TestDFSOutputStream	From	To
Change Variable Type timeout : long to timeout : int in method package closeClient(dfsc DFSClient) : void in class org.apache.hadoop.hdfs.LeaseRenewer	From	To
Change Variable Type config : Conf to config : DfsClientConf in method public createProxy(conf Configuration, nameNodeUri URI, xface Class<T>, fallbackToSimpleAuth AtomicBoolean) : ProxyAndInfo<T> in class org.apache.hadoop.hdfs.NameNodeProxies	From	To
Change Variable Type conf : DFSClient.Conf to scConf : ShortCircuitConf in method package newBlockReader(conf DfsClientConf, userGroupInformation UserGroupInformation, configuration Configuration, file String, blk ExtendedBlock, token Token<BlockTokenIdentifier>, node DatanodeInfo, startOffset long, length long, storageType StorageType) : BlockReaderLocalLegacy in class org.apache.hadoop.hdfs.BlockReaderLocalLegacy	From	To
Extract Method	2
Extract Method private applyUMask(permission FsPermission) : FsPermission extracted from public create(src String, permission FsPermission, flag EnumSet<CreateFlag>, createParent boolean, replication short, blockSize long, progress Progressable, buffersize int, checksumOpt ChecksumOpt, favoredNodes InetSocketAddress[]) : DFSOutputStream in class org.apache.hadoop.hdfs.DFSClient	From	To
Extract Method private applyUMask(permission FsPermission) : FsPermission extracted from public mkdirs(src String, permission FsPermission, createParent boolean) : boolean in class org.apache.hadoop.hdfs.DFSClient	From	To
Rename Method	3
Rename Method public isShortCircuitLocalReads() : boolean renamed to public isConnectToDnViaHostname() : boolean in class org.apache.hadoop.hdfs.client.impl.DfsClientConf	From	To
Rename Method public getDomainSocketPath() : String renamed to public getTaskId() : String in class org.apache.hadoop.hdfs.client.impl.DfsClientConf	From	To
Rename Method public isUseLegacyBlockReaderLocal() : boolean renamed to public isHdfsBlocksMetadataEnabled() : boolean in class org.apache.hadoop.hdfs.client.impl.DfsClientConf	From	To
Rename Variable	2
Rename Variable conf : DFSClient.Conf to scConf : ShortCircuitConf in method package newBlockReader(conf DfsClientConf, userGroupInformation UserGroupInformation, configuration Configuration, file String, blk ExtendedBlock, token Token<BlockTokenIdentifier>, node DatanodeInfo, startOffset long, length long, storageType StorageType) : BlockReaderLocalLegacy in class org.apache.hadoop.hdfs.BlockReaderLocalLegacy	From	To
Rename Variable myOpt : ChecksumOpt to opt : ChecksumOpt in method public createChecksum(userOpt ChecksumOpt) : DataChecksum in class org.apache.hadoop.hdfs.client.impl.DfsClientConf	From	To
Change Return Type	1
Change Return Type Conf to DfsClientConf in method public getConf() : DfsClientConf in class org.apache.hadoop.hdfs.DFSClient	From	To
Rename Attribute	8
Rename Attribute getHdfsBlocksMetadataEnabled : boolean to hdfsBlocksMetadataEnabled : boolean in class org.apache.hadoop.hdfs.client.impl.DfsClientConf	From	To
Rename Attribute nBlockWriteLocateFollowingRetry : int to numBlockWriteLocateFollowingRetry : int in class org.apache.hadoop.hdfs.client.impl.DfsClientConf	From	To
Rename Attribute getFileBlockStorageLocationsNumThreads : int to fileBlockStorageLocationsNumThreads : int in class org.apache.hadoop.hdfs.client.impl.DfsClientConf	From	To
Rename Attribute confTime : int to datanodeSocketWriteTimeout : int in class org.apache.hadoop.hdfs.client.impl.DfsClientConf	From	To
Rename Attribute getFileBlockStorageLocationsTimeoutMs : int to fileBlockStorageLocationsTimeoutMs : int in class org.apache.hadoop.hdfs.client.impl.DfsClientConf	From	To
Rename Attribute nBlockWriteRetry : int to numBlockWriteRetry : int in class org.apache.hadoop.hdfs.client.impl.DfsClientConf	From	To
Rename Attribute nCachedConnRetry : int to numCachedConnRetry : int in class org.apache.hadoop.hdfs.client.impl.DfsClientConf	From	To
Rename Attribute dfsclientSlowIoWarningThresholdMs : long to slowIoWarningThresholdMs : long in class org.apache.hadoop.hdfs.client.impl.DfsClientConf	From	To
Change Attribute Type	2
Change Attribute Type dfsClientConf : Conf to dfsClientConf : DfsClientConf in class org.apache.hadoop.hdfs.DFSClient	From	To
Change Attribute Type conf : DFSClient.Conf to conf : DfsClientConf in class org.apache.hadoop.hdfs.BlockReaderFactory	From	To
Extract And Move Method	1
Extract And Move Method public fromConf(conf ShortCircuitConf) : ShortCircuitCache extracted from private ClientContext(name String, conf Conf) in class org.apache.hadoop.hdfs.ClientContext & moved to class org.apache.hadoop.hdfs.shortcircuit.ShortCircuitCache	From	To

2cc9514ad643ae49d30524743420ee9744e571bd

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: