3090922805699b8374a359e92323884a4177dc4e
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 12
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method private sendRequestsToSecondaryResourceManagers(requests Map<SubClusterId,AllocateRequest>) : Registrations renamed to private sendRequestsToResourceManagers(requests Map<SubClusterId,AllocateRequest>) : Registrations in class org.apache.hadoop.yarn.server.nodemanager.amrmproxy.FederationInterceptor | From | To | |
| Move Method | 1 | ||
| Move Method private getNextResponseId(responseId int) : int from class org.apache.hadoop.yarn.server.resourcemanager.ApplicationMasterService to public getNextResponseId(responseId int) : int from class org.apache.hadoop.yarn.client.AMRMClientUtils | From | To | |
| Rename Variable | 1 | ||
| Rename Variable attemptId : ApplicationAttemptId to appId : ApplicationId in method public getContainers(request GetContainersRequest) : GetContainersResponse in class org.apache.hadoop.yarn.server.MockResourceManagerFacade | From | To | |
| Change Return Type | 2 | ||
| Change Return Type AllocateResponse to void in method private mergeAllocateResponses(mergedResponse AllocateResponse) : void in class org.apache.hadoop.yarn.server.nodemanager.amrmproxy.FederationInterceptor | From | To | |
| Change Return Type AllocateResponse to void in method private mergeRegistrationResponses(homeResponse AllocateResponse, registrations Map<SubClusterId,RegisterApplicationMasterResponse>) : void in class org.apache.hadoop.yarn.server.nodemanager.amrmproxy.FederationInterceptor | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private PRE_REGISTER_RESPONSE_ID : int from class org.apache.hadoop.yarn.server.resourcemanager.ApplicationMasterService to public PRE_REGISTER_RESPONSE_ID : int from class org.apache.hadoop.yarn.client.AMRMClientUtils | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute homeResponse : AllocateResponse to lastAllocateResponse : AllocateResponse in method public allocate(request AllocateRequest) : AllocateResponse in class org.apache.hadoop.yarn.server.nodemanager.amrmproxy.FederationInterceptor | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type attemptId : ApplicationAttemptId to appId : ApplicationId in method public getContainers(request GetContainersRequest) : GetContainersResponse in class org.apache.hadoop.yarn.server.MockResourceManagerFacade | From | To | |
| Extract Variable | 3 | ||
| Extract Variable allocateRequest : AllocateRequest in method private getContainersAndAssert(numberOfResourceRequests int, numberOfAllocationExcepted int) : List<Container> from class org.apache.hadoop.yarn.server.nodemanager.amrmproxy.TestFederationInterceptor | From | To | |
| Extract Variable appId : ApplicationId in method public registerApplicationMaster(request RegisterApplicationMasterRequest) : RegisterApplicationMasterResponse from class org.apache.hadoop.yarn.server.MockResourceManagerFacade | From | To | |
| Extract Variable allocateRequest : AllocateRequest in method private releaseContainersAndAssert(containers List<Container>) : void from class org.apache.hadoop.yarn.server.nodemanager.amrmproxy.TestFederationInterceptor | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type applicationContainerIdMap : HashMap<ApplicationAttemptId,List<ContainerId>> to applicationContainerIdMap : HashMap<ApplicationId,List<ContainerId>> in class org.apache.hadoop.yarn.server.MockResourceManagerFacade | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter homeResponse : AllocateResponse to mergedResponse : AllocateResponse in method private mergeAllocateResponses(mergedResponse AllocateResponse) : void in class org.apache.hadoop.yarn.server.nodemanager.amrmproxy.FederationInterceptor | From | To |