38996fdcf0987d1da00ce46f8284d8fcdce57329
Files Diff
- Added: 5
- Removed: 1
- Renamed: 0
- Modified: 9
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public makeRemoteGetRequest(getRequest HttpGet) : String renamed to protected retryableRequest(urls String[], path String, queryParams List<NameValuePair>, httpMethod String) : String in class org.apache.hadoop.fs.azure.WasbRemoteCallHelper | From | To | |
| Move And Inline Method | 1 | ||
| Move And Inline Method private setDelegationToken() : void moved from class org.apache.hadoop.fs.azure.RemoteWasbAuthorizerImpl to class org.apache.hadoop.fs.azure.RemoteSASKeyGeneratorImpl & inlined to public getContainerSASUri(storageAccount String, container String) : URI | From | To | |
| Rename Variable | 2 | ||
| Rename Variable connectUgi : UserGroupInformation to sasKeyResponse : RemoteSASKeyGenerationResponse in method public getContainerSASUri(storageAccount String, container String) : URI in class org.apache.hadoop.fs.azure.RemoteSASKeyGeneratorImpl | From | To | |
| Rename Variable getRequest : HttpGet to httpRequest : HttpUriRequest in method protected retryableRequest(urls String[], path String, queryParams List<NameValuePair>, httpMethod String) : String in class org.apache.hadoop.fs.azure.WasbRemoteCallHelper | From | To | |
| Inline Method | 4 | ||
| Inline Method private setDelegationToken() : void inlined to public getContainerSASUri(storageAccount String, container String) : URI in class org.apache.hadoop.fs.azure.RemoteSASKeyGeneratorImpl | From | To | |
| Inline Method private getSASKey(uri URI, connectUgi UserGroupInformation) : URI inlined to public getRelativeBlobSASUri(storageAccount String, container String, relativePath String) : URI in class org.apache.hadoop.fs.azure.RemoteSASKeyGeneratorImpl | From | To | |
| Inline Method private getSASKey(uri URI, connectUgi UserGroupInformation) : URI inlined to public getContainerSASUri(storageAccount String, container String) : URI in class org.apache.hadoop.fs.azure.RemoteSASKeyGeneratorImpl | From | To | |
| Move Attribute | 3 | ||
| Move Attribute public DEFAULT_DELEGATION_TOKEN_MANAGER_ENDPOINT : String from class org.apache.hadoop.fs.azure.security.Constants to private DEFAULT_DELEGATION_TOKEN_MANAGER_ENDPOINT : String from class org.apache.hadoop.fs.azure.security.RemoteWasbDelegationTokenManager | From | To | |
| Move Attribute private DELEGATION_TOKEN_QUERY_PARAM_NAME : String from class org.apache.hadoop.fs.azure.RemoteSASKeyGeneratorImpl to private DELEGATION_TOKEN_QUERY_PARAM_NAME : String from class org.apache.hadoop.fs.azure.SecureWasbRemoteCallHelper | From | To | |
| Move Attribute private DELEGATION_TOKEN_QUERY_PARAM_NAME : String from class org.apache.hadoop.fs.azure.RemoteWasbAuthorizerImpl to private DELEGATION_TOKEN_QUERY_PARAM_NAME : String from class org.apache.hadoop.fs.azure.SecureWasbRemoteCallHelper | From | To | |
| Extract Class | 2 | ||
| Extract Class org.apache.hadoop.fs.azure.SecureWasbRemoteCallHelper from class org.apache.hadoop.fs.azure.RemoteWasbAuthorizerImpl | From | To | |
| Extract Class org.apache.hadoop.fs.azure.SecureWasbRemoteCallHelper from class org.apache.hadoop.fs.azure.RemoteSASKeyGeneratorImpl | From | To | |
| Extract Attribute | 1 | ||
| Extract Attribute private INVALID_HTTP_STATUS_CODE_999 : int in class org.apache.hadoop.fs.azure.TestWasbRemoteCallHelper | From | To | |
| Rename Class | 1 | ||
| Rename Class org.apache.hadoop.fs.azure.RemoteAuthorizerResponse renamed to org.apache.hadoop.fs.azure.RemoteWasbAuthorizerResponse | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute KEY_REMOTE_AUTH_SERVICE_URL : String to KEY_REMOTE_AUTH_SERVICE_URLS : String in class org.apache.hadoop.fs.azure.RemoteWasbAuthorizerImpl | From | To | |
| Rename Attribute remoteAuthorizerServiceUrl : String to commaSeparatedUrls : String[] in class org.apache.hadoop.fs.azure.RemoteWasbAuthorizerImpl | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type getRequest : HttpGet to httpRequest : HttpUriRequest in method protected retryableRequest(urls String[], path String, queryParams List<NameValuePair>, httpMethod String) : String in class org.apache.hadoop.fs.azure.WasbRemoteCallHelper | From | To | |
| Change Variable Type connectUgi : UserGroupInformation to sasKeyResponse : RemoteSASKeyGenerationResponse in method public getContainerSASUri(storageAccount String, container String) : URI in class org.apache.hadoop.fs.azure.RemoteSASKeyGeneratorImpl | From | To | |
| Change Variable Type authorizerResponse : RemoteAuthorizerResponse to authorizerResponse : RemoteWasbAuthorizerResponse in method public authorize(wasbAbsolutePath String, accessType String, resourceOwner String) : boolean in class org.apache.hadoop.fs.azure.RemoteWasbAuthorizerImpl | From | To | |
| Extract Method | 2 | ||
| Extract Method private getInstance(conf Configuration) : WasbDelegationTokenManager extracted from public cancel(token Token<?>, conf Configuration) : void in class org.apache.hadoop.fs.azure.security.WasbTokenRenewer | From | To | |
| Extract Method private getInstance(conf Configuration) : WasbDelegationTokenManager extracted from public renew(token Token<?>, conf Configuration) : long in class org.apache.hadoop.fs.azure.security.WasbTokenRenewer | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type remoteAuthorizerServiceUrl : String to commaSeparatedUrls : String[] in class org.apache.hadoop.fs.azure.RemoteWasbAuthorizerImpl | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter token : String to path : String in method private makeRemoteRequest(urls String[], path String, queryParams List<NameValuePair>) : RemoteSASKeyGenerationResponse in class org.apache.hadoop.fs.azure.RemoteSASKeyGeneratorImpl | From | To |