438a9f047eb6af2a4b916a4f6ef6f68adeab8068
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 5
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method private checkAccessAcl(inode INodeAttributes, path String, access FsAction, mode FsPermission, aclFeature AclFeature) : void renamed to private hasAclPermission(inode INodeAttributes, access FsAction, mode FsPermission, aclFeature AclFeature) : boolean in class org.apache.hadoop.hdfs.server.namenode.FSPermissionChecker | From | To | |
| Rename Variable | 1 | ||
| Rename Variable pathByNameArr : byte[][] to components : byte[][] in method package checkPermission(inodesInPath INodesInPath, doCheckOwner boolean, ancestorAccess FsAction, parentAccess FsAction, access FsAction, subAccess FsAction, ignoreEmptyDir boolean) : void in class org.apache.hadoop.hdfs.server.namenode.FSPermissionChecker | From | To | |
| Change Return Type | 1 | ||
| Change Return Type void to boolean in method private hasAclPermission(inode INodeAttributes, access FsAction, mode FsPermission, aclFeature AclFeature) : boolean in class org.apache.hadoop.hdfs.server.namenode.FSPermissionChecker | From | To | |
| Split Parameter | 1 | ||
| Split Parameter inode : INodeAttributes to [inodes : INodeAttributes[], i : int] in method private checkOwner(inodes INodeAttributes[], i int) : void in class org.apache.hadoop.hdfs.server.namenode.FSPermissionChecker | From | To | |
| Extract Variable | 1 | ||
| Extract Variable checkAction : FsAction in method private hasPermission(inode INodeAttributes, access FsAction) : boolean from class org.apache.hadoop.hdfs.server.namenode.FSPermissionChecker | From | To | |
| Extract Method | 1 | ||
| Extract Method private hasPermission(inode INodeAttributes, access FsAction) : boolean extracted from private check(inode INodeAttributes, path String, access FsAction) : void in class org.apache.hadoop.hdfs.server.namenode.FSPermissionChecker | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter pathByNameArr : byte[][] to components : byte[][] in method public checkPermission(fsOwner String, supergroup String, callerUgi UserGroupInformation, inodeAttrs INodeAttributes[], inodes INode[], components byte[][], snapshotId int, path String, ancestorIndex int, doCheckOwner boolean, ancestorAccess FsAction, parentAccess FsAction, access FsAction, subAccess FsAction, ignoreEmptyDir boolean) : void in class org.apache.hadoop.hdfs.server.namenode.FSPermissionChecker | From | To | |
| Rename Parameter pathByNameArr : byte[][] to components : byte[][] in method private checkSubAccess(components byte[][], pathIdx int, inode INode, snapshotId int, access FsAction, ignoreEmptyDir boolean) : void in class org.apache.hadoop.hdfs.server.namenode.FSPermissionChecker | From | To |