48a58bce37dfddf37a4a6888228f7c7fc80bccdd
Files Diff
- Added: 1
- Removed: 3
- Renamed: 0
- Modified: 15
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 1 | ||
| Change Parameter Type replicationStatus : ReplicationActivityStatus to replicationManager : ReplicationManager in method public ChillModeHandler(configuration Configuration, clientProtocolServer SCMClientProtocolServer, blockManager BlockManager, replicationManager ReplicationManager) in class org.apache.hadoop.hdds.scm.chillmode.ChillModeHandler | From | To | |
| Pull Up Attribute | 1 | ||
| Pull Up Attribute private containerManager : ContainerManager from class org.apache.hadoop.hdds.scm.container.IncrementalContainerReportHandler to private containerManager : ContainerManager from class org.apache.hadoop.hdds.scm.container.AbstractContainerReportHandler | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type replicationActivityStatus : ReplicationActivityStatus to replicationManager : ReplicationManager in method public setUp() : void in class org.apache.hadoop.hdds.scm.server.TestSCMClientProtocolServer | From | To | |
| Extract Variable | 1 | ||
| Extract Variable oldState : LifeCycleState in method package updateContainerState(containerID ContainerID, event HddsProtos.LifeCycleEvent) : void from class org.apache.hadoop.hdds.scm.container.ContainerStateManager | From | To | |
| Inline Variable | 1 | ||
| Inline Variable containerID : ContainerID in method private processContainerReplicas(datanodeDetails DatanodeDetails, replicas List<ContainerReplicaProto>, publisher EventPublisher) : void from class org.apache.hadoop.hdds.scm.container.ContainerReportHandler | From | To | |
| Extract Method | 1 | ||
| Extract Method private processMissingReplicas(datanodeDetails DatanodeDetails, missingReplicas Set<ContainerID>) : void extracted from public onMessage(reportFromDatanode ContainerReportFromDatanode, publisher EventPublisher) : void in class org.apache.hadoop.hdds.scm.container.ContainerReportHandler | From | To | |
| Rename Method | 2 | ||
| Rename Method private processContainerReplicas(datanodeDetails DatanodeDetails, replicas List<ContainerReplicaProto>, publisher EventPublisher) : void renamed to private updateDeleteTransaction(datanodeDetails DatanodeDetails, replicas List<ContainerReplicaProto>, publisher EventPublisher) : void in class org.apache.hadoop.hdds.scm.container.ContainerReportHandler | From | To | |
| Rename Method public testQuasiClosedWithDifferentOriginNodeReplica() : void renamed to public testQuasiClosedToClosed() : void in class org.apache.hadoop.hdds.scm.container.TestContainerReportHandler | From | To | |
| Pull Up Method | 2 | ||
| Pull Up Method public IncrementalContainerReportHandler(pipelineManager PipelineManager, containerManager ContainerManager) from class org.apache.hadoop.hdds.scm.container.IncrementalContainerReportHandler to package AbstractContainerReportHandler(containerManager ContainerManager, logger Logger) from class org.apache.hadoop.hdds.scm.container.AbstractContainerReportHandler | From | To | |
| Pull Up Method public ContainerReportHandler(nodeManager NodeManager, pipelineManager PipelineManager, containerManager ContainerManager, replicationActivityStatus ReplicationActivityStatus) from class org.apache.hadoop.hdds.scm.container.ContainerReportHandler to package AbstractContainerReportHandler(containerManager ContainerManager, logger Logger) from class org.apache.hadoop.hdds.scm.container.AbstractContainerReportHandler | From | To | |
| Inline Method | 4 | ||
| Inline Method private updateContainerStateInternal(containerID ContainerID, event HddsProtos.LifeCycleEvent) : ContainerInfo inlined to public updateContainerState(containerID ContainerID, event HddsProtos.LifeCycleEvent) : HddsProtos.LifeCycleState in class org.apache.hadoop.hdds.scm.container.SCMContainerManager | From | To | |
| Inline Method private getContainerReportsProto(containerId ContainerID, state ContainerReplicaProto.State, originNodeId String, bcsid long) : ContainerReportsProto inlined to private getContainerReportsProto(containerId ContainerID, state ContainerReplicaProto.State, originNodeId String) : ContainerReportsProto in class org.apache.hadoop.hdds.scm.container.TestContainerReportHandler | From | To | |
| Inline Method private getIncrementalContainerReportProto(containerId ContainerID, state ContainerReplicaProto.State, originNodeId String, bcsid long) : IncrementalContainerReportProto inlined to private getIncrementalContainerReportProto(containerId ContainerID, state ContainerReplicaProto.State, originNodeId String) : IncrementalContainerReportProto in class org.apache.hadoop.hdds.scm.container.TestIncrementalContainerReportHandler | From | To | |
| Rename Variable | 5 | ||
| Rename Variable icrFromDatanode : IncrementalContainerReportFromDatanode to icr : IncrementalContainerReportFromDatanode in method public testQuasiClosedToClosed() : void in class org.apache.hadoop.hdds.scm.container.TestIncrementalContainerReportHandler | From | To | |
| Rename Variable replicationActivityStatus : ReplicationActivityStatus to replicationManager : ReplicationManager in method public setUp() : void in class org.apache.hadoop.hdds.scm.server.TestSCMClientProtocolServer | From | To | |
| Rename Variable actualContainerIDs : Set<ContainerID> to containersInDn : Set<ContainerID> in method public onMessage(reportFromDatanode ContainerReportFromDatanode, publisher EventPublisher) : void in class org.apache.hadoop.hdds.scm.container.ContainerReportHandler | From | To | |
| Rename Variable expectedContainerIDs : Set<ContainerID> to containersInSCM : Set<ContainerID> in method public onMessage(reportFromDatanode ContainerReportFromDatanode, publisher EventPublisher) : void in class org.apache.hadoop.hdds.scm.container.ContainerReportHandler | From | To | |
| Rename Variable replicaProto : ContainerReplicaProto to replica : ContainerReplicaProto in method private updateDeleteTransaction(datanodeDetails DatanodeDetails, replicas List<ContainerReplicaProto>, publisher EventPublisher) : void in class org.apache.hadoop.hdds.scm.container.ContainerReportHandler | From | To | |
| Change Return Type | 1 | ||
| Change Return Type ContainerInfo to void in method package updateContainerState(containerID ContainerID, event HddsProtos.LifeCycleEvent) : void in class org.apache.hadoop.hdds.scm.container.ContainerStateManager | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.apache.hadoop.hdds.scm.container.AbstractContainerReportHandler from classes [org.apache.hadoop.hdds.scm.container.ContainerReportHandler, org.apache.hadoop.hdds.scm.container.IncrementalContainerReportHandler] | From | To | |
| Rename Attribute | 3 | ||
| Rename Attribute replicationActivityStatus : ReplicationActivityStatus to replicationManager : ReplicationManager in class org.apache.hadoop.hdds.scm.chillmode.TestChillModeHandler | From | To | |
| Rename Attribute scheduler : Scheduler to containerStateManager : ContainerStateManager in class org.apache.hadoop.hdds.scm.container.TestContainerReportHandler | From | To | |
| Rename Attribute replicationActivityStatus : ReplicationActivityStatus to replicationManager : ReplicationManager in class org.apache.hadoop.hdds.scm.chillmode.ChillModeHandler | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type replicationActivityStatus : ReplicationActivityStatus to replicationManager : ReplicationManager in class org.apache.hadoop.hdds.scm.chillmode.ChillModeHandler | From | To | |
| Change Attribute Type scheduler : Scheduler to containerStateManager : ContainerStateManager in class org.apache.hadoop.hdds.scm.container.TestContainerReportHandler | From | To | |
| Change Attribute Type replicationActivityStatus : ReplicationActivityStatus to replicationManager : ReplicationManager in class org.apache.hadoop.hdds.scm.chillmode.TestChillModeHandler | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter containerReportFromDatanode : IncrementalContainerReportFromDatanode to report : IncrementalContainerReportFromDatanode in method public onMessage(report IncrementalContainerReportFromDatanode, publisher EventPublisher) : void in class org.apache.hadoop.hdds.scm.container.IncrementalContainerReportHandler | From | To | |
| Rename Parameter replicationStatus : ReplicationActivityStatus to replicationManager : ReplicationManager in method public ChillModeHandler(configuration Configuration, clientProtocolServer SCMClientProtocolServer, blockManager BlockManager, replicationManager ReplicationManager) in class org.apache.hadoop.hdds.scm.chillmode.ChillModeHandler | From | To |